* Push

  * New: Support for the Push 3 encoder in Scene display mode.
  * New: Push 2/3: selected notes in clip note view are now drawn darker.
  * Fixed: The play position was not drawn correctly in sequencer mode.
  * Fixed: Push 2/3 - List elements (Scale and Browser mode) were using black text on black background.

Author: git-moss

DrivenByMoss-Manual.pdf

@@ -4,7 +4,7 @@
   <groupId>de.mossgrabers</groupId>
   <artifactId>DrivenByMoss</artifactId>
   <name>DrivenByMoss</name>
-  <version>21.3.0</version>
+  <version>21.4.0</version>
   <licenses>
     <license>
       <name>LGPL-2.1-or-later</name>

dependency-reduced-pom.xml

@@ -6,7 +6,7 @@
 	<artifactId>DrivenByMoss</artifactId>
 	<packaging>jar</packaging>
 	<name>DrivenByMoss</name>
-	<version>21.3.0</version>
+	<version>21.4.0</version>
 	<properties>
 		<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
 	</properties>

pom.xml

@@ -25,6 +25,7 @@
  */
 public class ClipLauncherNavigatorImpl implements IClipLauncherNavigator
 {
+    private final ControllerHost   host;
     private final IModel           model;
     private final CursorTrack      cursorTrack;
     private final ClipLauncherSlot theClip;
@@ -41,6 +42,7 @@ public class ClipLauncherNavigatorImpl implements IClipLauncherNavigator
      */
     ClipLauncherNavigatorImpl (final ControllerHost host, final IModel model)
     {
+        this.host = host;
         this.model = model;
 
         this.singleTrackBank = host.createTrackBank (1, 0, 1);
@@ -57,9 +59,10 @@ public class ClipLauncherNavigatorImpl implements IClipLauncherNavigator
             final ISceneBank isceneBank = this.model.getSceneBank ();
             final int pageSize = isceneBank.getPageSize ();
             final int scrollPosition = isceneBank.getScrollPosition ();
-            final int newPosition = (position / pageSize) * pageSize;
+            final int newPosition = position / pageSize * pageSize;
             if (scrollPosition != newPosition)
                 isceneBank.scrollTo (newPosition);
+            isceneBank.getItem (position % pageSize).select ();
         });
 
         this.sceneBank = this.singleTrackBank.sceneBank ();
@@ -72,20 +75,21 @@ public class ClipLauncherNavigatorImpl implements IClipLauncherNavigator
     @Override
     public void navigateScenes (final boolean isLeft)
     {
-        if (isLeft)
-            this.sceneBank.scrollBackwards ();
-        else
-            this.sceneBank.scrollForwards ();
-        this.theClip.select ();
-        this.theClip.showInEditor ();
+        this.navigateClips (isLeft);
+        this.host.scheduleTask ( () -> this.sceneBank.getItemAt (0).selectInEditor (), 100);
     }
 
 
     /** {@inheritDoc} */
     @Override
     public void navigateClips (final boolean isLeft)
     {
-        this.navigateScenes (isLeft);
+        if (isLeft)
+            this.sceneBank.scrollBackwards ();
+        else
+            this.sceneBank.scrollForwards ();
+        this.theClip.select ();
+        this.theClip.showInEditor ();
     }
 
 

src/main/java/de/mossgrabers/bitwig/framework/daw/ClipLauncherNavigatorImpl.java

@@ -1261,7 +1261,7 @@ private NoteStep getNoteStep (final NotePosition notePosition)
      *
      * @return The clip
      */
-    private Clip getClip ()
+    public Clip getClip ()
     {
         return this.launcherClip;
     }

src/main/java/de/mossgrabers/bitwig/framework/daw/CursorClipImpl.java

@@ -60,6 +60,7 @@ public void updateData (final NoteStep stepInfo)
                 break;
         }
 
+        this.isSelected = stepInfo.isIsSelected ();
         this.isMuted = stepInfo.isMuted ();
         this.duration = stepInfo.duration ();
         this.velocity = stepInfo.velocity ();

src/main/java/de/mossgrabers/bitwig/framework/daw/StepInfoImpl.java

@@ -589,7 +589,7 @@ public void changeLoopLength (final boolean increase, final boolean slow)
     @Override
     public double getLoopEnd ()
     {
-        return getLoopStart () + this.transport.arrangerLoopDuration ().get ();
+        return this.getLoopStart () + this.transport.arrangerLoopDuration ().get ();
     }
 
 

src/main/java/de/mossgrabers/bitwig/framework/daw/TransportImpl.java

@@ -31,6 +31,7 @@ public class Push3ControllerDefinition extends DefaultControllerDefinition
     /** Push 3 USB display endpoint. */
     private static final byte  ENDPOINT_ADDRESS = (byte) 0x01;
 
+
     /**
      * Constructor.
      */

src/main/java/de/mossgrabers/controller/ableton/push/Push3ControllerDefinition.java

@@ -1309,7 +1309,7 @@ public int getPedal1 ()
 
     /**
      * Set use CV output or foot switch 1.
-     * 
+     *
      * @param pedal 0 = Footswitch, 1 = CV Out
      */
     public void setPedal1 (final int pedal)
@@ -1342,7 +1342,7 @@ public int getPedal2 ()
 
     /**
      * Set use CV output or foot switch 1.
-     * 
+     *
      * @param pedal 0 = Footswitch, 1 = CV Out
      */
     public void setPedal2 (final int pedal)
@@ -1477,7 +1477,7 @@ public int getPreamp2Gain ()
 
     /**
      * Set the gain for pre-amp 2.
-     * 
+     *
      * @param preampGain The gain
      */
     public void setPreamp2Gain (final int preampGain)
@@ -1500,7 +1500,7 @@ public void changePreamp2Gain (final int control)
 
     /**
      * Get the index of the audio output configuration.
-     * 
+     *
      * @return The configuration index
      */
     public int getAudioOutputs ()
@@ -1511,7 +1511,7 @@ public int getAudioOutputs ()
 
     /**
      * Set the output configuration.
-     * 
+     *
      * @param audioOutputs The index of the audio output configuration to set
      */
     public void setAudioOutputs (final int audioOutputs)

src/main/java/de/mossgrabers/controller/ableton/push/PushConfiguration.java

@@ -490,7 +490,7 @@ public PushControlSurface (final IHost host, final ColorManager colorManager, fi
 
         this.notifyViewChange = false;
 
-        if (this.padGrid instanceof PushPadGrid pushPadGrid)
+        if (this.padGrid instanceof final PushPadGrid pushPadGrid)
             pushPadGrid.setSurface (this);
 
         for (int i = 0; i < this.colorPalette.length; i++)
@@ -553,9 +553,7 @@ protected void handleMidi (final int status, final int data1, final int data2)
             // Ignore MPE messages
             if (channel > 0)
             {
-                if (code == MidiConstants.CMD_CC && data1 == 74)
-                    return;
-                if (code == MidiConstants.CMD_PITCHBEND)
+                if ((code == MidiConstants.CMD_CC && data1 == 74) || (code == MidiConstants.CMD_PITCHBEND))
                     return;
             }
         }