Final fixes 21.1.

Author: git-moss

DrivenByMoss-Manual.pdf

@@ -81,6 +81,8 @@ public class HostImpl implements IHost
         CAPABILITIES.add (Capability.HAS_PARAMETER_PAGE_SECTION);
         CAPABILITIES.add (Capability.HAS_EFFECT_BANK);
         CAPABILITIES.add (Capability.HAS_BROWSER_PREVIEW);
+
+        CAPABILITIES.add (Capability.MPE_PITCH_RANGE);
     }
 
     private final ControllerHost   host;

src/main/java/de/mossgrabers/bitwig/framework/daw/HostImpl.java

@@ -15,6 +15,7 @@
 import de.mossgrabers.framework.daw.midi.IMidiInput;
 import de.mossgrabers.framework.daw.midi.IMidiOutput;
 import de.mossgrabers.framework.daw.midi.INoteInput;
+import de.mossgrabers.framework.daw.midi.MidiConstants;
 import de.mossgrabers.framework.featuregroup.IExpressionView;
 import de.mossgrabers.framework.utils.StringUtils;
 
@@ -539,6 +540,25 @@ protected void handleMidi (final int status, final int data1, final int data2)
         if (status == 254)
             return;
 
+        if (this.configuration.getPushVersion () == PushVersion.VERSION_3)
+        {
+            final int code = status & 0xF0;
+            final int channel = status & 0xF;
+
+            // Ignore all MIDI notes off on startup
+            if (channel == 0 && code == MidiConstants.CMD_CC && data1 == 123)
+                return;
+
+            // Ignore MPE messages
+            if (channel > 0)
+            {
+                if (code == MidiConstants.CMD_CC && data1 == 74)
+                    return;
+                if (code == MidiConstants.CMD_PITCHBEND)
+                    return;
+            }
+        }
+
         super.handleMidi (status, data1, data2);
     }
 

src/main/java/de/mossgrabers/controller/ableton/push/controller/PushControlSurface.java

@@ -11,6 +11,7 @@
 import de.mossgrabers.framework.controller.display.IGraphicDisplay;
 import de.mossgrabers.framework.controller.display.ITextDisplay;
 import de.mossgrabers.framework.daw.IModel;
+import de.mossgrabers.framework.daw.constants.Capability;
 import de.mossgrabers.framework.daw.data.IItem;
 import de.mossgrabers.framework.daw.resource.ChannelType;
 import de.mossgrabers.framework.featuregroup.AbstractFeatureGroup;
@@ -174,7 +175,10 @@ public void updateDisplay2 (final IGraphicDisplay display)
         final int slideHeight = config.getInTuneSlideHeight ();
 
         display.addParameterElement ("MPE", true, "", (ChannelType) null, null, false, "MPE", isMPEEnabled ? 1023 : 0, isMPEEnabled ? "On" : "Off", this.isKnobTouched (1), -1);
-        display.addParameterElement ("Info", false, "", (ChannelType) null, null, false, "PB Range", mpePitchBendRange * 1023 / 96, Integer.toString (mpePitchBendRange), this.isKnobTouched (2), -1);
+        if (this.surface.getHost ().supports (Capability.MPE_PITCH_RANGE))
+            display.addParameterElement ("Info", false, "", (ChannelType) null, null, false, "PB Range", mpePitchBendRange * 1023 / 96, Integer.toString (mpePitchBendRange), this.isKnobTouched (2), -1);
+        else
+            display.addOptionElement ("", "Info", false, "", "", false, true);
         display.addParameterElement (" ", false, "", (ChannelType) null, null, false, "Per-Pad PB", isPerPadPitchbendEnabled ? 1023 : 0, isPerPadPitchbendEnabled ? "On" : "Off", this.isKnobTouched (3), -1);
         display.addParameterElement (" ", false, "", (ChannelType) null, null, false, "Location", inTuneLocation == 0 ? 0 : 1023, PushConfiguration.IN_TUNE_LOCATION_OPTIONS[inTuneLocation], this.isKnobTouched (4), -1);
         display.addParameterElement (" ", false, "", (ChannelType) null, null, false, "Width (mm)", inTuneWidth * 1023 / (PushConfiguration.IN_TUNE_WIDTH_OPTIONS.length - 1), PushConfiguration.IN_TUNE_WIDTH_OPTIONS[inTuneWidth], this.isKnobTouched (5), -1);

src/main/java/de/mossgrabers/controller/ableton/push/mode/MPEConfigurationMode.java

@@ -13,7 +13,6 @@
 import de.mossgrabers.framework.daw.data.IScene;
 import de.mossgrabers.framework.daw.data.bank.ISceneBank;
 import de.mossgrabers.framework.featuregroup.AbstractFeatureGroup;
-import de.mossgrabers.framework.featuregroup.IExpressionView;
 import de.mossgrabers.framework.utils.ButtonEvent;
 import de.mossgrabers.framework.view.AbstractChordView;
 import de.mossgrabers.framework.view.AbstractSessionView;
@@ -25,7 +24,7 @@
  *
  * @author Jürgen Moßgraber
  */
-public class ChordsView extends AbstractChordView<PushControlSurface, PushConfiguration> implements IExpressionView
+public class ChordsView extends AbstractChordView<PushControlSurface, PushConfiguration>
 {
     /**
      * Constructor.

src/main/java/de/mossgrabers/controller/ableton/push/view/ChordsView.java

@@ -14,6 +14,7 @@
 import de.mossgrabers.framework.daw.data.IDrumDevice;
 import de.mossgrabers.framework.daw.data.IDrumPad;
 import de.mossgrabers.framework.daw.data.bank.IDrumPadBank;
+import de.mossgrabers.framework.featuregroup.IExpressionView;
 import de.mossgrabers.framework.featuregroup.ModeManager;
 import de.mossgrabers.framework.mode.Modes;
 import de.mossgrabers.framework.utils.ButtonEvent;
@@ -26,7 +27,7 @@
  *
  * @author Jürgen Moßgraber
  */
-public class DrumView extends AbstractDrumView<PushControlSurface, PushConfiguration>
+public class DrumView extends AbstractDrumView<PushControlSurface, PushConfiguration> implements IExpressionView
 {
     /**
      * Constructor.

src/main/java/de/mossgrabers/controller/ableton/push/view/DrumView.java

@@ -47,5 +47,8 @@ public enum Capability
     /** The host has a dedicated send bank. */
     HAS_EFFECT_BANK,
     /** The host supports browser preview. */
-    HAS_BROWSER_PREVIEW
+    HAS_BROWSER_PREVIEW,
+
+    /** MPE supports pitch range. */
+    MPE_PITCH_RANGE
 }