Turn on ifversion rule and fix bug (#55454)

Author: rachmari

data/reusables/contributing/content-linter-rules.md

@@ -56,11 +56,13 @@
 | GHD018 | liquid-syntax | Markdown content must use valid Liquid | error | liquid |
 | GHD019 | liquid-if-tags | Liquid `ifversion` tags should be used instead of `if` tags when the argument is a valid version | error | liquid, versioning |
 | GHD020 | liquid-ifversion-tags | Liquid `ifversion` tags should contain valid version names as arguments | error | liquid, versioning |
+| GHD022 | liquid-ifversion-versions | Liquid `ifversion`, `elsif`, and `else` tags should be valid and not contain unsupported versions. | error | liquid, versioning |
 | GHD035 | rai-reusable-usage | RAI articles and reusables can only reference reusable content in the data/reusables/rai directory | error | feature, rai |
 | GHD036 | image-no-gif | Image must not be a gif, styleguide reference: contributing/style-guide-and-content-model/style-guide.md#images | error | images |
 | GHD038 | expired-content | Expired content must be remediated. | error | expired |
 | GHD039 | expiring-soon | Content that expires soon should be proactively addressed. | warning | expired |
 | [GHD040](https://github.com/github/docs/blob/main/src/content-linter/README.md) | table-liquid-versioning | Tables must use the correct liquid versioning format | error | tables |
 | GHD041 | third-party-action-pinning | Code examples that use third-party actions must always pin to a full length commit SHA | error | feature, actions |
 | GHD042 | liquid-tag-whitespace | Liquid tags should start and end with one whitespace. Liquid tag arguments should be separated by only one whitespace. | error | liquid, format |
-| GHD043 | link-quotation | Internal link titles must not be surrounded by quotations | error | links, url |
+| GHD043 | link-quotation | Internal link titles must not be surrounded by quotations | error | links, url |
+| GHD022 | liquid-ifversion-versions | Liquid `ifversion`, `elsif`, and `else` tags should be valid and not contain unsupported versions. | error | liquid, versioning |

src/content-linter/lib/linting-rules/liquid-ifversion-versions.js

@@ -196,9 +196,8 @@ async function getApplicableVersionFromLiquidTag(conditionStr, filename) {
       const firstAnd = ands[0].split(' ')[0]
       // if all ands don't start with the same version it's invalid
       if (!ands.every((and) => and.startsWith(firstAnd))) {
-        console.error(
-          'The condition tag `' + conditionStr + '` is invalid. Please update ' + filename,
-        )
+        // noop - we don't handle this case
+        // TODO - handle this case in the future
         return []
       }
       const andValues = []

src/content-linter/style/github-docs.js

@@ -89,12 +89,12 @@ const githubDocsConfig = {
     'partial-markdown-files': true,
     'yml-files': true,
   },
-  // 'liquid-ifversion-versions': {
-  //   // GHD022
-  //   severity: 'error',
-  //   'partial-markdown-files': true,
-  //   'yml-files': true,
-  // },
+  'liquid-ifversion-versions': {
+    // GHD022
+    severity: 'error',
+    'partial-markdown-files': true,
+    'yml-files': true,
+  },
   'yaml-scheduled-jobs': {
     // GHD021
     severity: 'error',
@@ -206,12 +206,12 @@ export const githubDocsFrontmatterConfig = {
     severity: 'error',
     'partial-markdown-files': false,
   },
-  // 'liquid-ifversion-versions': {
-  //   // GHD022
-  //   severity: 'error',
-  //   'partial-markdown-files': true,
-  //   'yml-files': true,
-  // },
+  'liquid-ifversion-versions': {
+    // GHD022
+    severity: 'error',
+    'partial-markdown-files': true,
+    'yml-files': true,
+  },
   'link-quotation': {
     // GHD043
     severity: 'error',

src/ghes-releases/scripts/version-utils.ts

@@ -58,5 +58,7 @@ export function isAllVersions(versions: FrontmatterVersions) {
 export function getFeatureVersionsObject(feature: string) {
   const featureDataDir = process.env.ROOT ? `${process.env.ROOT}/data/features` : 'data/features'
   const featureData = getDataDirectory(featureDataDir) as FeatureData
+  const featureValue = featureData[feature]
+  if (!featureValue) return {}
   return featureData[feature].versions
 }

src/versions/lib/get-applicable-versions.js

@@ -40,7 +40,7 @@ function getApplicableVersions(versionsObj, filepath, opts = {}) {
     (result, value, key) => {
       if (key === 'feature') {
         if (typeof value === 'string') {
-          Object.assign(result, { ...featureData[value].versions })
+          Object.assign(result, { ...featureData[value]?.versions })
         } else if (Array.isArray(value)) {
           value.forEach((str) => {
             Object.assign(result, { ...featureData[str].versions })