Merge pull request #117 from jmr/polyline-interp-test

rsned · web-flow · commit 69a8a986ba10 · 2025-03-19T13:56:25.000-07:00
TestPolylineInterpolate: Fix unused `want` var
diff --git a/s2/polyline_test.go b/s2/polyline_test.go
@@ -526,7 +526,6 @@ func TestPolylineInterpolate(t *testing.T) {
 	}
 	line := Polyline(vertices)
 
-	want := vertices[0]
 	point, next := line.Interpolate(-0.1)
 	if point != vertices[0] {
 		t.Errorf("%v.Interpolate(%v) = %v, want %v", line, -0.1, point, vertices[0])
@@ -535,7 +534,7 @@ func TestPolylineInterpolate(t *testing.T) {
 		t.Errorf("%v.Interpolate(%v) = %v, want %v", line, -0.1, next, 1)
 	}
 
-	want = PointFromCoords(1, math.Tan(0.2*math.Pi/2.0), 0)
+	want := PointFromCoords(1, math.Tan(0.2*math.Pi/2.0), 0)
 	if got, _ := line.Interpolate(0.1); !got.ApproxEqual(want) {
 		t.Errorf("%v.Interpolate(%v) = %v, want %v", line, 0.1, got, want)
 	}

Original file line number	Diff line number	Diff line change
`@@ -526,7 +526,6 @@ func TestPolylineInterpolate(t *testing.T) {`
`526`	`526`	`}`
`527`	`527`	`line := Polyline(vertices)`
`528`	`528`
`529`		`- want := vertices[0]`
`530`	`529`	`point, next := line.Interpolate(-0.1)`
`531`	`530`	`if point != vertices[0] {`
`532`	`531`	`t.Errorf("%v.Interpolate(%v) = %v, want %v", line, -0.1, point, vertices[0])`
`@@ -535,7 +534,7 @@ func TestPolylineInterpolate(t *testing.T) {`
`535`	`534`	`t.Errorf("%v.Interpolate(%v) = %v, want %v", line, -0.1, next, 1)`
`536`	`535`	`}`
`537`	`536`
`538`		`- want = PointFromCoords(1, math.Tan(0.2*math.Pi/2.0), 0)`
	`537`	`+ want := PointFromCoords(1, math.Tan(0.2*math.Pi/2.0), 0)`
`539`	`538`	`if got, _ := line.Interpolate(0.1); !got.ApproxEqual(want) {`
`540`	`539`	`t.Errorf("%v.Interpolate(%v) = %v, want %v", line, 0.1, got, want)`
`541`	`540`	`}`