Skip to content

Commit ae34cfa

Browse files
jeanbzajba
authored andcommitted
static/frontend: update the logo styling to not have an explicit width
If a company wants to run their own version of pkgsite, the easiest way to differentiate it from pkg.go.dev is to put their company logo (or some text, like INTERNAL) in the logo SVG next to the GO. However, doing so increases the width of the logo. In the current CSS, a wider logo means it gets shrunk down, because the width and height are constrained by css. This CL removes the width constraint, so that the logo is allowed to be wider. This will have a nearly imperceptible effect on the current pkg.go.dev style: the logo will be a few pixels wider. After a few pixels' width growth it becomes constrained by the height rule. Note: This is doubly important as a CL to upstream because it's very hard to patch in this change, as it requires a change to the minified files. It's quite hard to come up with the appropriate sed command that performs a patch to the minified files. Change-Id: I717553204888a7438a9f2c93f428bc166f095e09 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/685955 kokoro-CI: kokoro <[email protected]> Reviewed-by: Jonathan Amsterdam <[email protected]> Reviewed-by: Chressie Himpel <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Mark Freeman <[email protected]>
1 parent d4de666 commit ae34cfa

File tree

77 files changed

+3
-4
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

77 files changed

+3
-4
lines changed

static/frontend/frontend.min.css

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

static/frontend/frontend.min.css.map

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

static/shared/header/header.css

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,6 @@
100100
display: block;
101101
height: 2rem;
102102
margin-right: 2.25rem;
103-
width: 5.125rem;
104103
}
105104

106105
.go-Header-logo--hidden {
25 Bytes
24 Bytes
35 Bytes
20 Bytes
38 Bytes
17 Bytes
12 Bytes

0 commit comments

Comments
 (0)