Fix http timeout

Author: vigoo

golem-worker-executor-base/src/durable_host/http/types.rs

@@ -6,6 +6,7 @@ use http::{HeaderName, HeaderValue};
 
 use std::collections::HashMap;
 use std::str::FromStr;
+use tracing::info;
 
 use wasmtime::component::Resource;
 use wasmtime_wasi::preview2::subscribe;
@@ -251,6 +252,7 @@ impl<Ctx: WorkerCtx> HostRequestOptions for DurableWorkerCtx<Ctx> {
         ms: Option<Duration>,
     ) -> anyhow::Result<Result<(), ()>> {
         record_host_function_call("http::types::request_options", "set_connect_timeout_ms");
+        info!("set_connect_timeout {ms:?}");
         HostRequestOptions::set_connect_timeout(&mut self.as_wasi_http_view(), self_, ms)
     }
 

golem-worker-executor-base/tests/wasi.rs

@@ -349,6 +349,7 @@ async fn http_client() {
     let template_id = executor.store_template(Path::new("../test-templates/http-client.wasm"));
     let mut env = HashMap::new();
     env.insert("PORT".to_string(), host_http_port.to_string());
+    env.insert("RUST_BACKTRACE".to_string(), "full".to_string());
 
     let worker_id = executor
         .try_start_worker_versioned(&template_id, 0, "http-client-1", vec![], env)

test-templates/http-client.wasm

@@ -82,9 +82,9 @@ fn send_request() -> types::FutureIncomingResponse {
     types::OutgoingBody::finish(request_body, None).unwrap();
 
     let options = types::RequestOptions::new();
-    options.set_connect_timeout(Some(10000)).unwrap();
-    options.set_first_byte_timeout(Some(10000)).unwrap();
-    options.set_between_bytes_timeout(Some(10000)).unwrap();
+    options.set_connect_timeout(Some(5000000000)).unwrap(); // 5s
+    options.set_first_byte_timeout(Some(5000000000)).unwrap(); // 5s
+    options.set_between_bytes_timeout(Some(5000000000)).unwrap(); // 5s
 
     let future_incoming_response = outgoing_handler::handle(request, Some(options)).unwrap();
 
@@ -136,9 +136,9 @@ fn send_restart_request() {
     types::OutgoingBody::finish(request_body, None).unwrap();
 
     let options = types::RequestOptions::new();
-    options.set_connect_timeout(Some(10000)).unwrap();
-    options.set_first_byte_timeout(Some(10000)).unwrap();
-    options.set_between_bytes_timeout(Some(10000)).unwrap();
+    options.set_connect_timeout(Some(5000000000)).unwrap(); // 5s
+    options.set_first_byte_timeout(Some(5000000000)).unwrap(); // 5s
+    options.set_between_bytes_timeout(Some(5000000000)).unwrap(); // 5s
 
     let future_incoming_response = outgoing_handler::handle(request, Some(options)).unwrap();
     let _ = get_incoming_response(&future_incoming_response);

test-templates/http-client/src/lib.rs

@@ -123,13 +123,13 @@ func (t WasiHttpTransport) RoundTrip(request *http.Request) (*http.Response, err
 	}
 
 	// TODO: timeouts
-	connectTimeoutMs := go_wasi_http.None[uint64]()
-	firstByteTimeoutMs := go_wasi_http.None[uint64]()
-	betweenBytesTimeoutMs := go_wasi_http.None[uint64]()
+	connectTimeoutNanos := go_wasi_http.None[uint64]()
+	firstByteTimeoutNanos := go_wasi_http.None[uint64]()
+	betweenBytesTimeoutNanos := go_wasi_http.None[uint64]()
 	options := go_wasi_http.NewRequestOptions()
-	options.SetConnectTimeout(connectTimeoutMs)
-	options.SetFirstByteTimeout(firstByteTimeoutMs)
-	options.SetBetweenBytesTimeout(betweenBytesTimeoutMs)
+	options.SetConnectTimeout(connectTimeoutNanos)
+	options.SetFirstByteTimeout(firstByteTimeoutNanos)
+	options.SetBetweenBytesTimeout(betweenBytesTimeoutNanos)
 
 	futureResult := go_wasi_http.WasiHttp0_2_0_OutgoingHandlerHandle(requestHandle, go_wasi_http.Some(options))
 	if futureResult.IsErr() {