Fail early on self-rpc (#2177)

* fail early on self-rpc

* update

Author: mschuwalow

golem-worker-executor/src/durable_host/wasm_rpc/mod.rs

@@ -84,10 +84,16 @@ impl<Ctx: WorkerCtx> HostWasmRpc for DurableWorkerCtx<Ctx> {
         let args = self.get_arguments().await?;
         let env = self.get_environment().await?;
         let wasi_config_vars = self.wasi_config_vars();
+        let own_worker_id = self.owned_worker_id().clone();
 
         let entry = self.table().get(&self_)?;
         let payload = entry.payload.downcast_ref::<WasmRpcEntryPayload>().unwrap();
         let remote_worker_id = payload.remote_worker_id().clone();
+
+        if remote_worker_id == own_worker_id {
+            return Err(anyhow!("RPC calls to the same agent are not supported"));
+        }
+
         let connection_span_id = payload.span_id().clone();
 
         Self::add_self_parameter_if_needed(&mut function_params, payload);
@@ -220,10 +226,16 @@ impl<Ctx: WorkerCtx> HostWasmRpc for DurableWorkerCtx<Ctx> {
         let args = self.get_arguments().await?;
         let env = self.get_environment().await?;
         let wasi_config_vars = self.wasi_config_vars();
+        let own_worker_id = self.owned_worker_id().clone();
 
         let entry = self.table().get(&self_)?;
         let payload = entry.payload.downcast_ref::<WasmRpcEntryPayload>().unwrap();
         let remote_worker_id = payload.remote_worker_id().clone();
+
+        if remote_worker_id == own_worker_id {
+            return Err(anyhow!("RPC calls to the same agent are not supported"));
+        }
+
         let connection_span_id = payload.span_id().clone();
 
         Self::add_self_parameter_if_needed(&mut function_params, payload);
@@ -325,6 +337,7 @@ impl<Ctx: WorkerCtx> HostWasmRpc for DurableWorkerCtx<Ctx> {
         let args = self.get_arguments().await?;
         let env = self.get_environment().await?;
         let wasi_config_vars = self.wasi_config_vars();
+        let own_worker_id = self.owned_worker_id().clone();
 
         let begin_index = self
             .begin_function(&DurableFunctionType::WriteRemote)
@@ -333,6 +346,11 @@ impl<Ctx: WorkerCtx> HostWasmRpc for DurableWorkerCtx<Ctx> {
         let entry = self.table().get(&this)?;
         let payload = entry.payload.downcast_ref::<WasmRpcEntryPayload>().unwrap();
         let remote_worker_id = payload.remote_worker_id().clone();
+
+        if remote_worker_id == own_worker_id {
+            return Err(anyhow!("RPC calls to the same agent are not supported"));
+        }
+
         let connection_span_id = payload.span_id().clone();
 
         Self::add_self_parameter_if_needed(&mut function_params, payload);

golem-worker-executor/tests/agent.rs

@@ -12,14 +12,63 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+use crate::common::{start, TestContext};
 use crate::{LastUniqueId, Tracing, WorkerExecutorTestDependencies};
-use golem_wasm_ast::analysis::wit_parser::SharedAnalysedTypeResolve;
-use test_r::inherit_test_dep;
+use assert2::assert;
+use assert2::let_assert;
+use golem_api_grpc::proto::golem::worker::v1::worker_error::Error;
+use golem_api_grpc::proto::golem::worker::v1::{
+    worker_execution_error, InvocationFailed, WorkerExecutionError,
+};
+use golem_api_grpc::proto::golem::worker::{UnknownError, WorkerError};
+use golem_test_framework::config::TestDependencies;
+use golem_test_framework::dsl::TestDslUnsafe;
+use test_r::{inherit_test_dep, test};
 
 inherit_test_dep!(WorkerExecutorTestDependencies);
 inherit_test_dep!(LastUniqueId);
 inherit_test_dep!(Tracing);
-inherit_test_dep!(
-    #[tagged_as("golem_host")]
-    SharedAnalysedTypeResolve
-);
+
+#[test]
+#[tracing::instrument]
+async fn agent_self_rpc_is_not_allowed(
+    last_unique_id: &LastUniqueId,
+    deps: &WorkerExecutorTestDependencies,
+    _tracing: &Tracing,
+) {
+    let context = TestContext::new(last_unique_id);
+    let executor = start(deps, &context).await.unwrap().into_admin().await;
+
+    let component_id = executor.component("golem_it_agent_self_rpc").store().await;
+    let worker_id = executor
+        .start_worker(&component_id, "self-rpc-agent(\"worker-name\")")
+        .await;
+
+    let result = executor
+        .invoke_and_await(
+            &worker_id,
+            "golem-it:agent-self-rpc/self-rpc-agent.{self-rpc}",
+            vec![],
+        )
+        .await;
+
+    let_assert!(
+        Err(Error::InternalError(WorkerExecutionError {
+            error: Some(worker_execution_error::Error::InvocationFailed(
+                InvocationFailed {
+                    error: Some(WorkerError {
+                        error: Some(
+                            golem_api_grpc::proto::golem::worker::worker_error::Error::UnknownError(
+                                UnknownError {
+                                    details: error_details
+                                }
+                            )
+                        )
+                    }),
+                    ..
+                }
+            ))
+        })) = result
+    );
+    assert!(error_details.contains("RPC calls to the same agent are not supported"));
+}

test-components/agent-self-rpc/.gitignore

@@ -0,0 +1,3 @@
+/dist
+/golem-temp
+/node_modules

test-components/agent-self-rpc/common-ts/golem.yaml

@@ -0,0 +1,52 @@
+# Schema for IDEA:
+# $schema: https://schema.golem.cloud/app/golem/1.3.0-rc1/golem.schema.json
+# Schema for vscode-yaml
+# yaml-language-server: $schema=https://schema.golem.cloud/app/golem/1.3.0-rc1/golem.schema.json
+
+# See https://learn.golem.cloud/docs/app-manifest#field-reference for field reference
+# For creating APIs see https://learn.golem.cloud/invoke/making-custom-apis
+
+templates:
+  ts:
+    build:
+    - command: npx tsc --noEmit false --emitDeclarationOnly --declaration --outFile ../../golem-temp/ts-check/{{ component_name | to_kebab_case }}/main.d.ts
+      sources:
+      - src
+      - ../../common-ts
+      - tsconfig.js
+      targets:
+      - ../../golem-temp/ts-check/{{ component_name | to_kebab_case }}/main.d.ts
+    - command: npx --no golem-typegen ../../../components-ts/{{ component_name | to_kebab_case }}/tsconfig.json --files ../../../components-ts/{{ component_name | to_kebab_case }}/src/**/*.ts
+      dir: ../../golem-temp/ts-metadata/{{ component_name | to_kebab_case }}
+      sources:
+      - ../../../components-ts/{{ component_name | to_kebab_case }}/src
+      targets:
+      - .metadata
+    - command: npx --no rollup -- -c
+      sources:
+      - src
+      - ../../common-ts
+      - rollup.config.mjs
+      - tsconfig.js
+      - ../../golem-temp/ts-metadata/{{ component_name | to_kebab_case }}
+      targets:
+      - ../../golem-temp/ts-dist/{{ component_name | to_kebab_case }}/main.js
+    - injectToPrebuiltQuickjs: ../../node_modules/@golemcloud/golem-ts-sdk/wasm/agent_guest.wasm
+      module: ../../golem-temp/ts-dist/{{ component_name | to_kebab_case }}/main.js
+      moduleWasm: ../../golem-temp/agents/{{ component_name | to_snake_case }}.module.wasm
+      into: ../../golem-temp/agents/{{ component_name | to_snake_case }}.dynamic.wasm
+    - generateAgentWrapper: ../../golem-temp/agents/{{ component_name | to_snake_case }}.wrapper.wasm
+      basedOnCompiledWasm: ../../golem-temp/agents/{{ component_name | to_snake_case }}.dynamic.wasm
+    - composeAgentWrapper: ../../golem-temp/agents/{{ component_name | to_snake_case }}.wrapper.wasm
+      withAgent: ../../golem-temp/agents/{{ component_name | to_snake_case }}.dynamic.wasm
+      to: ../../golem-temp/agents/{{ component_name | to_snake_case }}.static.wasm
+    sourceWit: ../../node_modules/@golemcloud/golem-ts-sdk/wasm/agent_guest.wasm
+    generatedWit: ../../golem-temp/agents/{{ component_name | to_snake_case }}/wit-generated
+    componentWasm: ../../golem-temp/agents/{{ component_name | to_snake_case }}.static.wasm
+    linkedWasm: ../../golem-temp/agents/{{ component_name | to_snake_case }}.wasm
+    customCommands:
+      copy:
+      - command: cp ../../golem-temp/agents/{{ component_name | to_snake_case }}.wasm ../../../{{ component_name | to_snake_case }}.wasm
+customCommands:
+  ts-npm-install:
+  - command: npm install

test-components/agent-self-rpc/common-ts/rollup.config.component.mjs

@@ -0,0 +1,83 @@
+import alias from "@rollup/plugin-alias";
+import commonjs from "@rollup/plugin-commonjs";
+import json from "@rollup/plugin-json";
+import nodeResolve from "@rollup/plugin-node-resolve";
+import typescript from "@rollup/plugin-typescript";
+import url from "node:url";
+import path from "node:path";
+
+export default function componentRollupConfig(componentName) {
+    const dir = path.dirname(url.fileURLToPath(import.meta.url));
+
+    const externalPackages = (id) => {
+        return (
+            id === "@golemcloud/golem-ts-sdk" ||
+            id.startsWith("golem:")
+        );
+    };
+
+    const virtualAgentMainId = "virtual:agent-main";
+    const resolvedVirtualAgentMainId = "\0virtual:agent-main";
+
+    const virtualAgentMainPlugin = () => {
+        return {
+            name: "agent-main",
+            resolveId(id) {
+                if (id === virtualAgentMainId) {
+                    return resolvedVirtualAgentMainId;
+                }
+            },
+            load(id) {
+                if (id === resolvedVirtualAgentMainId) {
+                    return `
+import { TypescriptTypeRegistry } from '@golemcloud/golem-ts-sdk';
+import { Metadata } from '../../golem-temp/ts-metadata/${componentName}/.metadata/generated-types';
+
+TypescriptTypeRegistry.register(Metadata);
+
+// Using an async function to prevent rollup from reordering registration and main import.
+export default (async () => { return await import("./src/main");})();
+`
+                }
+            }
+        };
+    }
+
+    return {
+        input: virtualAgentMainId,
+        output: {
+            file: `../../golem-temp/ts-dist/${componentName}/main.js`,
+            format: "esm",
+            inlineDynamicImports: true,
+            sourcemap: false,
+        },
+        external: externalPackages,
+        plugins: [
+            virtualAgentMainPlugin(),
+            alias({
+                entries: [
+                    {
+                        find: "common",
+                        replacement: path.resolve(dir, "../common-ts/src"),
+                    },
+                ],
+            }),
+            nodeResolve({
+                extensions: [".mjs", ".js", ".node", ".ts"],
+            }),
+            commonjs({
+                include: ["../../node_modules/**"],
+            }),
+            json(),
+            typescript({
+                noEmitOnError: true,
+                include: [
+                    "./src/**/*.ts",
+                    ".agent/**/*.ts",
+                    ".metadata/**/*.ts",
+                    "../../common-ts/src/**/*.ts",
+                ],
+            }),
+        ],
+    };
+}

test-components/agent-self-rpc/common-ts/src/lib.ts

@@ -0,0 +1,3 @@
+export function exampleCommonFunction() {
+    return "hello common";
+}

test-components/agent-self-rpc/common-ts/tsconfig.component.json

@@ -0,0 +1,23 @@
+{
+  "$schema": "https://json.schemastore.org/tsconfig",
+  "compilerOptions": {
+    "skipLibCheck": true,
+    "target": "ES2020",
+    "noEmit": true,
+    "lib": ["ES2020"],
+    "types": ["node"],
+    "moduleResolution": "bundler",
+    "checkJs": false,
+    "strict": true,
+    "noUncheckedIndexedAccess": true,
+    "noImplicitOverride": true,
+    "resolveJsonModule": true,
+    "esModuleInterop": true,
+    "experimentalDecorators": true,
+    "emitDecoratorMetadata": true,
+    "useDefineForClassFields": false,
+    "paths": {
+      "common/*": ["../common-ts/src/*"]
+    }
+  }
+}

test-components/agent-self-rpc/components-ts/.gitignore

@@ -0,0 +1,4 @@
+/*/dist
+/*/src/generated
+/*/wit-generated
+/*/.metadata