Skip to content

Conversation

@lacop11
Copy link

@lacop11 lacop11 commented Aug 21, 2025

When running this action with large number of environment variables the resulting gcloud command gets very long, and if it fails the error message visible in github actions output is cut off before it gets to the actually useful bit with the error message, making it impossible to tell what went wrong.

This adjusts the message the put the command at the end. It's likely less interesting since it's constructed from inputs the user provides anyway.

When running this action with large number of environment variables the
resulting gcloud command gets very long, and if it fails the error
message visible in github actions output is cut off before it gets to
the actually useful bit with the error message, making it impossible to
tell what went wrong.

This adjusts the message the put the command at the end. It's likely
less interesting since it's constructed from inputs the user provides
anyway.
@lacop11 lacop11 requested a review from a team as a code owner August 21, 2025 10:48
@lacop11 lacop11 requested review from sethvargo and verbanicm August 21, 2025 10:48
@google-cla
Copy link

google-cla bot commented Aug 21, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@sethvargo
Copy link
Contributor

Thanks for the fix @lacop11. Could you please sign the CLA?

I've also noticed this annoying behavior with long commands. Do you think using a newline would help? It's not clear to me whether this is a string length limit or a horizontal scroll limit.

sethvargo added a commit that referenced this pull request Aug 24, 2025
This prevents long commands from hiding the error message

Fixes #569
@lacop11
Copy link
Author

lacop11 commented Sep 2, 2025

Thanks for the fix @sethvargo . I was going to sign the CLA but was waiting for our legal team to review & approve, you were faster with your PR :) I'll get it signed anyway to have it in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants