Skip to content

Commit 4ddd08c

Browse files
committed
Use grpc's forceful stop instead of the graceful stop.
The graceful stop seems to deadlock when there are streaming RPCs.
1 parent 0553055 commit 4ddd08c

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

gapis/server/grpc.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,7 @@ func (s *grpcServer) stopIfIdle(ctx context.Context, server *grpc.Server, idleTi
138138
stoppedSignal, stopped := task.NewSignal()
139139
defer func() {
140140
stop()
141-
server.GracefulStop()
141+
server.Stop()
142142
stopped(ctx)
143143
}()
144144

@@ -171,7 +171,7 @@ func (s *grpcServer) stopOnInterrupt(ctx context.Context, server *grpc.Server, s
171171
stoppedSignal, stopped := task.NewSignal()
172172
defer func() {
173173
stop()
174-
server.GracefulStop()
174+
server.Stop()
175175
stopped(ctx)
176176
}()
177177

0 commit comments

Comments
 (0)