Implement Enterprise SCIM

[elminster-aom]

The original #2030 implemented SCIM but ...

This operation allows you to provision access to an organization on GitHub Enterprise Cloud using SCIM. The operation is not available for use with Enterprise Managed Users.

What about resuming the topic and implementing REST API endpoints for Enterprise SCIM?

• GET /scim/v2/enterprises/{enterprise}/Groups
• POST scim/v2/enterprises/{enterprise}/Groups
• GET /scim/v2/enterprises/{enterprise}/Groups/{scim_group_id}
• PUT /scim/v2/enterprises/{enterprise}/Groups/{scim_group_id}
• PATCH /scim/v2/enterprises/{enterprise}/Groups/{scim_group_id}
• DELETE /scim/v2/enterprises/{enterprise}/Groups/{scim_group_id}
• GET /scim/v2/enterprises/{enterprise}/Users
• POST /scim/v2/enterprises/{enterprise}/Users
• GET /scim/v2/enterprises/{enterprise}/Users/{scim_user_id}
• PUT /scim/v2/enterprises/{enterprise}/Users/{scim_user_id}
• PATCH /scim/v2/enterprises/{enterprise}/Users/{scim_user_id}
• DELETE /scim/v2/enterprises/{enterprise}/Users/{scim_user_id}

I'd like to do it.

[gmlewis]

Sounds great to me. Thank you, @elminster-aom! It's yours.

[elminster-aom]

From API Docs https://docs.github.com/en/enterprise-cloud@latest/rest/enterprise-admin/scim found these entry points:

• POST scim/v2/enterprises/{enterprise}/Groups
• GET /scim/v2/enterprises/{enterprise}/Groups/{scim_group_id}
• PUT /scim/v2/enterprises/{enterprise}/Groups/{scim_group_id}
• PATCH /scim/v2/enterprises/{enterprise}/Groups/{scim_group_id}
• DELETE /scim/v2/enterprises/{enterprise}/Groups/{scim_group_id}
• GET /scim/v2/enterprises/{enterprise}/Users
• POST /scim/v2/enterprises/{enterprise}/Users
• GET /scim/v2/enterprises/{enterprise}/Users/{scim_user_id}
• PUT /scim/v2/enterprises/{enterprise}/Users/{scim_user_id}
• PATCH /scim/v2/enterprises/{enterprise}/Users/{scim_user_id}
• DELETE /scim/v2/enterprises/{enterprise}/Users/{scim_user_id}

However, there's one already implemented on /github/scim.go#L284-L308:

• GET /scim/v2/enterprises/{enterprise}/Groups

Shouldn't it be under under EnterpriseService rather than SCIMService? Or am I missing something?

[gmlewis]

Shouldn't it be under under EnterpriseService rather than SCIMService? Or am I missing something?

Hmm... Maybe EnterpriseService is a better home for that endpoint after all.
Maybe we should make a breaking API change and move it.

Thoughts?

cc: @stevehipwell - @alexandear - @zyfy29

[elminster-aom]

What about marking the actual one as deprecated, and implement it again with a slightly different name? see f7d36fc

[gmlewis]

What about marking the actual one as deprecated, and implement it again with a slightly different name? see f7d36fc

Well, if they both do the same thing, then I don't think that is necessary. If we agree that it should be moved to a different service, then we should just make the breaking change and announce it as a breaking change in my opinion.

[elminster-aom]

we should just make the breaking change and announce it as a breaking change in my opinion.

That is also good for me... I'll implement it as so.

[stevehipwell]

Shouldn't it be under under EnterpriseService rather than SCIMService? Or am I missing something?

Hmm... Maybe EnterpriseService is a better home for that endpoint after all.
Maybe we should make a breaking API change and move it.

@gmlewis I'm in favour of this.

[elminster-aom]

Maybe we should make a breaking API change and move it.

The breaking API PR #3814 is ready for review

[elminster-aom]

@gmlewis Please reopen issue, I'd like to track here all Enterprise SCIM endpoints pending to implement
Up to now, only one is done. I will go on doing the rest.

[gmlewis]

@gmlewis Please reopen issue, I'd like to track here all Enterprise SCIM endpoints pending to implement Up to now, only one is done. I will go on doing the rest.

WHUPS! Sorry. Reopening. Thank you, @elminster-aom!