Commit ae22f8a
Improve
- Specify versions for plugins that we use so that we get a deterministic version, not the latest(?) at the time of the run. Compare cl/711438220.
- I'm confused that I still see a warning for `maven-deploy-plugin`, which should be getting automatically disabled by `central-publishing-maven-plugin`, as apparently worked during the jimfs 1.3.1 release:
```
[WARNING] Ignoring incompatible plugin version 4.0.0-beta-2: The plugin org.apache.maven.plugins:maven-deploy-plugin:4.0.0-beta-2 requires Maven version 4.0.0-rc-2
[INFO] Latest version of plugin org.apache.maven.plugins:maven-deploy-plugin failed compatibility check
[INFO] Looking for compatible RELEASE version of plugin org.apache.maven.plugins:maven-deploy-plugin
[WARNING] Ignoring incompatible plugin version 4.0.0-beta-1: The plugin org.apache.maven.plugins:maven-deploy-plugin:4.0.0-beta-1 requires Maven version 4.0.0-beta-3
[INFO] Selected plugin org.apache.maven.plugins:maven-deploy-plugin:3.1.4
```
Oddly, I do _not_ see such a warning when running the same command (`mvn clean install`) in Guava.
- Add a warning that `maven-jar-plugin` configuration is not used because it's disabled by `maven-bundle-plugin`.
- Compare a similar comment I added to the top-level `pom.xml` in cl/740019355 for Guava.
- This warning becomes more important now that a section exists for `maven-jar-plugin` (to address the warnings mentioned above), but it would probably be safest to include, anyway, for anyone who might try to _add_ a `maven-jar-plugin` section.
- While in the area, sort our plugins by name.
- For Guava, chaorenl's cl/715960471 not only set up sorting but also automated enforcement. That would be trickier for cases in which we import PRs (b/411381570), so I haven't set it up here yet.
- Always use the ID "`attach-javadocs`" for `maven-javadoc-plugin`. Until now, we were mising [`attach-javadocs`](https://github.com/google/jimfs/blob/bc03e931a923a633dbb3c6c37f951706c7f20c2e/pom.xml#L236) and [`attach-docs`](https://github.com/google/jimfs/blob/bc03e931a923a633dbb3c6c37f951706c7f20c2e/jimfs/pom.xml#L93). That eliminates this warning:
```
[INFO] --- javadoc:3.12.0:jar (attach-javadocs) @ jimfs ---
[WARNING] Javadoc Warnings
[WARNING] warning: The code being documented uses packages in the unnamed module, but the packages defined in https://docs.oracle.com/en/java/javase/11/docs/api/ are in named modules.
[WARNING] 1 warning
[INFO] Building jar: /usr/local/google/home/cpovirk/clients/jimfs-orange/jimfs/jimfs/target/jimfs-HEAD-SNAPSHOT-javadoc.jar
[INFO]
[INFO] --- source:3.3.1:jar-no-fork (attach-sources) @ jimfs ---
[INFO] Building jar: /usr/local/google/home/cpovirk/clients/jimfs-orange/jimfs/jimfs/target/jimfs-HEAD-SNAPSHOT-sources.jar
[INFO]
[INFO] --- javadoc:3.12.0:jar (attach-docs) @ jimfs ---
[INFO] Building jar: /usr/local/google/home/cpovirk/clients/jimfs-orange/jimfs/jimfs/target/jimfs-HEAD-SNAPSHOT-javadoc.jar
[WARNING] artifact com.google.jimfs:jimfs:javadoc:javadoc:HEAD-SNAPSHOT already attached, replace previous instance
```
- The ID `attach-javadocs` seems to be more common (though not universal!) across our projects, and it's [mentioned by the documentation](https://maven.apache.org/plugins/maven-javadoc-plugin/faq.html#:~:text=attach%2Djavadocs).
- As best I can tell, there was no reason to specify the ID at all in the child POM, so I removed it there and fixed it in the parent.
- Remove `post-integration-test` `phase` configuration for `maven-javadoc-plugin`. I don't think we have that set in any of our other projects. I think I recently removed a weird choice of `phase` in another project.
- Promote some Java 8+ `-doclint` configuration from a profile to the default. We always build on Java 8+ nowadays, especially since we [dropped support for Java 7](https://github.com/google/jimfs/releases/tag/v1.3.0) a couple years back.
RELNOTES=n/a
PiperOrigin-RevId: 814204365pom.xml files:1 parent bc03e93 commit ae22f8a
2 files changed
+20
-45
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
88 | 88 | | |
89 | 89 | | |
90 | 90 | | |
91 | | - | |
92 | | - | |
93 | | - | |
94 | | - | |
95 | | - | |
96 | | - | |
97 | | - | |
98 | | - | |
99 | | - | |
100 | 91 | | |
101 | 92 | | |
102 | 93 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
151 | 151 | | |
152 | 152 | | |
153 | 153 | | |
154 | | - | |
155 | | - | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
156 | 160 | | |
157 | 161 | | |
158 | 162 | | |
| |||
169 | 173 | | |
170 | 174 | | |
171 | 175 | | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
172 | 179 | | |
173 | 180 | | |
174 | 181 | | |
175 | | - | |
176 | | - | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
177 | 193 | | |
178 | 194 | | |
179 | 195 | | |
| |||
263 | 279 | | |
264 | 280 | | |
265 | 281 | | |
266 | | - | |
267 | | - | |
268 | | - | |
269 | | - | |
270 | | - | |
271 | | - | |
272 | | - | |
273 | | - | |
274 | | - | |
275 | | - | |
276 | | - | |
277 | | - | |
278 | | - | |
279 | | - | |
280 | | - | |
281 | | - | |
282 | | - | |
283 | | - | |
284 | | - | |
285 | | - | |
286 | | - | |
287 | | - | |
288 | | - | |
289 | | - | |
290 | | - | |
291 | | - | |
292 | | - | |
293 | | - | |
294 | | - | |
295 | | - | |
296 | | - | |
297 | | - | |
298 | 282 | | |
299 | 283 | | |
300 | 284 | | |
| |||
0 commit comments