Fix: Resolve pylint naming convention warnings in provider modules (#273)

* Fix pylint naming convention issues in provider modules

- Rename module-level variables from _UPPERCASE to _lowercase
- Add pylint disable comments for CI compatibility
- Variables are not constants as they're modified at runtime

* Trigger CI re-run

Author: aksg87

langextract/providers/__init__.py

@@ -44,8 +44,8 @@
 ]
 
 # Track provider loading for lazy initialization
-_PLUGINS_LOADED = False
-_BUILTINS_LOADED = False
+_plugins_loaded = False  # pylint: disable=invalid-name
+_builtins_loaded = False  # pylint: disable=invalid-name
 
 
 def load_builtins_once() -> None:
@@ -56,9 +56,9 @@ def load_builtins_once() -> None:
   can be re-registered after registry.clear() even if their modules
   are already in sys.modules.
   """
-  global _BUILTINS_LOADED  # pylint: disable=global-statement
+  global _builtins_loaded  # pylint: disable=global-statement
 
-  if _BUILTINS_LOADED:
+  if _builtins_loaded:
     return
 
   # Register built-ins lazily so they can be re-registered after a registry.clear()
@@ -70,7 +70,7 @@ def load_builtins_once() -> None:
         priority=config['priority'],
     )
 
-  _BUILTINS_LOADED = True
+  _builtins_loaded = True
 
 
 def load_plugins_once() -> None:
@@ -79,8 +79,8 @@ def load_plugins_once() -> None:
   Discovers and loads langextract provider plugins using entry points.
   This function is idempotent - multiple calls have no effect.
   """
-  global _PLUGINS_LOADED  # pylint: disable=global-statement
-  if _PLUGINS_LOADED:
+  global _plugins_loaded  # pylint: disable=global-statement
+  if _plugins_loaded:
     return
 
   # Check if plugin loading is disabled
@@ -90,7 +90,7 @@ def load_plugins_once() -> None:
       'yes',
   ):
     logging.info('Plugin loading disabled via LANGEXTRACT_DISABLE_PLUGINS')
-    _PLUGINS_LOADED = True
+    _plugins_loaded = True
     return
 
   # Load built-in providers first
@@ -144,14 +144,14 @@ def load_plugins_once() -> None:
   except Exception as e:
     logging.warning('Error discovering provider plugins: %s', e)
 
-  _PLUGINS_LOADED = True
+  _plugins_loaded = True
 
 
 def _reset_for_testing() -> None:
   """Reset plugin loading state for testing. Should only be used in tests."""
-  global _PLUGINS_LOADED, _BUILTINS_LOADED  # pylint: disable=global-statement
-  _PLUGINS_LOADED = False
-  _BUILTINS_LOADED = False
+  global _plugins_loaded, _builtins_loaded  # pylint: disable=global-statement
+  _plugins_loaded = False
+  _builtins_loaded = False
 
 
 def __getattr__(name: str):
@@ -160,8 +160,8 @@ def __getattr__(name: str):
     return importlib.import_module('langextract.providers.router')
   elif name == 'schemas':
     return importlib.import_module('langextract.providers.schemas')
-  elif name == '_PLUGINS_LOADED':
-    return _PLUGINS_LOADED
-  elif name == '_BUILTINS_LOADED':
-    return _BUILTINS_LOADED
+  elif name == '_plugins_loaded':
+    return _plugins_loaded
+  elif name == '_builtins_loaded':
+    return _builtins_loaded
   raise AttributeError(f'module {__name__!r} has no attribute {name!r}')

langextract/providers/router.py

@@ -46,8 +46,8 @@ class _Entry:
   priority: int
 
 
-_ENTRIES: list[_Entry] = []
-_ENTRY_KEYS: set[tuple[str, tuple[str, ...], int]] = (
+_entries: list[_Entry] = []  # pylint: disable=invalid-name
+_entry_keys: set[tuple[str, tuple[str, ...], int]] = (  # pylint: disable=invalid-name
     set()
 )  # (provider_id, patterns, priority)
 
@@ -61,7 +61,7 @@ def _add_entry(
 ) -> None:
   """Add an entry to the registry with deduplication."""
   key = (provider_id, tuple(p.pattern for p in patterns), priority)
-  if key in _ENTRY_KEYS:
+  if key in _entry_keys:
     logging.debug(
         "Skipping duplicate registration for %s with patterns %s at"
         " priority %d",
@@ -70,8 +70,8 @@ def _add_entry(
         priority,
     )
     return
-  _ENTRY_KEYS.add(key)
-  _ENTRIES.append(_Entry(patterns=patterns, loader=loader, priority=priority))
+  _entry_keys.add(key)
+  _entries.append(_Entry(patterns=patterns, loader=loader, priority=priority))
   logging.debug(
       "Registered provider %s with patterns %s at priority %d",
       provider_id,
@@ -151,13 +151,13 @@ def resolve(model_id: str) -> type[base_model.BaseLanguageModel]:
   # Providers should be loaded by the caller (e.g., factory.create_model)
   # Router doesn't load providers to avoid circular dependencies
 
-  sorted_entries = sorted(_ENTRIES, key=lambda e: e.priority, reverse=True)
+  sorted_entries = sorted(_entries, key=lambda e: e.priority, reverse=True)
 
   for entry in sorted_entries:
     if any(pattern.search(model_id) for pattern in entry.patterns):
       return entry.loader()
 
-  available_patterns = [str(p.pattern) for e in _ENTRIES for p in e.patterns]
+  available_patterns = [str(p.pattern) for e in _entries for p in e.patterns]
   raise exceptions.InferenceConfigError(
       f"No provider registered for model_id={model_id!r}. "
       f"Available patterns: {available_patterns}\n"
@@ -185,12 +185,12 @@ class name (e.g., "GeminiLanguageModel").
   # Providers should be loaded by the caller (e.g., factory.create_model)
   # Router doesn't load providers to avoid circular dependencies
 
-  for entry in _ENTRIES:
+  for entry in _entries:
     for pattern in entry.patterns:
       if pattern.pattern == f"^{re.escape(provider_name)}$":
         return entry.loader()
 
-  for entry in _ENTRIES:
+  for entry in _entries:
     try:
       provider_class = entry.loader()
       class_name = provider_class.__name__
@@ -201,7 +201,7 @@ class name (e.g., "GeminiLanguageModel").
 
   try:
     pattern = re.compile(f"^{provider_name}$", re.IGNORECASE)
-    for entry in _ENTRIES:
+    for entry in _entries:
       for entry_pattern in entry.patterns:
         if pattern.pattern == entry_pattern.pattern:
           return entry.loader()
@@ -216,9 +216,9 @@ class name (e.g., "GeminiLanguageModel").
 
 def clear() -> None:
   """Clear all registered providers. Mainly for testing."""
-  global _ENTRIES  # pylint: disable=global-statement
-  _ENTRIES = []
-  _ENTRY_KEYS.clear()  # Also clear dedup keys to allow re-registration
+  global _entries  # pylint: disable=global-statement
+  _entries = []
+  _entry_keys.clear()  # Also clear dedup keys to allow re-registration
   resolve.cache_clear()
   resolve_provider.cache_clear()
 
@@ -231,7 +231,7 @@ def list_providers() -> list[tuple[tuple[str, ...], int]]:
   """
   return [
       (tuple(p.pattern for p in entry.patterns), entry.priority)
-      for entry in _ENTRIES
+      for entry in _entries
   ]
 
 
@@ -241,4 +241,4 @@ def list_entries() -> list[tuple[list[str], int]]:
   Returns:
     List of (patterns, priority) tuples.
   """
-  return [([p.pattern for p in e.patterns], e.priority) for e in _ENTRIES]
+  return [([p.pattern for p in e.patterns], e.priority) for e in _entries]

tests/factory_test.py

@@ -72,7 +72,7 @@ def setUp(self):
     router.clear()
     import langextract.providers as providers_module  # pylint: disable=import-outside-toplevel
 
-    providers_module._PLUGINS_LOADED = True
+    providers_module._plugins_loaded = True
     # Use direct registration for test providers to avoid module path issues
     router.register(r"^gemini", priority=100)(FakeGeminiProvider)
     router.register(r"^gpt", r"^o1", priority=100)(FakeOpenAIProvider)
@@ -82,7 +82,7 @@ def tearDown(self):
     router.clear()
     import langextract.providers as providers_module  # pylint: disable=import-outside-toplevel
 
-    providers_module._PLUGINS_LOADED = False
+    providers_module._plugins_loaded = False
 
   def test_create_model_basic(self):
     """Test basic model creation."""
@@ -341,8 +341,8 @@ def test_raises_error_when_neither_model_id_nor_provider_specified(self):
 
   def test_gemini_vertexai_parameters_accepted(self):
     """Test that Vertex AI parameters are properly passed to Gemini provider."""
-    original_entries = router._ENTRIES.copy()  # pylint: disable=protected-access
-    original_keys = router._ENTRY_KEYS.copy()  # pylint: disable=protected-access
+    original_entries = router._entries.copy()  # pylint: disable=protected-access
+    original_keys = router._entry_keys.copy()  # pylint: disable=protected-access
 
     try:
 
@@ -385,13 +385,13 @@ def infer(self, batch_prompts, **kwargs):
       self.assertEqual(model.location, "us-central1")
       self.assertIsNone(model.api_key)
     finally:
-      router._ENTRIES = original_entries  # pylint: disable=protected-access
-      router._ENTRY_KEYS = original_keys  # pylint: disable=protected-access
+      router._entries = original_entries  # pylint: disable=protected-access
+      router._entry_keys = original_keys  # pylint: disable=protected-access
 
   def test_gemini_vertexai_with_credentials(self):
     """Test that Vertex AI credentials can be passed through."""
-    original_entries = router._ENTRIES.copy()  # pylint: disable=protected-access
-    original_keys = router._ENTRY_KEYS.copy()  # pylint: disable=protected-access
+    original_entries = router._entries.copy()  # pylint: disable=protected-access
+    original_keys = router._entry_keys.copy()  # pylint: disable=protected-access
 
     try:
 
@@ -417,8 +417,8 @@ def infer(self, batch_prompts, **kwargs):
 
       self.assertEqual(model.credentials, mock_credentials)
     finally:
-      router._ENTRIES = original_entries  # pylint: disable=protected-access
-      router._ENTRY_KEYS = original_keys  # pylint: disable=protected-access
+      router._entries = original_entries  # pylint: disable=protected-access
+      router._entry_keys = original_keys  # pylint: disable=protected-access
 
 
 if __name__ == "__main__":

tests/provider_plugin_test.py

@@ -218,7 +218,7 @@ def test_plugin_priority_override_core_provider(self):
     """Plugin with higher priority should override core provider on conflicts."""
 
     lx.providers.registry.clear()
-    lx.providers._PLUGINS_LOADED = False
+    lx.providers._plugins_loaded = False
 
     def _ep_load():
       @lx.providers.registry.register(r"^gemini", priority=50)
@@ -250,7 +250,7 @@ def test_resolve_provider_for_plugin(self):
     """resolve_provider should find plugin by class name and name-insensitive."""
 
     lx.providers.registry.clear()
-    lx.providers._PLUGINS_LOADED = False
+    lx.providers._plugins_loaded = False
 
     def _ep_load():
       @lx.providers.registry.register(r"^plugin-resolve")
@@ -437,9 +437,9 @@ def infer(self, batch_prompts, **kwargs):
 
     # Clear and set up registry
     lx.providers.registry.clear()
-    lx.providers._PLUGINS_LOADED = False
+    lx.providers._plugins_loaded = False
     self.addCleanup(lx.providers.registry.clear)
-    self.addCleanup(setattr, lx.providers, "_PLUGINS_LOADED", False)
+    self.addCleanup(setattr, lx.providers, "_plugins_loaded", False)
 
     with mock.patch.object(
         metadata, "entry_points", return_value=_create_mock_entry_points([ep])
@@ -673,7 +673,7 @@ def infer(self, batch_prompts, **kwargs):
         )
 
         lx.providers.registry.clear()
-        lx.providers._PLUGINS_LOADED = False
+        lx.providers._plugins_loaded = False
         lx.providers.load_plugins_once()
 
         with self.assertRaisesRegex(