Skip to content

chore!: migrate to node 18 #909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Nov 21, 2025
Merged

chore!: migrate to node 18 #909

merged 10 commits into from
Nov 21, 2025
+682 −540

Conversation

@sofisl
Copy link
Contributor

@sofisl sofisl commented Nov 20, 2025 •
edited
Loading

Also, turned off docs github action tests so as to not block.

@sofisl sofisl requested review from a team as code owners November 20, 2025 21:59
@sofisl sofisl requested a review from daniel-sanche November 20, 2025 21:59
@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Nov 20, 2025
@generated-files-bot
Copy link

generated-files-bot bot commented Nov 20, 2025 •
edited
Loading

Warning: This pull request is touching the following templated files:

  • .kokoro/common.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node18/common.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node18/lint.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node18/samples-test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node18/system-test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node18/test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/presubmit/node18/common.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/presubmit/node18/samples-test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/presubmit/node18/system-test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/presubmit/node18/test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/release/docs-devsite.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/release/docs.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/release/docs.sh - .kokoro files are templated and should be updated in synthtool
  • .kokoro/release/publish.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/samples-test.sh - .kokoro files are templated and should be updated in synthtool
  • .kokoro/system-test.sh - .kokoro files are templated and should be updated in synthtool
  • .kokoro/test.bat - .kokoro files are templated and should be updated in synthtool
  • .kokoro/test.sh - .kokoro files are templated and should be updated in synthtool
  • .kokoro/trampoline_v2.sh - .kokoro files are templated and should be updated in synthtool
  • .github/workflows/ci.yaml - .github/workflows/ci.yaml (GitHub Actions) should be updated in synthtool

@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/nodejs-logging-winston API. label Nov 20, 2025
@sofisl sofisl closed this Nov 20, 2025
@sofisl sofisl reopened this Nov 20, 2025
@sofisl sofisl closed this Nov 20, 2025
@sofisl sofisl reopened this Nov 20, 2025
@sofisl sofisl closed this Nov 20, 2025
@sofisl sofisl reopened this Nov 20, 2025
@sofisl sofisl added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 20, 2025
@sofisl
Disable docs job in CI workflow
42d401a 
Comment out the docs job in CI workflow
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 20, 2025
@sofisl sofisl changed the title chore: migrate to node 18 chore!: migrate to node 18 Nov 20, 2025
@sofisl sofisl merged commit f44a9cf into main Nov 21, 2025
17 checks passed
@sofisl sofisl deleted the migrateToNode18 branch November 21, 2025 00:38
@release-please release-please bot mentioned this pull request Nov 21, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@miguelvelezsa miguelvelezsa miguelvelezsa approved these changes

@daniel-sanche daniel-sanche Awaiting requested review from daniel-sanche daniel-sanche is a code owner automatically assigned from googleapis/api-logging

Assignees

No one assigned

Labels

api: logging Issues related to the googleapis/nodejs-logging-winston API. size: l Pull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sofisl @miguelvelezsa @yoshi-kokoro