Skip to content

Commit 9dfcc71

Browse files
committed
[GR-71754] Improve sigtest help output and warn if check is run with less than "all".
PullRequest: mx/1992
2 parents 70bc59b + b012f18 commit 9dfcc71

File tree

3 files changed

+7
-3
lines changed

3 files changed

+7
-3
lines changed

common.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
"Jsonnet files should not include this file directly but use ci/common.jsonnet instead."
55
],
66

7-
"mx_version": "7.68.4",
7+
"mx_version": "7.68.5",
88

99
"COMMENT.jdks": "When adding or removing JDKs keep in sync with JDKs in ci/common.jsonnet",
1010
"jdks": {

src/mx/_impl/mx_sigtest.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,9 @@ def sigtest(args, suite=None, projects=None):
4545
"""
4646
parser = ArgumentParser(prog='mx sigtest')
4747
parser.add_argument('--generate', action='store_true', help='Generates signature files for projects with API')
48-
parser.add_argument('--check', action='store', help='Check <binary|all> against existing signature files', default='binary')
48+
parser.add_argument('--check', action='store', help='Check <binary|all> against existing signature files.\n' +
49+
'\'binary\' (default) checks for signature compatibility.\n'
50+
'\'all\' checks for all changes in signatures, including additions.', default='binary')
4951
parser.add_argument('-H', '--human', action='store_true', help='Produce human readable output')
5052

5153
args = parser.parse_args(args)
@@ -113,6 +115,8 @@ def _sigtest_check(checktype, args, suite=None, projects=None):
113115
return 1
114116
javaCompliance = max([p.javaCompliance for p in nonTestProjects])
115117

118+
if checktype != 'all':
119+
print('Running sigtest with checktype=' + checktype + '. For a full check, pass \'--check all\'.')
116120
class OutputCapture:
117121
def __init__(self):
118122
self.data = ""

src/mx/mx_version.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
# The version must be updated for every PR (checked in CI) and the comment should reflect the PR's issue
2-
version = "7.68.5" # GR-70638 - benchmarking time tracker
2+
version = "7.68.6" # GR-71754 - Improve sigtest help output and warn if check is run with less than "all".

0 commit comments

Comments
 (0)