feat: add option to ignore default resolvers in opentelemetry #2747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cecchi
changed the title
EmrysMyrddin
reviewed
Nov 4, 2025
| if ((!opts.skipIntrospection || !isIntrospectionType(type)) && isObjectType(type)) { | ||
| for (const field of Object.values(type.getFields())) { | ||
| if ((field as { [hasWrappedResolveSymbol]?: true })[hasWrappedResolveSymbol]) continue; | ||
| if (opts.skipDefaultResolvers && !field.resolve) continue; |
Collaborator
There was a problem hiding this comment.
Perhaps we can also check that if it exists, it is different from defaultFieldResolver from graphql package ?
EmrysMyrddin
reviewed
Nov 4, 2025
| }), | ||
| return () => {}; | ||
| }, | ||
| { skipDefaultResolvers: (options.defaultResolvers ?? true) === false }, |
Collaborator
There was a problem hiding this comment.
Since you already are making a strict equal against false, I don't think it is necessary to add a default value? Or it is just for clarity?
Suggested change
| { skipDefaultResolvers: (options.defaultResolvers ?? true) === false }, | |
| { skipDefaultResolvers: (options.defaultResolvers) === false }, |
EmrysMyrddin
requested changes
Nov 4, 2025
Collaborator
EmrysMyrddin
left a comment
EmrysMyrddin
left a comment
There was a problem hiding this comment.
Thank you very much! That's greatly appreciated 🙂
I've leaved a few comments, but otherwise it looks good to me!
Great work!
Author
|
Thanks - updated 👍 |
Collaborator
|
Oh sorry, I missed it at my first review, can you add a changeset ? Just run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚨 IMPORTANT: Please do not create a Pull Request without creating an issue first.
Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of
the pull request.
Description
useOnResolveto skip resolvers that use the default resolver.useOpentelemetryto skip tracing fields that use the default resolver. This is equivalent to theignoreTrivialResolveSpansoption in @opentelemetry/instrumentation-graphqlFixes #2132
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Added unit tests for both the enabled and disabled state of this flag.
Test Environment:
Checklist:
CONTRIBUTING doc and the
style guidelines of this project
Further comments
Unfortunately I did not realize @Akryum had proposed part of the same change in #2133 until I started to write this PR. This PR includes tests and the corresponding change to
useOpentelemetry, so hopefully it can be merged.