Incorrect variance in `hasItem` matcher

[CarstenLeue]

The hasItem matcher has the signature

Matcher<Iterable<? super T>> hasItem(Matcher<? super T> itemMatcher)

but it should be

Matcher<Iterable<? extends T>> hasItem(Matcher<? super T> itemMatcher)

because the matcher needs to read items from the Iterable and it needs the contract that the sequence contains at least items of type T, so it should be covariant in T

The current implementation states the opposite, it would be applicable it the matcher wanted to write to the iterable, but that is (a) not possible, since there is no write operation on an iterable and (b) not its usecase.

[foal]

I also faced this issue and had to use the patched version in my project - https://github.com/hortonolite/hamcrestBeanMatcherApt/blob/main/annotation/src/main/java/org/jresearch/hamcrest/beanmatcher/matcher/pecs/IsIterableContaining.java

[foal]

Anyway isn't it solved by #252?

[CarstenLeue]

True, but unfortunately only in the 3.1 version which has not been released, yet