Bidi: Browser.version and Browser.userAgent (#2834)

* Bidi Browser.version

* add user agent tests

Author: kblok

.github/workflows/dotnet.yml

@@ -11,6 +11,7 @@ on:
     paths:
     - '**.yml'
     - '**.cs'
+    - '**.json'
     - '**.csproj'
     - '**.runsettings'
 

lib/PuppeteerSharp.Nunit/TestExpectations/TestExpectations.local.json

@@ -92,7 +92,37 @@
   },
   {
     "comment": "This is part of organizing the webdriver bidi implementation, We will remove it one by one",
-    "testIdPattern": "[browser.spec] *",
+    "testIdPattern": "[browser.spec] *Browser.isConnected*",
+    "platforms": [
+      "darwin",
+      "linux",
+      "win32"
+    ],
+    "parameters": [
+      "webDriverBiDi"
+    ],
+    "expectations": [
+      "FAIL"
+    ]
+  },
+  {
+    "comment": "This is part of organizing the webdriver bidi implementation, We will remove it one by one",
+    "testIdPattern": "[browser.spec] *Browser.process*",
+    "platforms": [
+      "darwin",
+      "linux",
+      "win32"
+    ],
+    "parameters": [
+      "webDriverBiDi"
+    ],
+    "expectations": [
+      "FAIL"
+    ]
+  },
+  {
+    "comment": "This is part of organizing the webdriver bidi implementation, We will remove it one by one",
+    "testIdPattern": "[browser.spec] *Browser.target*",
     "platforms": [
       "darwin",
       "linux",

lib/PuppeteerSharp.Tests/BrowserTests/UserAgentTests.cs

@@ -6,10 +6,6 @@ namespace PuppeteerSharp.Tests.BrowserTests
 {
     public class UserAgentTests : PuppeteerBrowserBaseTest
     {
-        public UserAgentTests() : base()
-        {
-        }
-
         [Test, Retry(2), PuppeteerTest("browser.spec", "Browser.userAgent", "should include WebKit")]
         public async Task ShouldIncludeWebKit()
         {

lib/PuppeteerSharp/Bidi/BidiBrowser.cs

@@ -89,7 +89,7 @@ private BidiBrowser(Core.Browser browserCore, LaunchOptions options, ILoggerFact
     public override Task<string> GetVersionAsync() => Task.FromResult($"{BrowserName}/{BrowserVersion}");
 
     /// <inheritdoc />
-    public override Task<string> GetUserAgentAsync() => throw new NotImplementedException();
+    public override Task<string> GetUserAgentAsync() => Task.FromResult(BrowserCore.Session.Info.Capabilities.UserAgent);
 
     /// <inheritdoc />
     public override void Disconnect() => throw new NotImplementedException();