Skip to content

Commit dba0f89

Browse files
authored
Bidi: Browser.Process (#2836)
1 parent 8d9816d commit dba0f89

File tree

3 files changed

+5
-4
lines changed

3 files changed

+5
-4
lines changed

lib/PuppeteerSharp.Nunit/TestExpectations/TestExpectations.local.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@
107107
},
108108
{
109109
"comment": "This is part of organizing the webdriver bidi implementation, We will remove it one by one",
110-
"testIdPattern": "[browser.spec] *Browser.process*",
110+
"testIdPattern": "[browser.spec] *should not return child_process for remote browser*",
111111
"platforms": [
112112
"darwin",
113113
"linux",

lib/PuppeteerSharp/Bidi/BidiBrowser.cs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,8 @@ public override async Task<IBrowserContext> CreateBrowserContextAsync(BrowserCon
142142
internal static async Task<BidiBrowser> CreateAsync(
143143
BiDiDriver driver,
144144
LaunchOptions options,
145-
ILoggerFactory loggerFactory)
145+
ILoggerFactory loggerFactory,
146+
LauncherBase launcher)
146147
{
147148
var session = await Session.FromAsync(
148149
driver,
@@ -164,7 +165,7 @@ await session.SubscribeAsync(
164165
? SubscribeModules
165166
: [.. SubscribeModules, .. SubscribeCdpEvents]).ConfigureAwait(false);
166167

167-
var browser = new BidiBrowser(session.Browser, options, loggerFactory);
168+
var browser = new BidiBrowser(session.Browser, options, loggerFactory) { Launcher = launcher };
168169
browser.InitializeAsync();
169170
return browser;
170171
}

lib/PuppeteerSharp/Launcher.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ public async Task<IBrowser> LaunchAsync(LaunchOptions options)
9494
{
9595
var driver = new BiDiDriver(TimeSpan.FromMilliseconds(options.ProtocolTimeout));
9696
await driver.StartAsync(Process.EndPoint + "/session").ConfigureAwait(false);
97-
browser = await BidiBrowser.CreateAsync(driver, options, _loggerFactory).ConfigureAwait(false);
97+
browser = await BidiBrowser.CreateAsync(driver, options, _loggerFactory, Process).ConfigureAwait(false);
9898
}
9999
else
100100
{

0 commit comments

Comments
 (0)