Bidi: Page goback and goforward (#2838)

Author: kblok

lib/PuppeteerSharp.Nunit/TestExpectations/TestExpectations.local.json

@@ -285,21 +285,6 @@
       "FAIL"
     ]
   },
-  {
-    "comment": "This is part of organizing the webdriver bidi implementation, We will remove it one by one",
-    "testIdPattern": "[navigation.spec] navigation Page.goBack *",
-    "platforms": [
-      "darwin",
-      "linux",
-      "win32"
-    ],
-    "parameters": [
-      "webDriverBiDi"
-    ],
-    "expectations": [
-      "FAIL"
-    ]
-  },
   {
     "comment": "This is part of organizing the webdriver bidi implementation, We will remove it one by one",
     "testIdPattern": "[navigation.spec] *timeout*",

lib/PuppeteerSharp/Bidi/BidiPage.cs

@@ -23,6 +23,7 @@
 using System;
 using System.Collections.Concurrent;
 using System.Collections.Generic;
+using System.Linq;
 using System.Threading.Tasks;
 using PuppeteerSharp.Bidi.Core;
 using PuppeteerSharp.Helpers;
@@ -105,10 +106,10 @@ internal BidiPage(BidiBrowserContext browserContext, BrowsingContext browsingCon
     public override Task<FileChooser> WaitForFileChooserAsync(WaitForOptions options = null) => throw new NotImplementedException();
 
     /// <inheritdoc />
-    public override Task<IResponse> GoBackAsync(NavigationOptions options = null) => throw new NotImplementedException();
+    public override Task<IResponse> GoBackAsync(NavigationOptions options = null) => GoAsync(-1, options);
 
     /// <inheritdoc />
-    public override Task<IResponse> GoForwardAsync(NavigationOptions options = null) => throw new NotImplementedException();
+    public override Task<IResponse> GoForwardAsync(NavigationOptions options = null) => GoAsync(1, options);
 
     /// <inheritdoc />
     public override Task SetBurstModeOffAsync() => throw new NotImplementedException();
@@ -211,6 +212,28 @@ internal static BidiPage From(BidiBrowserContext browserContext, BrowsingContext
     /// <inheritdoc />
     protected override Task ExposeFunctionAsync(string name, Delegate puppeteerFunction) => throw new NotImplementedException();
 
+    private async Task<IResponse> GoAsync(int delta, NavigationOptions options)
+    {
+        var waitForNavigationTask = WaitForNavigationAsync(options);
+        var navigationTask = BidiMainFrame.BrowsingContext.TraverseHistoryAsync(delta);
+
+        try
+        {
+            await Task.WhenAll(waitForNavigationTask, navigationTask).ConfigureAwait(false);
+        }
+        catch (Exception ex)
+        {
+            if (ex.Message.Contains("no such history entry"))
+            {
+                return null;
+            }
+
+            throw new NavigationException(ex.Message, ex);
+        }
+
+        return waitForNavigationTask.Result;
+    }
+
     private void Initialize()
     {
     }

lib/PuppeteerSharp/Bidi/Core/BrowsingContext.cs

@@ -141,6 +141,9 @@ internal WindowRealm CreateWindowRealm(string sandbox = null)
         return realm;
     }
 
+    internal async Task TraverseHistoryAsync(int delta)
+        => await Session.Driver.BrowsingContext.TraverseHistoryAsync(new TraverseHistoryCommandParameters(Id, delta)).ConfigureAwait(false);
+
     protected virtual void OnBrowsingContextCreated(BidiBrowsingContextEventArgs e) => BrowsingContextCreated?.Invoke(this, e);
 
     private void Initialize()