-
Notifications
You must be signed in to change notification settings - Fork 38
Description
Community Note
- Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
- Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
- If you are interested in working on this issue or have submitted a pull request, please leave a comment
Description
The final design for provider_meta support in the standard and AWSCC provider contains a user_agent argument which is a list of strings. Once the AWSCC provider reaches version 2.0.0 and the list of objects user_agent schema is replaced with a list of strings, all upstream libraries will have simplified the representation of additional User-Agent values to string types.
This simplification means that the data structures in this library for representing User-Agent data can also be simplified. This includes.
- Data structures in
internal/config:
aws-sdk-go-base/internal/config/user_agent.go
Lines 10 to 16 in d2c7d8d
| type UserAgentProduct struct { | |
| Name string | |
| Version string | |
| Comment string | |
| } | |
| type UserAgentProducts []UserAgentProduct |
- Context helpers in
useragent:
aws-sdk-go-base/useragent/context.go
Lines 18 to 20 in d2c7d8d
| func Context(ctx context.Context, products config.UserAgentProducts) context.Context { | |
| return context.WithValue(ctx, contextScopedUserAgent, products) | |
| } |
These types and function arguments can be replaced with a slice of strings, aligning with the upstream representation.
References
https://hashicorp.github.io/terraform-provider-aws/design-decisions/provider_meta/
Relates hashicorp/terraform-provider-aws#45464
Relates hashicorp/terraform-provider-awscc#474