Add version skip for < 1.12.0 for identity

Author: jrhouston

manifest/test/acceptance/configmap_test.go

@@ -11,6 +11,7 @@ import (
 	"testing"
 
 	"github.com/hashicorp/go-hclog"
+	version "github.com/hashicorp/go-version"
 	"github.com/hashicorp/terraform-provider-kubernetes/manifest/provider"
 	"github.com/hashicorp/terraform-provider-kubernetes/manifest/test/helper/kubernetes"
 	tfstatehelper "github.com/hashicorp/terraform-provider-kubernetes/manifest/test/helper/state"
@@ -88,8 +89,17 @@ func TestKubernetesManifest_ConfigMap(t *testing.T) {
 
 	tfstate.AssertAttributeDoesNotExist(t, "kubernetes_manifest.test.spec")
 
-	tfstate.AssertIdentityValueEqual(t, "kubernetes_manifest.test", "api_version", "v1")
-	tfstate.AssertIdentityValueEqual(t, "kubernetes_manifest.test", "kind", "ConfigMap")
-	tfstate.AssertIdentityValueEqual(t, "kubernetes_manifest.test", "name", name)
-	tfstate.AssertIdentityValueEqual(t, "kubernetes_manifest.test", "namespace", namespace)
+	tfversion, err := tf.Version(ctx)
+	if err != nil {
+		t.Fatalf("Failed to retrieve terraform version: %v", err)
+	}
+	constraint, _ := version.NewConstraint(">= 1.12.0")
+	if constraint.Check(tfversion) {
+		tfstate.AssertIdentityValueEqual(t, "kubernetes_manifest.test", "api_version", "v1")
+		tfstate.AssertIdentityValueEqual(t, "kubernetes_manifest.test", "kind", "ConfigMap")
+		tfstate.AssertIdentityValueEqual(t, "kubernetes_manifest.test", "name", name)
+		tfstate.AssertIdentityValueEqual(t, "kubernetes_manifest.test", "namespace", namespace)
+	} else {
+		t.Logf("Skipping identity assertions because terraform version %s is less than 1.12.0", tfversion)
+	}
 }

manifest/test/plugintest/working_dir.go

@@ -12,6 +12,8 @@ import (
 	"os"
 	"path/filepath"
 
+	"github.com/hashicorp/go-version"
+
 	"github.com/hashicorp/terraform-exec/tfexec"
 	tfjson "github.com/hashicorp/terraform-json"
 	"github.com/hashicorp/terraform-provider-kubernetes/manifest/test/logging"
@@ -84,7 +86,7 @@ func (wd *WorkingDir) SetConfig(ctx context.Context, cfg string) error {
 	if err := os.Remove(rmFilename); err != nil && !os.IsNotExist(err) {
 		return fmt.Errorf("unable to remove %q: %w", rmFilename, err)
 	}
-	err := os.WriteFile(outFilename, bCfg, 0700)
+	err := os.WriteFile(outFilename, bCfg, 0o700)
 	if err != nil {
 		return err
 	}
@@ -326,3 +328,16 @@ func (wd *WorkingDir) Schemas(ctx context.Context) (*tfjson.ProviderSchemas, err
 
 	return providerSchemas, err
 }
+
+// Version returns the current version of Terraform
+//
+// If the version cannot be read, Version returns an error.
+func (wd *WorkingDir) Version(ctx context.Context) (*version.Version, error) {
+	logging.HelperResourceTrace(ctx, "Calling Terraform CLI providers version command")
+
+	version, _, err := wd.tf.Version(context.Background(), false)
+
+	logging.HelperResourceTrace(ctx, "Called Terraform CLI providers version command")
+
+	return version, err
+}