Skip to content

Commit 69e7e75

Browse files
Updating field to computed
1 parent 77eae49 commit 69e7e75

File tree

2 files changed

+25
-49
lines changed

2 files changed

+25
-49
lines changed

kubernetes/resource_kubernetes_service_v1.go

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -317,10 +317,8 @@ func resourceKubernetesServiceSchemaV1() map[string]*schema.Schema {
317317
Computed: true,
318318
},
319319
"ip_mode": {
320-
Type: schema.TypeString,
321-
Optional: true,
322-
Default: "VIP",
323-
ValidateFunc: validation.StringInSlice([]string{"VIP", "Proxy"}, false),
320+
Type: schema.TypeString,
321+
Computed: true,
324322
},
325323
"hostname": {
326324
Type: schema.TypeString,

kubernetes/resource_kubernetes_service_v1_test.go

Lines changed: 23 additions & 45 deletions
Original file line numberDiff line numberDiff line change
@@ -350,7 +350,7 @@ func TestAccKubernetesServiceV1_loadBalancer_ipMode(t *testing.T) {
350350
Steps: []resource.TestStep{
351351
{
352352
Config: testAccKubernetesConfig_ignoreAnnotations() +
353-
testAccKubernetesServiceV1Config_loadBalancer_defaultIPMode(name),
353+
testAccKubernetesServiceV1Config_loadBalancer_ip(name),
354354
Check: resource.ComposeAggregateTestCheckFunc(
355355
testAccCheckKubernetesServiceV1Exists(resourceName, &conf),
356356
resource.TestCheckResourceAttr(resourceName, "metadata.0.name", name),
@@ -359,17 +359,6 @@ func TestAccKubernetesServiceV1_loadBalancer_ipMode(t *testing.T) {
359359
resource.TestCheckResourceAttr(resourceName, "status.0.load_balancer.0.ingress.0.ip_mode", "VIP"),
360360
),
361361
},
362-
{
363-
Config: testAccKubernetesConfig_ignoreAnnotations() +
364-
testAccKubernetesServiceV1Config_loadBalancer_ipMode(name, "Proxy"),
365-
Check: resource.ComposeAggregateTestCheckFunc(
366-
testAccCheckKubernetesServiceV1Exists(resourceName, &conf),
367-
resource.TestCheckResourceAttr(resourceName, "metadata.0.name", name),
368-
resource.TestCheckResourceAttr(resourceName, "spec.#", "1"),
369-
resource.TestCheckResourceAttr(resourceName, "spec.0.type", "LoadBalancer"),
370-
resource.TestCheckResourceAttr(resourceName, "status.0.load_balancer.0.ingress.0.ip_mode", "Proxy"),
371-
),
372-
},
373362
},
374363
})
375364
}
@@ -1050,6 +1039,28 @@ func testAccKubernetesServiceV1Config_loadBalancer(name string) string {
10501039
`, name)
10511040
}
10521041

1042+
func testAccKubernetesServiceV1Config_loadBalancer_ip(name string) string {
1043+
return fmt.Sprintf(`
1044+
resource "kubernetes_service_v1" "test" {
1045+
metadata {
1046+
name = "%s"
1047+
}
1048+
1049+
spec {
1050+
type = "LoadBalancer"
1051+
selector = {
1052+
app = "test-app"
1053+
}
1054+
1055+
port {
1056+
port = 80
1057+
target_port = 80
1058+
}
1059+
}
1060+
}
1061+
`, name)
1062+
}
1063+
10531064
func testAccKubernetesServiceV1Config_loadBalancer_modified(name string) string {
10541065
return fmt.Sprintf(`resource "kubernetes_service_v1" "test" {
10551066
metadata {
@@ -1141,39 +1152,6 @@ func testAccKubernetesServiceV1Config_loadBalancer_annotations_aws_modified(name
11411152
}
11421153
`, name)
11431154
}
1144-
func testAccKubernetesServiceV1Config_loadBalancer_defaultIPMode(name string) string {
1145-
return fmt.Sprintf(`
1146-
resource "kubernetes_service_v1" "test" {
1147-
metadata {
1148-
name = "%s"
1149-
}
1150-
spec {
1151-
type = "LoadBalancer"
1152-
port {
1153-
port = 80
1154-
target_port = 8080
1155-
}
1156-
}
1157-
}
1158-
`, name)
1159-
}
1160-
func testAccKubernetesServiceV1Config_loadBalancer_ipMode(name, ipMode string) string {
1161-
return fmt.Sprintf(`
1162-
resource "kubernetes_service_v1" "test" {
1163-
metadata {
1164-
name = "%s"
1165-
}
1166-
spec {
1167-
type = "LoadBalancer"
1168-
port {
1169-
port = 80
1170-
target_port = 8080
1171-
}
1172-
ip_mode = "%s"
1173-
}
1174-
}
1175-
`, name, ipMode)
1176-
}
11771155

11781156
func testAccKubernetesServiceV1Config_headless(name string) string {
11791157
return fmt.Sprintf(`resource "kubernetes_service_v1" "test" {

0 commit comments

Comments
 (0)