Skip to content

Commit 8803b5b

Browse files
committed
Remove redundant IDRefresh option
1 parent 322c74f commit 8803b5b

File tree

54 files changed

+98
-450
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

54 files changed

+98
-450
lines changed

kubernetes/data_source_kubernetes_endpoints_v1_test.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ func TestAccKubernetesDataSourceEndpointsV1_basic(t *testing.T) {
2020

2121
resource.ParallelTest(t, resource.TestCase{
2222
PreCheck: func() { testAccPreCheck(t) },
23-
IDRefreshName: resourceName,
2423
ProviderFactories: testAccProviderFactories,
2524
CheckDestroy: testAccCheckKubernetesEndpointV1Destroy,
2625
Steps: []resource.TestStep{

kubernetes/resource_kubernetes_annotations_test.go

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,7 @@ func TestAccKubernetesAnnotations_basic(t *testing.T) {
2727
testAccPreCheck(t)
2828
createConfigMap(name, namespace)
2929
},
30-
IDRefreshName: resourceName,
31-
IDRefreshIgnore: []string{"metadata.0.resource_version"},
30+
3231
ProviderFactories: testAccProviderFactories,
3332
CheckDestroy: func(s *terraform.State) error {
3433
return destroyConfigMap(name, namespace)
@@ -92,8 +91,7 @@ func TestAccKubernetesAnnotations_template_cronjob(t *testing.T) {
9291
testAccPreCheck(t)
9392
createCronJob(name, namespace)
9493
},
95-
IDRefreshName: resourceName,
96-
IDRefreshIgnore: []string{"metadata.0.resource_version"},
94+
9795
ProviderFactories: testAccProviderFactories,
9896
CheckDestroy: func(s *terraform.State) error {
9997
return destroyCronJob(name, namespace)
@@ -163,8 +161,7 @@ func TestAccKubernetesAnnotations_template_deployment(t *testing.T) {
163161
testAccPreCheck(t)
164162
createDeployment(name, namespace)
165163
},
166-
IDRefreshName: resourceName,
167-
IDRefreshIgnore: []string{"metadata.0.resource_version"},
164+
168165
ProviderFactories: testAccProviderFactories,
169166
CheckDestroy: func(s *terraform.State) error {
170167
return destroyDeployment(name, namespace)
@@ -234,8 +231,7 @@ func TestAccKubernetesAnnotations_template_only(t *testing.T) {
234231
testAccPreCheck(t)
235232
createDeployment(name, namespace)
236233
},
237-
IDRefreshName: resourceName,
238-
IDRefreshIgnore: []string{"metadata.0.resource_version"},
234+
239235
ProviderFactories: testAccProviderFactories,
240236
CheckDestroy: func(s *terraform.State) error {
241237
return destroyDeployment(name, namespace)
@@ -266,8 +262,7 @@ func TestAccKubernetesAnnotations_resource_only(t *testing.T) {
266262
testAccPreCheck(t)
267263
createDeployment(name, namespace)
268264
},
269-
IDRefreshName: resourceName,
270-
IDRefreshIgnore: []string{"metadata.0.resource_version"},
265+
271266
ProviderFactories: testAccProviderFactories,
272267
CheckDestroy: func(s *terraform.State) error {
273268
return destroyDeployment(name, namespace)

kubernetes/resource_kubernetes_api_service_v1_test.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,6 @@ func TestAccKubernetesAPIServiceV1_basic(t *testing.T) {
2222

2323
resource.ParallelTest(t, resource.TestCase{
2424
PreCheck: func() { testAccPreCheck(t) },
25-
IDRefreshName: resourceName,
26-
IDRefreshIgnore: []string{"metadata.0.resource_version"},
2725
ProviderFactories: testAccProviderFactories,
2826
CheckDestroy: testAccCheckKubernetesAPIServiceV1Destroy,
2927
Steps: []resource.TestStep{

kubernetes/resource_kubernetes_certificate_signing_request_test.go

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -19,15 +19,13 @@ func TestAccKubernetesCertificateSigningRequest_basic(t *testing.T) {
1919
name := fmt.Sprintf("tf-acc-test-%s", acctest.RandStringFromCharSet(10, acctest.CharSetAlphaNum))
2020
usages := []string{"client auth"}
2121
signerName := "kubernetes.io/legacy-unknown"
22-
resourceName := "kubernetes_certificate_signing_request.test"
2322

2423
resource.ParallelTest(t, resource.TestCase{
2524
PreCheck: func() {
2625
testAccPreCheck(t)
2726
skipIfClusterVersionGreaterThanOrEqual(t, "1.22.0")
2827
},
29-
IDRefreshName: resourceName,
30-
IDRefreshIgnore: []string{"metadata.0.resource_version"},
28+
3129
ProviderFactories: testAccProviderFactories,
3230
CheckDestroy: testAccCheckKubernetesCertificateSigningRequestDestroy,
3331
Steps: []resource.TestStep{
@@ -41,15 +39,13 @@ func TestAccKubernetesCertificateSigningRequest_basic(t *testing.T) {
4139

4240
func TestAccKubernetesCertificateSigningRequest_generateName(t *testing.T) {
4341
generateName := fmt.Sprintf("tf-acc-test-%s", acctest.RandStringFromCharSet(10, acctest.CharSetAlphaNum))
44-
resourceName := "kubernetes_certificate_signing_request.test"
4542

4643
resource.ParallelTest(t, resource.TestCase{
4744
PreCheck: func() {
4845
testAccPreCheck(t)
4946
skipIfClusterVersionGreaterThanOrEqual(t, "1.22.0")
5047
},
51-
IDRefreshName: resourceName,
52-
IDRefreshIgnore: []string{"metadata.0.resource_version"},
48+
5349
ProviderFactories: testAccProviderFactories,
5450
CheckDestroy: testAccCheckKubernetesCertificateSigningRequestDestroy,
5551
Steps: []resource.TestStep{

kubernetes/resource_kubernetes_certificate_signing_request_v1_test.go

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,7 @@ func TestAccKubernetesCertificateSigningRequestV1_basic(t *testing.T) {
2727
skipIfClusterVersionLessThan(t, "1.22.0")
2828
skipIfNotRunningInKind(t)
2929
},
30-
IDRefreshName: resourceName,
31-
IDRefreshIgnore: []string{"metadata.0.resource_version"},
30+
3231
ProviderFactories: testAccProviderFactories,
3332
CheckDestroy: testAccCheckKubernetesCertificateSigningRequestV1Destroy,
3433
Steps: []resource.TestStep{
@@ -56,8 +55,7 @@ func TestAccKubernetesCertificateSigningRequestV1_generateName(t *testing.T) {
5655
skipIfClusterVersionLessThan(t, "1.22.0")
5756
skipIfNotRunningInKind(t)
5857
},
59-
IDRefreshName: resourceName,
60-
IDRefreshIgnore: []string{"metadata.0.resource_version"},
58+
6159
ProviderFactories: testAccProviderFactories,
6260
CheckDestroy: testAccCheckKubernetesCertificateSigningRequestV1Destroy,
6361
Steps: []resource.TestStep{
@@ -87,8 +85,7 @@ func TestAccKubernetesCertificateSigningRequestV1_awsBasic(t *testing.T) {
8785
skipIfClusterVersionLessThan(t, "1.22.0")
8886
skipIfNotRunningInEks(t)
8987
},
90-
IDRefreshName: resourceName,
91-
IDRefreshIgnore: []string{"metadata.0.resource_version"},
88+
9289
ProviderFactories: testAccProviderFactories,
9390
CheckDestroy: testAccCheckKubernetesCertificateSigningRequestV1Destroy,
9491
Steps: []resource.TestStep{

kubernetes/resource_kubernetes_cluster_role_binding_v1_test.go

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,6 @@ func TestAccKubernetesClusterRoleBindingV1_basic(t *testing.T) {
2323

2424
resource.ParallelTest(t, resource.TestCase{
2525
PreCheck: func() { testAccPreCheck(t) },
26-
IDRefreshName: resourceName,
27-
IDRefreshIgnore: []string{"metadata.0.resource_version"},
2826
ProviderFactories: testAccProviderFactories,
2927
CheckDestroy: testAccCheckKubernetesClusterRoleBindingV1Destroy,
3028
Steps: []resource.TestStep{
@@ -132,8 +130,6 @@ func TestAccKubernetesClusterRoleBindingV1_generatedName(t *testing.T) {
132130

133131
resource.ParallelTest(t, resource.TestCase{
134132
PreCheck: func() { testAccPreCheck(t) },
135-
IDRefreshName: resourceName,
136-
IDRefreshIgnore: []string{"metadata.0.resource_version"},
137133
ProviderFactories: testAccProviderFactories,
138134
CheckDestroy: testAccCheckKubernetesClusterRoleBindingV1Destroy,
139135
Steps: []resource.TestStep{
@@ -166,8 +162,6 @@ func TestAccKubernetesClusterRoleBindingV1_serviceaccount_subject(t *testing.T)
166162

167163
resource.ParallelTest(t, resource.TestCase{
168164
PreCheck: func() { testAccPreCheck(t) },
169-
IDRefreshName: resourceName,
170-
IDRefreshIgnore: []string{"metadata.0.resource_version"},
171165
ProviderFactories: testAccProviderFactories,
172166
CheckDestroy: testAccCheckKubernetesClusterRoleBindingV1Destroy,
173167
Steps: []resource.TestStep{
@@ -200,8 +194,6 @@ func TestAccKubernetesClusterRoleBindingV1_group_subject(t *testing.T) {
200194

201195
resource.ParallelTest(t, resource.TestCase{
202196
PreCheck: func() { testAccPreCheck(t) },
203-
IDRefreshName: resourceName,
204-
IDRefreshIgnore: []string{"metadata.0.resource_version"},
205197
ProviderFactories: testAccProviderFactories,
206198
CheckDestroy: testAccCheckKubernetesClusterRoleBindingV1Destroy,
207199
Steps: []resource.TestStep{
@@ -240,8 +232,6 @@ func TestAccKubernetesClusterRoleBindingV1_UpdatePatchOperationsOrderWithRemoval
240232

241233
resource.ParallelTest(t, resource.TestCase{
242234
PreCheck: func() { testAccPreCheck(t) },
243-
IDRefreshName: resourceName,
244-
IDRefreshIgnore: []string{"metadata.0.resource_version"},
245235
ProviderFactories: testAccProviderFactories,
246236
CheckDestroy: testAccCheckKubernetesClusterRoleBindingV1Destroy,
247237
Steps: []resource.TestStep{

kubernetes/resource_kubernetes_cluster_role_v1_test.go

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,6 @@ func TestAccKubernetesClusterRoleV1_basic(t *testing.T) {
2323

2424
resource.ParallelTest(t, resource.TestCase{
2525
PreCheck: func() { testAccPreCheck(t) },
26-
IDRefreshName: resourceName,
27-
IDRefreshIgnore: []string{"metadata.0.resource_version"},
2826
ProviderFactories: testAccProviderFactories,
2927
CheckDestroy: testAccCheckKubernetesClusterRoleV1Destroy,
3028
Steps: []resource.TestStep{
@@ -77,8 +75,6 @@ func TestAccKubernetesClusterRoleV1_generatedName(t *testing.T) {
7775

7876
resource.ParallelTest(t, resource.TestCase{
7977
PreCheck: func() { testAccPreCheck(t) },
80-
IDRefreshName: resourceName,
81-
IDRefreshIgnore: []string{"metadata.0.resource_version"},
8278
ProviderFactories: testAccProviderFactories,
8379
CheckDestroy: testAccCheckKubernetesClusterRoleV1Destroy,
8480
Steps: []resource.TestStep{
@@ -105,8 +101,6 @@ func TestAccKubernetesClusterRoleV1_UpdatePatchOperationsOrderWithRemovals(t *te
105101

106102
resource.ParallelTest(t, resource.TestCase{
107103
PreCheck: func() { testAccPreCheck(t) },
108-
IDRefreshName: resourceName,
109-
IDRefreshIgnore: []string{"metadata.0.resource_version"},
110104
ProviderFactories: testAccProviderFactories,
111105
CheckDestroy: testAccCheckKubernetesClusterRoleV1Destroy,
112106
Steps: []resource.TestStep{
@@ -181,8 +175,6 @@ func TestAccKubernetesClusterRoleV1_aggregationRuleBasic(t *testing.T) {
181175

182176
resource.ParallelTest(t, resource.TestCase{
183177
PreCheck: func() { testAccPreCheck(t) },
184-
IDRefreshName: resourceName,
185-
IDRefreshIgnore: []string{"metadata.0.resource_version"},
186178
ProviderFactories: testAccProviderFactories,
187179
CheckDestroy: testAccCheckKubernetesClusterRoleV1Destroy,
188180
Steps: []resource.TestStep{
@@ -227,8 +219,6 @@ func TestAccKubernetesClusterRoleV1_aggregationRuleMultiple(t *testing.T) {
227219

228220
resource.ParallelTest(t, resource.TestCase{
229221
PreCheck: func() { testAccPreCheck(t) },
230-
IDRefreshName: resourceName,
231-
IDRefreshIgnore: []string{"metadata.0.resource_version"},
232222
ProviderFactories: testAccProviderFactories,
233223
CheckDestroy: testAccCheckKubernetesClusterRoleV1Destroy,
234224
Steps: []resource.TestStep{
@@ -269,8 +259,6 @@ func TestAccKubernetesClusterRoleV1_aggregationRuleRuleAggregation(t *testing.T)
269259

270260
resource.ParallelTest(t, resource.TestCase{
271261
PreCheck: func() { testAccPreCheck(t) },
272-
IDRefreshName: resourceName,
273-
IDRefreshIgnore: []string{"metadata.0.resource_version"},
274262
ProviderFactories: testAccProviderFactories,
275263
CheckDestroy: testAccCheckKubernetesClusterRoleV1Destroy,
276264
Steps: []resource.TestStep{

kubernetes/resource_kubernetes_config_map_v1_data_test.go

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,7 @@ func TestAccKubernetesConfigMapV1Data_basic(t *testing.T) {
2323
testAccPreCheck(t)
2424
createConfigMap(name, namespace)
2525
},
26-
IDRefreshName: resourceName,
27-
IDRefreshIgnore: []string{"metadata.0.resource_version"},
26+
2827
ProviderFactories: testAccProviderFactories,
2928
CheckDestroy: func(s *terraform.State) error {
3029
return destroyConfigMap(name, namespace)
@@ -72,12 +71,9 @@ func TestAccKubernetesConfigMapV1Data_basic(t *testing.T) {
7271

7372
func TestAccKubernetesConfigMapV1Data_validation(t *testing.T) {
7473
name := fmt.Sprintf("tf-acc-test-%s", acctest.RandStringFromCharSet(10, acctest.CharSetAlphaNum))
75-
resourceName := "kubernetes_config_map_v1_data.test"
7674

7775
resource.ParallelTest(t, resource.TestCase{
7876
PreCheck: func() { testAccPreCheck(t) },
79-
IDRefreshName: resourceName,
80-
IDRefreshIgnore: []string{"metadata.0.resource_version"},
8177
ProviderFactories: testAccProviderFactories,
8278
Steps: []resource.TestStep{
8379
{

kubernetes/resource_kubernetes_cron_job_v1_test.go

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,7 @@ func TestAccKubernetesCronJobV1_basic(t *testing.T) {
2727
testAccPreCheck(t)
2828
skipIfClusterVersionLessThan(t, "1.25.0")
2929
},
30-
IDRefreshName: resourceName,
31-
IDRefreshIgnore: []string{"metadata.0.resource_version"},
30+
3231
ProviderFactories: testAccProviderFactories,
3332
CheckDestroy: testAccCheckKubernetesCronJobV1Destroy,
3433
Steps: []resource.TestStep{
@@ -93,8 +92,7 @@ func TestAccKubernetesCronJobV1_extra(t *testing.T) {
9392
testAccPreCheck(t)
9493
skipIfClusterVersionLessThan(t, "1.25.0")
9594
},
96-
IDRefreshName: resourceName,
97-
IDRefreshIgnore: []string{"metadata.0.resource_version"},
95+
9896
ProviderFactories: testAccProviderFactories,
9997
CheckDestroy: testAccCheckKubernetesCronJobV1Destroy,
10098
Steps: []resource.TestStep{
@@ -137,8 +135,6 @@ func TestAccKubernetesCronJobV1_minimalWithTemplateNamespace(t *testing.T) {
137135

138136
resource.ParallelTest(t, resource.TestCase{
139137
PreCheck: func() { testAccPreCheck(t) },
140-
IDRefreshName: resourceName,
141-
IDRefreshIgnore: []string{"metadata.0.resource_version"},
142138
ProviderFactories: testAccProviderFactories,
143139
CheckDestroy: testAccCheckKubernetesCronJobV1Destroy,
144140
Steps: []resource.TestStep{
@@ -181,8 +177,7 @@ func TestAccKubernetesCronJobV1_minimalWithPodFailurePolicy(t *testing.T) {
181177
testAccPreCheck(t)
182178
skipIfClusterVersionLessThan(t, "1.25.0")
183179
},
184-
IDRefreshName: resourceName,
185-
IDRefreshIgnore: []string{"metadata.0.resource_version"},
180+
186181
ProviderFactories: testAccProviderFactories,
187182
CheckDestroy: testAccCheckKubernetesCronJobV1Destroy,
188183
Steps: []resource.TestStep{
@@ -234,8 +229,7 @@ func TestAccKubernetesCronJobV1_minimalWithBackoffLimitPerIndex(t *testing.T) {
234229
testAccPreCheck(t)
235230
skipIfClusterVersionLessThan(t, "1.29.0")
236231
},
237-
IDRefreshName: resourceName,
238-
IDRefreshIgnore: []string{"metadata.0.resource_version"},
232+
239233
ProviderFactories: testAccProviderFactories,
240234
CheckDestroy: testAccCheckKubernetesCronJobV1Destroy,
241235
Steps: []resource.TestStep{

kubernetes/resource_kubernetes_cron_job_v1beta1_test.go

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,7 @@ func TestAccKubernetesCronJobV1Beta1_basic(t *testing.T) {
2626
testAccPreCheck(t)
2727
skipIfClusterVersionGreaterThanOrEqual(t, "1.25.0")
2828
},
29-
IDRefreshName: resourceName,
30-
IDRefreshIgnore: []string{"metadata.0.resource_version"},
29+
3130
ProviderFactories: testAccProviderFactories,
3231
CheckDestroy: testAccCheckKubernetesCronJobV1Beta1Destroy,
3332
Steps: []resource.TestStep{
@@ -91,8 +90,7 @@ func TestAccKubernetesCronJobV1Beta1_extra(t *testing.T) {
9190
testAccPreCheck(t)
9291
skipIfClusterVersionGreaterThanOrEqual(t, "1.25.0")
9392
},
94-
IDRefreshName: resourceName,
95-
IDRefreshIgnore: []string{"metadata.0.resource_version"},
93+
9694
ProviderFactories: testAccProviderFactories,
9795
CheckDestroy: testAccCheckKubernetesCronJobV1Beta1Destroy,
9896
Steps: []resource.TestStep{
@@ -138,8 +136,7 @@ func TestAccKubernetesCronJobV1Beta1_minimalWithTemplateNamespace(t *testing.T)
138136
testAccPreCheck(t)
139137
skipIfClusterVersionGreaterThanOrEqual(t, "1.25.0")
140138
},
141-
IDRefreshName: resourceName,
142-
IDRefreshIgnore: []string{"metadata.0.resource_version"},
139+
143140
ProviderFactories: testAccProviderFactories,
144141
CheckDestroy: testAccCheckKubernetesCronJobV1Beta1Destroy,
145142
Steps: []resource.TestStep{

0 commit comments

Comments
 (0)