-
Notifications
You must be signed in to change notification settings - Fork 114
Add terraform-plugin-testing documentation for query mode and query checks
#1451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: f/plugin-testing-1-14-0
Are you sure you want to change the base?
Conversation
…ation to refer to new testing mode
Vercel Previews Deployed
|
Broken Link CheckerNo broken links found! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added a couple of suggestions, but none of it is blocking. Otherwise, LGTM!
| "path": "acceptance-tests/query-checks" | ||
| }, | ||
| { | ||
| "title": "Query Result Query Checks", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think having "Query" here twice is a little wordy and we can just shorten it to "Query Result Checks"
| "title": "Query Result Query Checks", | |
| "title": "Query Result Checks", |
| @@ -0,0 +1,95 @@ | |||
| --- | |||
| page_title: 'Plugin Development - Acceptance Testing: Query Checks' | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| page_title: 'Plugin Development - Acceptance Testing: Query Checks' | |
| page_title: 'Plugin Development - Acceptance Testing: Custom Query Checks' |
| --- | ||
|
|
||
| # Query Checks | ||
| During the **Query** [mode](/terraform/plugin/testing/acceptance-tests/teststep#test-modes) of a `TestStep`, the configuration supplied is used as the contents of a `.tfquery.hcl` query file and the testing framework will run `terraform query`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| During the **Query** [mode](/terraform/plugin/testing/acceptance-tests/teststep#test-modes) of a `TestStep`, the configuration supplied is used as the contents of a `.tfquery.hcl` query file and the testing framework will run `terraform query`. | |
| During the **Query** [mode](/terraform/plugin/testing/acceptance-tests/teststep#test-modes) of a `TestStep`, the configuration supplied is used as the content of a `.tfquery.hcl` query file and the testing framework will run `terraform query`. |
| provides built-in Query Checks for common use-cases. | ||
| --- | ||
|
|
||
| # Query Result Query Checks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| # Query Result Query Checks | |
| # Query Result Checks |
| @@ -0,0 +1,338 @@ | |||
| --- | |||
| page_title: 'Plugin Development - Acceptance Testing: Query Checks' | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| page_title: 'Plugin Development - Acceptance Testing: Query Checks' | |
| page_title: 'Plugin Development - Acceptance Testing: Query Result Checks' |
What
This PR adds documentation for the newly introduced query testing mode as well as the accompanying query checks
What was added:
query-checkscontainingTestStepssubsection forquery modeWhat changed:
TestStepspage was updated to include mentions and references to the new query modeWhy
Terraform introduced a new language construct which users will likely want to know how to test.
Screenshots
Merge Checklist
If items do not apply to your changes, add (N/A) and mark them as complete.
Pull Request
Content
content/terraform-docs-common/redirects.jsoncfor moved, renamed, or deleted pages across all affected versions. Refer to Redirects for examples and guidance.Reviews