fix: equality for some domain classes (#510)

Some domains were missing the `__api_properties__` and `__slots__`
properties required for the equality check.

Author: jooola

hcloud/certificates/domain.py

@@ -87,6 +87,13 @@ class ManagedCertificateStatus(BaseDomain):
           If issuance or renewal reports failure, this property contains information about what happened
     """
 
+    __api_properties__ = (
+        "issuance",
+        "renewal",
+        "error",
+    )
+    __slots__ = __api_properties__
+
     def __init__(
         self,
         issuance: str | None = None,
@@ -107,6 +114,12 @@ class ManagedCertificateError(BaseDomain):
         Message detailing the error
     """
 
+    __api_properties__ = (
+        "code",
+        "message",
+    )
+    __slots__ = __api_properties__
+
     def __init__(self, code: str | None = None, message: str | None = None):
         self.code = code
         self.message = message

hcloud/load_balancers/domain.py

@@ -229,6 +229,15 @@ class LoadBalancerServiceHttp(BaseDomain):
            Use sticky sessions. Only available if protocol is "http" or "https".
     """
 
+    __api_properties__ = (
+        "cookie_name",
+        "cookie_lifetime",
+        "certificates",
+        "redirect_http",
+        "sticky_sessions",
+    )
+    __slots__ = __api_properties__
+
     def __init__(
         self,
         cookie_name: str | None = None,
@@ -261,6 +270,16 @@ class LoadBalancerHealthCheck(BaseDomain):
             HTTP Config
     """
 
+    __api_properties__ = (
+        "protocol",
+        "port",
+        "interval",
+        "timeout",
+        "retries",
+        "http",
+    )
+    __slots__ = __api_properties__
+
     def __init__(
         self,
         protocol: str | None = None,
@@ -293,6 +312,15 @@ class LoadBalancerHealthCheckHttp(BaseDomain):
             Type of health check
     """
 
+    __api_properties__ = (
+        "domain",
+        "path",
+        "response",
+        "status_codes",
+        "tls",
+    )
+    __slots__ = __api_properties__
+
     def __init__(
         self,
         domain: str | None = None,
@@ -350,6 +378,16 @@ class LoadBalancerTarget(BaseDomain):
             List of health statuses of the services on this target. Only present for target types "server" and "ip".
     """
 
+    __api_properties__ = (
+        "type",
+        "server",
+        "label_selector",
+        "ip",
+        "use_private_ip",
+        "health_status",
+    )
+    __slots__ = __api_properties__
+
     def __init__(
         self,
         type: str | None = None,
@@ -401,6 +439,12 @@ class LoadBalancerTargetHealthStatus(BaseDomain):
     :param status: Load Balancer Target status. Choices: healthy, unhealthy, unknown
     """
 
+    __api_properties__ = (
+        "listen_port",
+        "status",
+    )
+    __slots__ = __api_properties__
+
     def __init__(
         self,
         listen_port: int | None = None,
@@ -416,6 +460,9 @@ class LoadBalancerTargetLabelSelector(BaseDomain):
     :param selector: str Target label selector
     """
 
+    __api_properties__ = ("selector",)
+    __slots__ = __api_properties__
+
     def __init__(self, selector: str | None = None):
         self.selector = selector
 
@@ -426,6 +473,9 @@ class LoadBalancerTargetIP(BaseDomain):
     :param ip: str Target IP
     """
 
+    __api_properties__ = ("ip",)
+    __slots__ = __api_properties__
+
     def __init__(self, ip: str | None = None):
         self.ip = ip
 
@@ -437,6 +487,9 @@ class LoadBalancerAlgorithm(BaseDomain):
             Algorithm of the Load Balancer. Choices: round_robin, least_connections
     """
 
+    __api_properties__ = ("type",)
+    __slots__ = __api_properties__
+
     def __init__(self, type: str | None = None):
         self.type = type
 

tests/unit/actions/test_domain.py

@@ -13,6 +13,16 @@
 )
 
 
+@pytest.mark.parametrize(
+    "value",
+    [
+        (Action(id=1),),
+    ],
+)
+def test_eq(value):
+    assert value == value
+
+
 class TestAction:
     def test_started_finished_is_datetime(self):
         action = Action(

tests/unit/certificates/test_domain.py

@@ -3,7 +3,25 @@
 import datetime
 from datetime import timezone
 
-from hcloud.certificates import Certificate
+import pytest
+
+from hcloud.certificates import (
+    Certificate,
+    ManagedCertificateError,
+    ManagedCertificateStatus,
+)
+
+
+@pytest.mark.parametrize(
+    "value",
+    [
+        (Certificate(id=1),),
+        (ManagedCertificateError()),
+        (ManagedCertificateStatus()),
+    ],
+)
+def test_eq(value):
+    assert value == value
 
 
 class TestCertificate:

tests/unit/datacenters/test_domain.py

@@ -0,0 +1,16 @@
+from __future__ import annotations
+
+import pytest
+
+from hcloud.datacenters import Datacenter, DatacenterServerTypes
+
+
+@pytest.mark.parametrize(
+    "value",
+    [
+        (Datacenter(id=1),),
+        (DatacenterServerTypes(available=[], available_for_migration=[], supported=[])),
+    ],
+)
+def test_eq(value):
+    assert value == value

tests/unit/deprecation/__init__.py

@@ -0,0 +1,15 @@
+from __future__ import annotations
+
+import pytest
+
+from hcloud.deprecation import DeprecationInfo
+
+
+@pytest.mark.parametrize(
+    "value",
+    [
+        (DeprecationInfo(),),
+    ],
+)
+def test_eq(value):
+    assert value == value

tests/unit/deprecation/test_domain.py

@@ -3,7 +3,29 @@
 import datetime
 from datetime import timezone
 
-from hcloud.firewalls import Firewall
+import pytest
+
+from hcloud.firewalls import (
+    Firewall,
+    FirewallResource,
+    FirewallResourceAppliedToResources,
+    FirewallResourceLabelSelector,
+    FirewallRule,
+)
+
+
+@pytest.mark.parametrize(
+    "value",
+    [
+        (Firewall(id=1),),
+        (FirewallRule(direction="in", protocol="icmp", source_ips=[]),),
+        (FirewallResource(type="server"),),
+        (FirewallResourceAppliedToResources(type="server"),),
+        (FirewallResourceLabelSelector(),),
+    ],
+)
+def test_eq(value):
+    assert value == value
 
 
 class TestFirewall:

tests/unit/firewalls/test_domain.py

@@ -3,9 +3,21 @@
 import datetime
 from datetime import timezone
 
+import pytest
+
 from hcloud.floating_ips import FloatingIP
 
 
+@pytest.mark.parametrize(
+    "value",
+    [
+        (FloatingIP(id=1),),
+    ],
+)
+def test_eq(value):
+    assert value == value
+
+
 class TestFloatingIP:
     def test_created_is_datetime(self):
         floatingIP = FloatingIP(id=1, created="2016-01-30T23:50+00:00")

tests/unit/floating_ips/test_domain.py

@@ -3,9 +3,21 @@
 import datetime
 from datetime import timezone
 
+import pytest
+
 from hcloud.images import Image
 
 
+@pytest.mark.parametrize(
+    "value",
+    [
+        (Image(id=1),),
+    ],
+)
+def test_eq(value):
+    assert value == value
+
+
 class TestImage:
     def test_created_is_datetime(self):
         image = Image(id=1, created="2016-01-30T23:50+00:00")