Merge pull request #2336 from hey-api/fix/tty

fix: respect NO_INTERACTIVE and NO_INTERACTION environment variables

Author: mrlubos

.changeset/green-wolves-join.md

@@ -0,0 +1,5 @@
+---
+'@hey-api/openapi-ts': patch
+---
+
+fix: respect NO_INTERACTIVE and NO_INTERACTION environment variables

packages/openapi-ts/bin/index.cjs

@@ -93,6 +93,14 @@ async function start() {
       'useOptions',
     ]);
 
+    const isInteractive =
+      process.stdin.isTTY &&
+      process.stdout.isTTY &&
+      !process.env.CI &&
+      !process.env.NO_INTERACTIVE &&
+      !process.env.NO_INTERACTION;
+    userConfig.interactive = isInteractive;
+
     if (params.plugins === true) {
       userConfig.plugins = [];
     } else if (params.plugins) {

packages/openapi-ts/src/config/init.ts

@@ -52,6 +52,7 @@ export const initConfigs = async (
       dryRun = false,
       experimentalParser = true,
       exportCore = true,
+      interactive = false,
       name,
       request,
       useOptions = true,
@@ -113,6 +114,7 @@ export const initConfigs = async (
       experimentalParser,
       exportCore: false,
       input,
+      interactive,
       logs,
       name,
       output,

packages/openapi-ts/src/error.ts

@@ -6,8 +6,6 @@ import colors from 'ansi-colors';
 import { findPackageJson } from './generate/tsConfig';
 import { ensureDirSync } from './generate/utils';
 
-export const isInteractive = process.stdin.isTTY && process.stdout.isTTY;
-
 export class ConfigError extends Error {}
 
 export class HeyApiError extends Error {
@@ -154,8 +152,10 @@ export const printCrashReport = ({
 
 export const shouldReportCrash = async ({
   error,
+  isInteractive,
 }: {
   error: unknown;
+  isInteractive: boolean | undefined;
 }): Promise<boolean> => {
   if (!isInteractive || error instanceof ConfigError) {
     return false;

packages/openapi-ts/src/generate/__tests__/class.test.ts

@@ -25,6 +25,7 @@ describe('generateLegacyClientClass', () => {
           timeout: 60_000,
         },
       },
+      interactive: false,
       logs: {
         file: true,
         level: 'info',

packages/openapi-ts/src/generate/__tests__/core.test.ts

@@ -40,6 +40,7 @@ describe('generateLegacyCore', () => {
           timeout: 60_000,
         },
       },
+      interactive: false,
       logs: {
         file: true,
         level: 'info',
@@ -174,6 +175,7 @@ describe('generateLegacyCore', () => {
           timeout: 60_000,
         },
       },
+      interactive: false,
       logs: {
         file: true,
         level: 'info',
@@ -291,6 +293,7 @@ describe('generateLegacyCore', () => {
           timeout: 60_000,
         },
       },
+      interactive: false,
       logs: {
         file: true,
         level: 'info',

packages/openapi-ts/src/generate/legacy/__tests__/index.test.ts

@@ -25,6 +25,7 @@ describe('generateIndexFile', () => {
           timeout: 60_000,
         },
       },
+      interactive: false,
       logs: {
         file: true,
         level: 'info',

packages/openapi-ts/src/generate/legacy/__tests__/output.test.ts

@@ -38,6 +38,7 @@ describe('generateLegacyOutput', () => {
           timeout: 60_000,
         },
       },
+      interactive: false,
       logs: {
         file: true,
         level: 'info',

packages/openapi-ts/src/index.ts

@@ -83,6 +83,9 @@ export const createClient = async (
   } catch (error) {
     const config = configs[0] as Config | undefined;
     const dryRun = config ? config.dryRun : resolvedConfig?.dryRun;
+    const isInteractive = config
+      ? config.interactive
+      : resolvedConfig?.interactive;
     const logs = config?.logs ?? getLogs(resolvedConfig);
 
     let logPath: string | undefined;
@@ -93,7 +96,7 @@ export const createClient = async (
 
     if (logs.level !== 'silent') {
       printCrashReport({ error, logPath });
-      if (await shouldReportCrash({ error })) {
+      if (await shouldReportCrash({ error, isInteractive })) {
         await openGitHubIssueWithCrashReport(error);
       }
     }

packages/openapi-ts/src/plugins/@hey-api/schemas/__tests__/schemas.test.ts

@@ -27,6 +27,7 @@ describe('generateLegacySchemas', () => {
           timeout: 60_000,
         },
       },
+      interactive: false,
       logs: {
         file: true,
         level: 'info',
@@ -162,6 +163,7 @@ describe('generateLegacySchemas', () => {
           timeout: 60_000,
         },
       },
+      interactive: false,
       logs: {
         file: true,
         level: 'info',