Skip to content

Commit 6668603

Browse files
committed
fix: apply suggestions from code review
1 parent cada379 commit 6668603

File tree

3 files changed

+7
-5
lines changed

3 files changed

+7
-5
lines changed

app/code/core/Mage/Api2/Model/Auth/Adapter/Oauth2.php

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,11 +26,13 @@ class Mage_Api2_Model_Auth_Adapter_Oauth2 extends Mage_Api2_Model_Auth_Adapter_A
2626
/**
2727
* Process request and figure out an API user type and its identifier
2828
*
29-
* Returns Varien_Object with two properties: type and id
29+
* Returns stdClass object with two properties: type and id
30+
*
31+
* @return stdClass
3032
*/
31-
public function getUserParams(Mage_Api2_Model_Request $request): Varien_Object
33+
public function getUserParams(Mage_Api2_Model_Request $request)
3234
{
33-
$userParamsObj = new Varien_Object(['type' => null, 'id' => null]);
35+
$userParamsObj = (object) ['type' => null, 'id' => null];
3436

3537
try {
3638
$token = $this->_validateToken($request);

app/code/core/Mage/Oauth2/Block/Adminhtml/Client/Edit.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
* @license https://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
1515
*/
1616

17-
declare(strict_types=1);
17+
declare(strict_types=1);
1818

1919
class Mage_Oauth2_Block_Adminhtml_Client_Edit extends Mage_Adminhtml_Block_Widget_Form_Container
2020
{

app/code/core/Mage/Oauth2/Block/Adminhtml/Client/Edit/Form.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
* @license https://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
1515
*/
1616

17-
declare(strict_types=1);
17+
declare(strict_types=1);
1818

1919
class Mage_Oauth2_Block_Adminhtml_Client_Edit_Form extends Mage_Adminhtml_Block_Widget_Form
2020
{

0 commit comments

Comments
 (0)