rector: SingularSwitchToIfRector (OpenMage#4861)

* rector: `SingularSwitchToIfRector`

- see https://getrector.com/rule-detail/singular-switch-to-if-rector

* sonar

Author: sreichel

.rector.php

@@ -64,7 +64,6 @@
             CodeQuality\If_\SimplifyIfReturnBoolRector::class,
             CodeQuality\Include_\AbsolutizeRequireAndIncludePathRector::class, # todo: TMP
             CodeQuality\Isset_\IssetOnPropertyObjectToPropertyExistsRector::class, # todo: TMP
-            CodeQuality\Switch_\SingularSwitchToIfRector::class, # todo: TMP
             CodeQuality\Ternary\NumberCompareToMaxFuncCallRector::class, # todo: TMP
             CodeQuality\Ternary\SwitchNegatedTernaryRector::class, # todo: TMP
             CodeQuality\Ternary\TernaryEmptyArrayArrayDimFetchToCoalesceRector::class, # todo: TMP

app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Form/Account.php

@@ -89,11 +89,9 @@ protected function _prepareForm()
      */
     protected function _addAdditionalFormElementData(Varien_Data_Form_Element_Abstract $element)
     {
-        switch ($element->getId()) {
-            case 'email':
-                $element->setRequired(0);
-                $element->setClass('validate-email');
-                break;
+        if ($element->getId() === 'email') {
+            $element->setRequired(0);
+            $element->setClass('validate-email');
         }
         return $this;
     }

app/code/core/Mage/Adminhtml/Block/Widget/Grid/Column.php

@@ -213,10 +213,8 @@ protected function &_applyDecorators($value, $decorators)
         if ((!is_array($decorators)) || empty($decorators)) {
             return $value;
         }
-        switch (array_shift($decorators)) {
-            case 'nobr':
-                $value = '<span class="nobr">' . $value . '</span>';
-                break;
+        if (array_shift($decorators) === 'nobr') {
+            $value = '<span class="nobr">' . $value . '</span>';
         }
         if (!empty($decorators)) {
             return $this->_applyDecorators($value, $decorators);

app/code/core/Mage/Catalog/Model/Category/Indexer/Flat.php

@@ -176,22 +176,18 @@ protected function _registerEvent(Event $event)
      */
     protected function _registerCatalogCategoryEvent(Event $event)
     {
-        switch ($event->getType()) {
-            case Event::TYPE_SAVE:
-                /** @var Category $category */
-                $category = $event->getDataObject();
-
-                /**
-                 * Check if category has another affected category ids (category move result)
-                 */
-                $affectedCategoryIds = $category->getAffectedCategoryIds();
-                if ($affectedCategoryIds) {
-                    $event->addNewData('catalog_category_flat_affected_category_ids', $affectedCategoryIds);
-                } else {
-                    $event->addNewData('catalog_category_flat_category_id', $category->getId());
-                }
-
-                break;
+        if ($event->getType() === Event::TYPE_SAVE) {
+            /** @var Category $category */
+            $category = $event->getDataObject();
+            /**
+             * Check if category has another affected category ids (category move result)
+             */
+            $affectedCategoryIds = $category->getAffectedCategoryIds();
+            if ($affectedCategoryIds) {
+                $event->addNewData('catalog_category_flat_affected_category_ids', $affectedCategoryIds);
+            } else {
+                $event->addNewData('catalog_category_flat_category_id', $category->getId());
+            }
         }
         return $this;
     }

app/code/core/Mage/Catalog/Model/Product/Indexer/Eav.php

@@ -100,10 +100,8 @@ protected function _registerEvent(Mage_Index_Model_Event $event)
                     break;
             }
         } elseif ($entity == Mage_Catalog_Model_Resource_Eav_Attribute::ENTITY) {
-            switch ($event->getType()) {
-                case Mage_Index_Model_Event::TYPE_SAVE:
-                    $this->_registerCatalogAttributeSaveEvent($event);
-                    break;
+            if ($event->getType() === Mage_Index_Model_Event::TYPE_SAVE) {
+                $this->_registerCatalogAttributeSaveEvent($event);
             }
         } elseif ($entity == Mage_Catalog_Model_Convert_Adapter_Product::ENTITY) {
             $event->addNewData('catalog_product_eav_reindex_all', true);

app/code/core/Mage/Catalog/Model/Product/Indexer/Flat.php

@@ -192,9 +192,8 @@ protected function _registerEvent(Mage_Index_Model_Event $event)
                 $process->changeStatus(Mage_Index_Model_Process::STATUS_REQUIRE_REINDEX);
                 break;
             case Mage_Catalog_Model_Product_Flat_Indexer::ENTITY:
-                switch ($event->getType()) {
-                    case Mage_Catalog_Model_Product_Flat_Indexer::EVENT_TYPE_REBUILD:
-                        $event->addNewData('id', $event->getDataObject()->getId());
+                if ($event->getType() === Mage_Catalog_Model_Product_Flat_Indexer::EVENT_TYPE_REBUILD) {
+                    $event->addNewData('id', $event->getDataObject()->getId());
                 }
                 break;
         }

app/code/core/Mage/CatalogInventory/Model/Indexer/Stock.php

@@ -206,10 +206,8 @@ protected function _registerCatalogProductEvent(Mage_Index_Model_Event $event)
      */
     protected function _registerCatalogInventoryStockItemEvent(Mage_Index_Model_Event $event)
     {
-        switch ($event->getType()) {
-            case Mage_Index_Model_Event::TYPE_SAVE:
-                $this->_registerStockItemSaveEvent($event);
-                break;
+        if ($event->getType() === Mage_Index_Model_Event::TYPE_SAVE) {
+            $this->_registerStockItemSaveEvent($event);
         }
     }
 

app/code/core/Mage/CatalogSearch/Model/Indexer/Fulltext.php

@@ -208,22 +208,20 @@ protected function _registerEvent(Mage_Index_Model_Event $event)
      */
     protected function _registerCatalogCategoryEvent(Mage_Index_Model_Event $event)
     {
-        switch ($event->getType()) {
-            case Mage_Index_Model_Event::TYPE_SAVE:
-                /** @var Mage_Catalog_Model_Category $category */
-                $category   = $event->getDataObject();
-                $productIds = $category->getAffectedProductIds();
-                if ($productIds) {
-                    $event->addNewData('catalogsearch_category_update_product_ids', $productIds);
-                    $event->addNewData('catalogsearch_category_update_category_ids', [$category->getId()]);
-                } else {
-                    $movedCategoryId = $category->getMovedCategoryId();
-                    if ($movedCategoryId) {
-                        $event->addNewData('catalogsearch_category_update_product_ids', []);
-                        $event->addNewData('catalogsearch_category_update_category_ids', [$movedCategoryId]);
-                    }
+        if ($event->getType() === Mage_Index_Model_Event::TYPE_SAVE) {
+            /** @var Mage_Catalog_Model_Category $category */
+            $category   = $event->getDataObject();
+            $productIds = $category->getAffectedProductIds();
+            if ($productIds) {
+                $event->addNewData('catalogsearch_category_update_product_ids', $productIds);
+                $event->addNewData('catalogsearch_category_update_category_ids', [$category->getId()]);
+            } else {
+                $movedCategoryId = $category->getMovedCategoryId();
+                if ($movedCategoryId) {
+                    $event->addNewData('catalogsearch_category_update_product_ids', []);
+                    $event->addNewData('catalogsearch_category_update_category_ids', [$movedCategoryId]);
                 }
-                break;
+            }
         }
 
         return $this;

app/code/core/Mage/Eav/Model/Attribute/Data/File.php

@@ -252,15 +252,11 @@ public function outputValue($format = Mage_Eav_Model_Attribute_Data::OUTPUT_FORM
     {
         $output = '';
         $value  = $this->getEntity()->getData($this->getAttribute()->getAttributeCode());
-        if ($value) {
-            switch ($format) {
-                case Mage_Eav_Model_Attribute_Data::OUTPUT_FORMAT_JSON:
-                    $output = [
-                        'value'     => $value,
-                        'url_key'   => Mage::helper('core')->urlEncode($value),
-                    ];
-                    break;
-            }
+        if ($value && $format === Mage_Eav_Model_Attribute_Data::OUTPUT_FORMAT_JSON) {
+            $output = [
+                'value'     => $value,
+                'url_key'   => Mage::helper('core')->urlEncode($value),
+            ];
         }
 
         return $output;

app/code/core/Mage/Persistent/Model/Persistent/Config.php

@@ -86,10 +86,8 @@ public function fire()
                 continue;
             }
             foreach ($elements as $info) {
-                switch ($type) {
-                    case 'blocks':
-                        $this->fireOne($info, Mage::getSingleton('core/layout')->getBlock($info['name_in_layout']));
-                        break;
+                if ($type === 'blocks') {
+                    $this->fireOne($info, Mage::getSingleton('core/layout')->getBlock($info['name_in_layout']));
                 }
             }
         }