Some phpstan fixes (OpenMage#4276)

* fixes mktime

* fixes with return type void returns

* fixes getRowUrl

* phpstan

* rector

* minor fix

Author: sreichel

.phpstan.dist.baseline.neon

@@ -52,17 +52,15 @@ protected function _prepareCollection()
      */
     protected function _afterLoadCollection()
     {
-        foreach ($this->_collection as $item) {
-        }
         return $this;
     }
 
     /**
      * @inheritDoc
+     * @throws Exception
      */
     protected function _prepareColumns()
     {
-        $baseUrl = $this->getUrl();
         $this->addColumn('cache_type', [
             'header'    => $this->__('Cache Type'),
             'width'     => '180',
@@ -104,6 +102,7 @@ protected function _prepareColumns()
      *
      * @return string
      */
+    // phpcs:ignore Generic.CodeAnalysis.UnusedFunctionParameter.FoundInExtendedClassAfterLastUsed
     public function decorateStatus($value, $row, $column, $isExport)
     {
         $class = '';
@@ -122,11 +121,12 @@ public function decorateStatus($value, $row, $column, $isExport)
     /**
      * Get row edit url
      *
-     * @return false
+     * @return string
      */
+    // phpcs:ignore Generic.CodeAnalysis.UnusedFunctionParameter.FoundInExtendedClass
     public function getRowUrl($row)
     {
-        return false;
+        return '';
     }
 
     /**

app/code/core/Mage/Adminhtml/Block/Cache/Grid.php

@@ -26,7 +26,7 @@ protected function _getElementHtml(Varien_Data_Form_Element_Abstract $element)
         $_months = [];
         for ($i = 1; $i <= 12; $i++) {
             $_months[$i] = Mage::app()->getLocale()
-                ->date(mktime(0, null, null, $i))
+                ->date(mktime(0, 0, 0, $i))
                 ->get(Zend_Date::MONTH_NAME);
         }
 

app/code/core/Mage/Adminhtml/Block/Report/Config/Form/Field/YtdStart.php

@@ -25,7 +25,7 @@ protected function _getValue(Varien_Object $row)
     {
         $data = parent::_getValue($row);
         if ((int) $data == $data) {
-            return (string) number_format($data, 2);
+            return (string) number_format((float)$data, 2);
         }
         if (!is_null($data)) {
             return $data * 1;

app/code/core/Mage/Adminhtml/Block/Tax/Rate/Grid/Renderer/Data.php

@@ -199,9 +199,9 @@ public function hasChildren($node, $websiteCode = null, $storeCode = null, $isFi
     /**
      * Get translate module name
      *
-     * @param Varien_Simplexml_Element $sectionNode
-     * @param Varien_Simplexml_Element $groupNode
-     * @param Varien_Simplexml_Element $fieldNode
+     * @param Varien_Simplexml_Element|false|null $sectionNode
+     * @param Varien_Simplexml_Element|false|null $groupNode
+     * @param Varien_Simplexml_Element|false|null $fieldNode
      * @return string
      */
     public function getAttributeModule($sectionNode = null, $groupNode = null, $fieldNode = null)

app/code/core/Mage/Adminhtml/Model/Config.php

@@ -48,17 +48,16 @@ class Mage_Adminhtml_Model_System_Store extends Varien_Object
     /**
      * @var bool
      */
+    // phpcs:ignore Ecg.PHP.PrivateClassMember.PrivateClassMemberError
     private $_isAdminScopeAllowed = true;
 
     /**
      * Init model
      * Load Website, Group and Store collections
-     *
-     * @return $this
      */
     public function __construct()
     {
-        return $this->reload();
+        $this->reload();
     }
 
     /**
@@ -122,6 +121,7 @@ public function getStoreValuesForForm($empty = false, $all = false)
             ];
         }
 
+        // phpcs:ignore Ecg.Security.ForbiddenFunction.Found
         $nonEscapableNbspChar = html_entity_decode(' ', ENT_NOQUOTES, 'UTF-8');
 
         foreach ($this->_websiteCollection as $website) {

app/code/core/Mage/Adminhtml/Model/System/Store.php

@@ -71,7 +71,7 @@ public function getUsersCollection()
      */
     public function getResourcesTree()
     {
-        return $this->_buildResourcesArray(null, null, null, null, true);
+        return $this->_buildResourcesArray(null, null, 0, null, true);
     }
 
     /**
@@ -87,7 +87,7 @@ public function getResourcesList()
      */
     public function getResourcesList2D()
     {
-        return $this->_buildResourcesArray(null, null, null, true);
+        return $this->_buildResourcesArray(null, null, 0, true);
     }
 
     /**

app/code/core/Mage/Api/Model/Roles.php

@@ -439,7 +439,7 @@ public function addParamsToBuyRequest($buyRequest, $params)
      * Return loaded product instance
      *
      * @param  int|string $productId (SKU or ID)
-     * @param  int $store
+     * @param  int|null $store
      * @param  string $identifierType
      * @return Mage_Catalog_Model_Product
      */

app/code/core/Mage/Catalog/Helper/Product.php

@@ -219,8 +219,8 @@
  *
  * @method int getTaxClassId()
  * @method string getThumbnail()
- * @method float getTaxPercent()
- * @method $this setTaxPercent(float $value)
+ * @method float|null getTaxPercent()
+ * @method $this setTaxPercent(float|null $value)
  * @method $this setTypeId(int $value)
  * @method bool getTypeHasOptions()
  * @method $this setTypeHasOptions(bool $value)
@@ -942,7 +942,7 @@ public function getFormatedPrice()
      * products it's called very often in Item->getProduct(). So removing chain of magic with more cpu consuming
      * algorithms gives nice optimization boost.
      *
-     * @param float $price Price amount
+     * @param float|null $price Price amount
      * @return $this
      */
     public function setFinalPrice($price)

app/code/core/Mage/Catalog/Model/Product.php

@@ -134,7 +134,7 @@ protected function _addCategoryUrlPath($category)
     /**
      * Retrieve stores array or store model
      *
-     * @param int $storeId
+     * @param int|null $storeId
      * @return Mage_Core_Model_Store|array
      */
     public function getStores($storeId = null)
@@ -312,6 +312,7 @@ protected function _refreshCategoryRewrites(Varien_Object $category, $parentPath
      * Refresh product rewrite
      *
      * @return $this
+     * @throws Mage_Core_Exception
      */
     protected function _refreshProductRewrite(Varien_Object $product, Varien_Object $category)
     {
@@ -502,7 +503,7 @@ public function refreshProductRewrite($productId, $storeId = null)
     /**
      * Refresh all product rewrites for designated store
      *
-     * @param int $storeId
+     * @param int|null $storeId
      * @return $this
      */
     public function refreshProductRewrites($storeId)