Skip to content

Commit bce927a

Browse files
committed
refactor: move target outside of config + remove fleet group and target id in favor for data
1 parent c7cf2df commit bce927a

File tree

1 file changed

+16
-11
lines changed

1 file changed

+16
-11
lines changed

src/rest/types/ignite.ts

Lines changed: 16 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import type {
88
Timestamp,
99
} from '../../util/types.ts';
1010
import type {Endpoint} from '../endpoints.ts';
11-
import type {TargetID} from './fleet.ts';
11+
import type {Node} from './fleet.ts';
1212

1313
/**
1414
* All regions that Hop operates in
@@ -238,7 +238,7 @@ export interface Deployment {
238238
/**
239239
* The config for this deployment
240240
*/
241-
config: Omit<DeploymentConfig, 'name'>;
241+
config: Omit<DeploymentConfig, 'name' | 'target'>;
242242

243243
/**
244244
* Current active rollout for deployment
@@ -291,6 +291,11 @@ export interface Deployment {
291291
* The group the deployment belongs in
292292
*/
293293
group_id: Id<'deployment_group'> | null;
294+
295+
/**
296+
* Target node for deployment, if its undefined its inferred as Hop
297+
*/
298+
target?: DeploymentTarget | undefined;
294299
}
295300

296301
/**
@@ -682,11 +687,6 @@ export interface DeploymentConfig {
682687
*/
683688
type: RuntimeType;
684689

685-
/**
686-
* Target node for deployment, if its undefined its inferred as Hop
687-
*/
688-
target?: DeploymentTarget | undefined;
689-
690690
/**
691691
* The version of this config
692692
*/
@@ -728,6 +728,11 @@ export interface DeploymentConfig {
728728
* Entrypoint for this deployment
729729
*/
730730
entrypoint?: string[];
731+
732+
/**
733+
* Target node for deployment, if its undefined its inferred as Hop
734+
*/
735+
target?: DeploymentTarget | undefined;
731736
}
732737

733738
/**
@@ -754,13 +759,13 @@ export interface Image {
754759

755760
export interface DeploymentTarget {
756761
/**
757-
* The type of target (Hop, Fleet Node or Fleet Group)
762+
* The type of target (Hop, Fleet Node) (fleet group coming later)
758763
*/
759-
type: 'hop' | 'fleet_node' | 'fleet_group';
764+
type: 'hop' | 'fleet_node';
760765
/**
761-
* The ID of the target that the deployment will be deployed to
766+
* The data of the target
762767
*/
763-
target_id: TargetID;
768+
data: Node | null;
764769
}
765770

766771
/**

0 commit comments

Comments
 (0)