Update html[dir] attribute during navigation #1418
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Append the `#setDirection` implementation to the existing `#setLanguage`
private method.
Use `expect` rather than `assert` in the accompanying test coverage.
Remove the `nextEventNamed("turbo:load")` test synchronization in favor
of Playwright's underlying assertion retries.
seanpdoyle
force-pushed
the
update-html-dir-attribute
branch
from
7615adf to
d49c814
Compare
seanpdoyle
approved these changes
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for updating the
html[dir]attribute during navigation, similar to how thehtml[lang]attribute is currently handled. See #1035.This is important for languages that are written from the right to the left (like Arabic).