Fix mixed torch.Tensor and DTensor in generate when use FSDP2 + LoRA #42436
+2
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
model.generateraise anFix mixed torch.Tensor and DTensorwhen FSDP2 and LoRA is applied.The trainer class is the base class for trl trainers like PPOTrainer and GRPOTrainer in which
model.generateis called during the training loop.When FSDP2 is used, all gather and reshard is automatically done for
forwardmethod but not forgenerate.This lead to the error above.
To fix it, there is a method
register_fsdp_forward_methodfor torch to manage the DTensor for us.By registering
generate, we can get ride of the error.generate is not properly supported under FSDP2 accelerating. This PR try to fix this error.
Fixes #42417 (issue)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.