Fix documentation for Trainer.place_model_on_device parameter #42534
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e#29469)Clarified the behavior of the 'place_model_on_device' parameter in Trainer.The previous description was ambiguous and did not reflect actual device handling. Signed-off-by: yuyutsu01 <[email protected]>
Member
|
I'm not sure why this PR exists! That issue was closed over a year ago. Closing for now. |
Author
|
It was My favourite first PR for hugging face :) ... But no worries looking
forward for more.
…On Tue, 2 Dec 2025, 7:06 pm Matt, ***@***.***> wrote:
Closed #42534 <#42534>.
—
Reply to this email directly, view it on GitHub
<#42534 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BLVYPKSLR4TQQYEG25NDAA337WIXVAVCNFSM6AAAAACNWQJ64OVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMRRGMYDMMRZGY3TEMI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Member
|
Haha, don't be discouraged from contributing more, in that case! Just check when an issue was created - most older issues, even if they're still open, probably aren't relevant anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the documentation for the
place_model_on_deviceparameterin the Trainer class.
The previous description was ambiguous and did not reflect the actual behavior.
This update clarifies that:
Fixes #29469.