[Quantization] fix fbgemm #42561
Merged
[Quantization] fix fbgemm #42561
+133
−120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
SunMarc
approved these changes
Dec 2, 2025
Comment on lines
54
to
62
| # Sanity checks | ||
| if isinstance(module, FbgemmFp8Linear): | ||
| if tensor_name == "weight" and value.dtype == torch.float8_e4m3fn: | ||
| raise ValueError("Expect unquantized weights but got a quantized weight") | ||
| if tensor_name == "weight_scale": | ||
| raise ValueError("Expect unquantized weights but got a weight_scale") | ||
| if isinstance(module, FbgemmFp8Llama4TextExperts): | ||
| if tensor_name == "gate_up_proj_scale" or tensor_name == "down_proj_scale": | ||
| raise ValueError("Expect unquantized weights but got a quantized weight_scale") |
Member
There was a problem hiding this comment.
let's remove those checks, this shouldn't be possible here.
Suggested change
| # Sanity checks | |
| if isinstance(module, FbgemmFp8Linear): | |
| if tensor_name == "weight" and value.dtype == torch.float8_e4m3fn: | |
| raise ValueError("Expect unquantized weights but got a quantized weight") | |
| if tensor_name == "weight_scale": | |
| raise ValueError("Expect unquantized weights but got a weight_scale") | |
| if isinstance(module, FbgemmFp8Llama4TextExperts): | |
| if tensor_name == "gate_up_proj_scale" or tensor_name == "down_proj_scale": | |
| raise ValueError("Expect unquantized weights but got a quantized weight_scale") |
| current_key_name=None, | ||
| quantization_config=None, | ||
| pre_quantized=False, | ||
| config=None, |
Comment on lines
267
to
269
| if tp_plan is not None: | ||
| tp_key = re.sub(r"\d+", "*", f"{module_name}.down_proj_scale") | ||
| tp_plan[tp_key] = None |
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: fbgemm_fp8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes fbgemm