Fix post processing methods in keypoints matching models #42018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: efficientloftr, lightglue, superglue |
4 tasks
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
m-christen
approved these changes
Nov 7, 2025
molbap
reviewed
Nov 7, 2025
Contributor
molbap
left a comment
molbap
left a comment
There was a problem hiding this comment.
Sounds good to me! Thanks for fixing/improving 🤗
Comment on lines
+33
to
+45
| if outputs.matches.shape[0] != len(target_sizes): | ||
| raise ValueError("Make sure that you pass in as many target sizes as the batch dimension of the mask") | ||
| if not all(len(target_size) == 2 for target_size in target_sizes): | ||
| raise ValueError("Each element of target_sizes must contain the size (h, w) of each image of the batch") | ||
|
|
||
| if isinstance(target_sizes, list): | ||
| image_pair_sizes = torch.tensor(target_sizes, device=outputs.matches.device) | ||
| else: | ||
| if target_sizes.shape[1] != 2 or target_sizes.shape[2] != 2: | ||
| raise ValueError( | ||
| "Each element of target_sizes must contain the size (h, w) of each image of the batch" | ||
| ) | ||
| image_pair_sizes = target_sizes |
Contributor
There was a problem hiding this comment.
Sounds good, but do we need all these exceptions handlings?
Member
Author
There was a problem hiding this comment.
I copied them from the slow processor. But yes we don't really need them indeed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #42005.
Also fixes post processing functions in superglue and lightglue fast image processors, which were wrongly taken from efficientloftr