From 29127ad438c1277bb12aafe7aa2cb85f51568017 Mon Sep 17 00:00:00 2001 From: ARS Date: Tue, 2 Dec 2025 18:13:17 +0530 Subject: [PATCH 1/2] Refactor: Remove redundant else in get_activation Simplifies control flow by removing unnecessary else block after return. --- src/transformers/activations.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/transformers/activations.py b/src/transformers/activations.py index 08a30b3dd88c..525973ecda13 100644 --- a/src/transformers/activations.py +++ b/src/transformers/activations.py @@ -345,9 +345,10 @@ def forward(self, input: Tensor) -> Tensor: def get_activation(activation_string): if activation_string in ACT2FN: return ACT2FN[activation_string] - else: - raise KeyError(f"function {activation_string} not found in ACT2FN mapping {list(ACT2FN.keys())}") + + raise KeyError(f"function {activation_string} not found in ACT2FN mapping {list(ACT2FN.keys())}") + # For backwards compatibility with: from activations import gelu_python gelu_python = get_activation("gelu_python") From 3831d2d53467dbbf3a04766ffb5f4c5b74d357b7 Mon Sep 17 00:00:00 2001 From: ARS Date: Tue, 2 Dec 2025 21:15:10 +0530 Subject: [PATCH 2/2] style: apply code quality fixes --- src/transformers/activations.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/transformers/activations.py b/src/transformers/activations.py index 525973ecda13..1312bede777e 100644 --- a/src/transformers/activations.py +++ b/src/transformers/activations.py @@ -345,10 +345,9 @@ def forward(self, input: Tensor) -> Tensor: def get_activation(activation_string): if activation_string in ACT2FN: return ACT2FN[activation_string] - + raise KeyError(f"function {activation_string} not found in ACT2FN mapping {list(ACT2FN.keys())}") - # For backwards compatibility with: from activations import gelu_python gelu_python = get_activation("gelu_python")