Skip to content
This repository was archived by the owner on Mar 22, 2020. It is now read-only.

Commit da58fdd

Browse files
authored
Merge pull request #12 from xsacha/hunter-3.0.0
Rename ANDROID_ vars to CMAKE_ vars.
2 parents 6356dbf + d1e9ea9 commit da58fdd

File tree

8 files changed

+23
-30
lines changed

8 files changed

+23
-30
lines changed

3rdparty/ippicv/downloader.cmake

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ function(_icv_downloader)
1313
set(OPENCV_ICV_PLATFORM "macosx")
1414
set(OPENCV_ICV_PACKAGE_SUBDIR "/ippicv_osx")
1515
elseif(UNIX)
16-
if(ANDROID AND (NOT ANDROID_ABI STREQUAL x86))
16+
if(ANDROID AND (NOT CMAKE_ANDROID_ARCH STREQUAL x86))
1717
return()
1818
endif()
1919
set(OPENCV_ICV_PACKAGE_NAME "ippicv_linux_20141027.tgz")

CMakeLists.txt

Lines changed: 7 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -87,8 +87,8 @@ endif()
8787

8888
include("cmake/HunterGate.cmake")
8989
HunterGate(
90-
URL "https://github.com/ruslo/hunter/archive/v0.16.24.tar.gz"
91-
SHA1 "00ab627d3d4fe5151e15b6ab2b1b1da17650984a"
90+
URL "https://github.com/ruslo/hunter/archive/v0.18.1.tar.gz"
91+
SHA1 "c1aa0ef5191e4484889866c62263a64f1ee61d3e"
9292
)
9393

9494
project(OpenCV CXX C)
@@ -300,12 +300,9 @@ include(cmake/OpenCVVersion.cmake)
300300
set(EXECUTABLE_OUTPUT_PATH "${CMAKE_BINARY_DIR}/bin" CACHE PATH "Output directory for applications" )
301301

302302
if (ANDROID)
303-
if (ANDROID_ABI MATCHES "NEON")
303+
if (CMAKE_ANDROID_ARM_NEON)
304304
set(ENABLE_NEON ON)
305305
endif()
306-
if (ANDROID_ABI MATCHES "VFPV3")
307-
set(ENABLE_VFPV3 ON)
308-
endif()
309306
endif()
310307

311308
if(ANDROID OR WIN32)
@@ -812,16 +809,12 @@ status(" Unavailable:" OPENCV_MODULES_DISABLED_FORCE THEN ${OPENCV
812809
if(ANDROID)
813810
status("")
814811
status(" Android: ")
815-
status(" Android ABI:" ${ANDROID_ABI})
812+
status(" Android ABI:" ${CMAKE_ANDROID_ARCH_ABI})
816813
status(" STL type:" ${ANDROID_STL})
817-
status(" Native API level:" android-${ANDROID_NATIVE_API_LEVEL})
818-
android_get_compatible_target(android_sdk_target_status ${ANDROID_NATIVE_API_LEVEL} ${ANDROID_SDK_TARGET} 11)
814+
status(" Native API level:" android-${CMAKE_SYSTEM_VERSION})
815+
android_get_compatible_target(android_sdk_target_status ${CMAKE_SYSTEM_VERSION} ${ANDROID_SDK_TARGET} 11)
819816
status(" SDK target:" "${android_sdk_target_status}")
820-
if(BUILD_WITH_ANDROID_NDK)
821-
status(" Android NDK:" "${ANDROID_NDK} (toolchain: ${ANDROID_TOOLCHAIN_NAME})")
822-
elseif(BUILD_WITH_STANDALONE_TOOLCHAIN)
823-
status(" Android toolchain:" "${ANDROID_STANDALONE_TOOLCHAIN}")
824-
endif()
817+
status(" Android NDK:" "${CMAKE_ANDROID_NDK} (toolchain: ${CMAKE_ANDROID_NDK_TOOLCHAIN_VERSION})")
825818
status(" android tool:" ANDROID_EXECUTABLE THEN "${ANDROID_EXECUTABLE} (${ANDROID_TOOLS_Pkg_Desc})" ELSE NO)
826819
status(" Google Play manager:" BUILD_ANDROID_SERVICE THEN YES ELSE NO)
827820
status(" Android examples:" BUILD_ANDROID_EXAMPLES AND CAN_BUILD_ANDROID_PROJECTS THEN YES ELSE NO)

cmake/OpenCVDetectAndroidSDK.cmake

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -199,10 +199,10 @@ macro(add_android_project target path)
199199
endforeach()
200200

201201
# get compatible SDK target
202-
android_get_compatible_target(android_proj_sdk_target ${ANDROID_NATIVE_API_LEVEL} ${android_proj_SDK_TARGET})
202+
android_get_compatible_target(android_proj_sdk_target ${CMAKE_SYSTEM_VERSION} ${android_proj_SDK_TARGET})
203203

204204
if(NOT android_proj_sdk_target)
205-
message(WARNING "Can not find any SDK target compatible with: ${ANDROID_NATIVE_API_LEVEL} ${android_proj_SDK_TARGET}
205+
message(WARNING "Can not find any SDK target compatible with: ${CMAKE_SYSTEM_VERSION} ${android_proj_SDK_TARGET}
206206
The project ${target} will not be build")
207207
endif()
208208

@@ -217,7 +217,7 @@ macro(add_android_project target path)
217217
# find if native_app_glue is used
218218
file(STRINGS "${path}/jni/Android.mk" NATIVE_APP_GLUE REGEX ".*(call import-module,android/native_app_glue)" )
219219
if(NATIVE_APP_GLUE)
220-
if(ANDROID_NATIVE_API_LEVEL LESS 9 OR NOT EXISTS "${ANDROID_NDK}/sources/android/native_app_glue")
220+
if(CMAKE_SYSTEM_VERSION LESS 9 OR NOT EXISTS "${CMAKE_ANDROID_NDK}/sources/android/native_app_glue")
221221
set(OCV_DEPENDENCIES_FOUND FALSE)
222222
endif()
223223
endif()
@@ -281,8 +281,8 @@ macro(add_android_project target path)
281281

282282
if(JNI_LIB_NAME)
283283
if(NATIVE_APP_GLUE)
284-
include_directories(${ANDROID_NDK}/sources/android/native_app_glue)
285-
list(APPEND android_proj_jni_files ${ANDROID_NDK}/sources/android/native_app_glue/android_native_app_glue.c)
284+
include_directories(${CMAKE_ANDROID_NDK}/sources/android/native_app_glue)
285+
list(APPEND android_proj_jni_files ${CMAKE_ANDROID_NDK}/sources/android/native_app_glue/android_native_app_glue.c)
286286
ocv_warnings_disable(CMAKE_C_FLAGS -Wstrict-prototypes -Wunused-parameter -Wmissing-prototypes)
287287
set(android_proj_NATIVE_DEPS ${android_proj_NATIVE_DEPS} android)
288288
endif()

cmake/OpenCVFindLibsGrfmt.cmake

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@ else()
99
hunter_add_package(ZLIB)
1010
find_package(ZLIB "${MIN_VER_ZLIB}")
1111
if(ZLIB_FOUND AND ANDROID)
12-
if(ZLIB_LIBRARIES STREQUAL "${ANDROID_SYSROOT}/usr/lib/libz.so" OR
13-
ZLIB_LIBRARIES STREQUAL "${ANDROID_SYSROOT}/usr/lib64/libz.so")
12+
if(ZLIB_LIBRARIES STREQUAL "${CMAKE_SYSROOT}/usr/lib/libz.so" OR
13+
ZLIB_LIBRARIES STREQUAL "${CMAKE_SYSROOT}/usr/lib64/libz.so")
1414
set(ZLIB_LIBRARIES z)
1515
endif()
1616
endif()

cmake/OpenCVGenConfig.cmake

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,10 @@ else()
1919
set(OpenCV_CUDA_VERSION ${CUDA_VERSION_STRING})
2020
endif()
2121

22-
if(NOT ANDROID_NATIVE_API_LEVEL)
22+
if(ANDROID AND NOT CMAKE_SYSTEM_VERSION)
2323
set(OpenCV_ANDROID_NATIVE_API_LEVEL_CONFIGCMAKE 0)
2424
else()
25-
set(OpenCV_ANDROID_NATIVE_API_LEVEL_CONFIGCMAKE "${ANDROID_NATIVE_API_LEVEL}")
25+
set(OpenCV_ANDROID_NATIVE_API_LEVEL_CONFIGCMAKE "${CMAKE_SYSTEM_VERSION}")
2626
endif()
2727

2828
if(CMAKE_GENERATOR MATCHES "Visual" OR CMAKE_GENERATOR MATCHES "Xcode")

cmake/templates/OpenCVConfig.cmake.in

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,7 @@ endif()
194194
# ==============================================================
195195
# Check OpenCV availability
196196
# ==============================================================
197-
if(ANDROID AND OpenCV_ANDROID_NATIVE_API_LEVEL GREATER ANDROID_NATIVE_API_LEVEL)
197+
if(ANDROID AND OpenCV_ANDROID_NATIVE_API_LEVEL GREATER CMAKE_SYSTEM_VERSION)
198198
message(FATAL_ERROR "Minimum required by OpenCV API level is android-${OpenCV_ANDROID_NATIVE_API_LEVEL}")
199199
#always FATAL_ERROR because we can't say to the caller that OpenCV is not found
200200
#http://www.mail-archive.com/[email protected]/msg37831.html

modules/java/CMakeLists.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# ----------------------------------------------------------------------------
22
# CMake file for java support
33
# ----------------------------------------------------------------------------
4-
if(IOS OR WINRT OR NOT PYTHON_DEFAULT_AVAILABLE OR NOT ANT_EXECUTABLE OR NOT (JNI_FOUND OR (ANDROID AND ANDROID_NATIVE_API_LEVEL GREATER 7))
4+
if(IOS OR WINRT OR NOT PYTHON_DEFAULT_AVAILABLE OR NOT ANT_EXECUTABLE OR NOT (JNI_FOUND OR (ANDROID AND CMAKE_SYSTEM_VERSION GREATER 7))
55
OR BUILD_opencv_world
66
)
77
ocv_module_disable(java)
@@ -252,7 +252,7 @@ if(ANDROID AND ANDROID_EXECUTABLE)
252252
set(lib_target_files ${ANDROID_LIB_PROJECT_FILES})
253253
ocv_list_add_prefix(lib_target_files "${OpenCV_BINARY_DIR}/")
254254

255-
android_get_compatible_target(lib_target_sdk_target ${ANDROID_NATIVE_API_LEVEL} ${ANDROID_SDK_TARGET} 14)
255+
android_get_compatible_target(lib_target_sdk_target ${CMAKE_SYSTEM_VERSION} ${ANDROID_SDK_TARGET} 14)
256256
configure_file("${CMAKE_CURRENT_SOURCE_DIR}/android_lib/${ANDROID_MANIFEST_FILE}" "${CMAKE_CURRENT_BINARY_DIR}/${ANDROID_MANIFEST_FILE}" @ONLY)
257257

258258
add_custom_command(OUTPUT ${lib_target_files} "${OpenCV_BINARY_DIR}/${ANDROID_MANIFEST_FILE}"

modules/ts/misc/run.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -67,9 +67,9 @@
6767
{'name': "opencv_cxx_flags", 'default': "", 'pattern': re.compile("^OPENCV_EXTRA_C_FLAGS:INTERNAL=(.*)$")},
6868
{'name': "opencv_cxx_flags_debug", 'default': "", 'pattern': re.compile("^OPENCV_EXTRA_C_FLAGS_DEBUG:INTERNAL=(.*)$")},
6969
{'name': "opencv_cxx_flags_release", 'default': "", 'pattern': re.compile("^OPENCV_EXTRA_C_FLAGS_RELEASE:INTERNAL=(.*)$")},
70-
{'name': "cxx_flags_android", 'default': None, 'pattern': re.compile("^ANDROID_CXX_FLAGS:INTERNAL=(.*)$")},
71-
{'name': "ndk_path", 'default': None, 'pattern': re.compile("^(?:ANDROID_NDK|ANDROID_STANDALONE_TOOLCHAIN)?:PATH=(.*)$")},
72-
{'name': "android_abi", 'default': None, 'pattern': re.compile("^ANDROID_ABI:STRING=(.*)$")},
70+
{'name': "cxx_flags_android", 'default': None, 'pattern': re.compile("^CMAKE_CXX_FLAGS:INTERNAL=(.*)$")},
71+
{'name': "ndk_path", 'default': None, 'pattern': re.compile("^(?:CMAKE_ANDROID_NDK)?:PATH=(.*)$")},
72+
{'name': "android_abi", 'default': None, 'pattern': re.compile("^CMAKE_ANDROID_ARCH_ABI:STRING=(.*)$")},
7373
{'name': "android_executable", 'default': None, 'pattern': re.compile("^ANDROID_EXECUTABLE:FILEPATH=(.*android.*)$")},
7474
{'name': "ant_executable", 'default': None, 'pattern': re.compile("^ANT_EXECUTABLE:FILEPATH=(.*ant.*)$")},
7575
{'name': "java_test_binary_dir", 'default': None, 'pattern': re.compile("^opencv_test_java_BINARY_DIR:STATIC=(.*)$")},

0 commit comments

Comments
 (0)