Update/mvp #453
Closed
Update/mvp #453
+20,363
−18,386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: akostiucenko <[email protected]>
Signed-off-by: akostiucenko <[email protected]>
Signed-off-by: Marin Veršić <[email protected]>
Signed-off-by: Marin Veršić <[email protected]>
Signed-off-by: Marin Veršić <[email protected]>
Signed-off-by: Marin Veršić <[email protected]>
Signed-off-by: Marin Veršić <[email protected]>
Signed-off-by: Marin Veršić <[email protected]>
Signed-off-by: Marin Veršić <[email protected]>
Signed-off-by: Marin Veršić <[email protected]>
Signed-off-by: Marin Veršić <[email protected]>
Signed-off-by: Marin Veršić <[email protected]>
Signed-off-by: Marin Veršić <[email protected]>
Signed-off-by: Marin Veršić <[email protected]>
Signed-off-by: Marin Veršić <[email protected]>
Signed-off-by: Marin Veršić <[email protected]>
Signed-off-by: Marin Veršić <[email protected]>
Signed-off-by: Marin Veršić <[email protected]>
Signed-off-by: Marin Veršić <[email protected]>
Mingela
approved these changes
Jan 29, 2025
Member
Mingela
left a comment
Mingela
left a comment
There was a problem hiding this comment.
Idk why CI fails
it's a known issue we and DevOps have tried hard to fix but no success, it's a flakiness related to the docker containers in CI which is relevant in 4 out of 5 runs :(
aoyako
approved these changes
Jan 31, 2025
aoyako
approved these changes
Jan 31, 2025
Signed-off-by: Marin Veršić <[email protected]>
Signed-off-by: Marin Veršić <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it's time to merge this to
main. If needed (if someone depends on it) a separate branch forpre-rc.22can be split frommainbefore this.All the tests are passing locally. Idk why CI fails