Skip to content

Commit 1af3457

Browse files
Skip default timeout at query level (#214)
1 parent a63ab4d commit 1af3457

File tree

7 files changed

+7
-19
lines changed

7 files changed

+7
-19
lines changed

document-store/src/integrationTest/java/org/hypertrace/core/documentstore/ArrayFiltersQueryIntegrationTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ private static void initializeAndConnectToPostgres() {
9797

9898
private static void initializeAndConnectToMongo() {
9999
mongo =
100-
new GenericContainer<>(DockerImageName.parse("mongo:7.0.14"))
100+
new GenericContainer<>(DockerImageName.parse("mongo:8.0.1"))
101101
.withExposedPorts(27017)
102102
.waitingFor(Wait.forListeningPort());
103103
mongo.start();

document-store/src/integrationTest/java/org/hypertrace/core/documentstore/DocStoreQueryV1Test.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ public class DocStoreQueryV1Test {
132132
public static void init() throws IOException {
133133
datastoreMap = Maps.newHashMap();
134134
mongo =
135-
new GenericContainer<>(DockerImageName.parse("mongo:7.0.14"))
135+
new GenericContainer<>(DockerImageName.parse("mongo:8.0.1"))
136136
.withExposedPorts(27017)
137137
.waitingFor(Wait.forListeningPort());
138138
mongo.start();

document-store/src/integrationTest/java/org/hypertrace/core/documentstore/DocStoreTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ public class DocStoreTest {
7171
public static void init() {
7272
datastoreMap = Maps.newHashMap();
7373
mongo =
74-
new GenericContainer<>(DockerImageName.parse("mongo:7.0.14"))
74+
new GenericContainer<>(DockerImageName.parse("mongo:8.0.1"))
7575
.withExposedPorts(27017)
7676
.waitingFor(Wait.forListeningPort());
7777
mongo.start();

document-store/src/integrationTest/java/org/hypertrace/core/documentstore/mongo/MongoDocStoreTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ public class MongoDocStoreTest {
7575
@BeforeAll
7676
public static void init() {
7777
mongo =
78-
new GenericContainer<>(DockerImageName.parse("mongo:7.0.14"))
78+
new GenericContainer<>(DockerImageName.parse("mongo:8.0.1"))
7979
.withExposedPorts(27017)
8080
.waitingFor(Wait.forListeningPort());
8181
mongo.start();

document-store/src/main/java/org/hypertrace/core/documentstore/model/options/QueryOptions.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package org.hypertrace.core.documentstore.model.options;
22

33
import java.time.Duration;
4+
import javax.annotation.Nullable;
45
import lombok.Builder;
56
import lombok.Builder.Default;
67
import lombok.Value;
@@ -13,5 +14,5 @@ public class QueryOptions {
1314
public static final QueryOptions DEFAULT_QUERY_OPTIONS = QueryOptions.builder().build();
1415

1516
@Default DataFreshness dataFreshness = DataFreshness.SYSTEM_DEFAULT;
16-
@Default Duration queryTimeout = Duration.ofMinutes(1);
17+
@Default @Nullable Duration queryTimeout = null;
1718
}

document-store/src/test/java/org/hypertrace/core/documentstore/mongo/MongoQueryExecutorTest.java

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -752,19 +752,6 @@ void testConnectionLevelQueryTimeout() {
752752
validate(duration);
753753
}
754754

755-
@Test
756-
void testConnectionLevelQueryTimeoutWithNullValue() {
757-
final Query query =
758-
Query.builder()
759-
.addSelection(AggregateExpression.of(COUNT, ConstantExpression.of(1)), "total")
760-
.build();
761-
762-
when(connectionConfig.queryTimeout()).thenReturn(null);
763-
executor.aggregate(query, QueryOptions.DEFAULT_QUERY_OPTIONS);
764-
765-
validate(Duration.ofMinutes(1));
766-
}
767-
768755
@Test
769756
void testConnectionAndQueryLevelQueryTimeout() {
770757
final Query query =

gradle/libs.versions.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ org-junit-jupiter-junit-jupiter = { module = "org.junit.jupiter:junit-jupiter",
2626
org-mockito-mockito-core = { module = "org.mockito:mockito-core", version.ref = "org-mockito" }
2727
org-mockito-mockito-inline = { module = "org.mockito:mockito-inline", version.ref = "org-mockito" }
2828
org-mockito-mockito-junit-jupiter = { module = "org.mockito:mockito-junit-jupiter", version.ref = "org-mockito" }
29-
org-mongodb-mongodb-driver-sync = { module = "org.mongodb:mongodb-driver-sync", version = "5.1.4" }
29+
org-mongodb-mongodb-driver-sync = { module = "org.mongodb:mongodb-driver-sync", version = "5.2.0" }
3030
org-postgresql = { module = "org.postgresql:postgresql", version = "42.5.5" }
3131
org-projectlombok-lombok = { module = "org.projectlombok:lombok", version = "1.18.30" }
3232
org-slf4j-slf4j-api = { module = "org.slf4j:slf4j-api", version = "1.7.36" }

0 commit comments

Comments
 (0)