fix skip-definer doesn't work for views with SQL SECURITY INVOKER. Fixes #243

ifsnop · ifsnop · commit d173a6f982cd · 2023-02-09T01:48:42.000Z
diff --git a/src/Ifsnop/Mysqldump/Mysqldump.php b/src/Ifsnop/Mysqldump/Mysqldump.php
@@ -1946,7 +1946,7 @@ public function create_view($row)
 
         if ($viewStmtReplaced = preg_replace(
             '/^(CREATE(?:\s+ALGORITHM=(?:UNDEFINED|MERGE|TEMPTABLE))?)\s+('
-            .self::DEFINER_RE.'(?:\s+SQL SECURITY DEFINER|INVOKER)?)?\s+(VIEW .+)$/',
+            .self::DEFINER_RE.'(?:\s+SQL SECURITY (?:DEFINER|INVOKER))?)?\s+(VIEW .+)$/',
             '/*!50001 \1 */'.PHP_EOL.$definerStr.'/*!50001 \3 */',
             $viewStmt,
             1

Original file line number	Diff line number	Diff line change
`@@ -1946,7 +1946,7 @@ public function create_view($row)`
`1946`	`1946`
`1947`	`1947`	`if ($viewStmtReplaced = preg_replace(`
`1948`	`1948`	`'/^(CREATE(?:\s+ALGORITHM=(?:UNDEFINED\|MERGE\|TEMPTABLE))?)\s+('`
`1949`		`- .self::DEFINER_RE.'(?:\s+SQL SECURITY DEFINER\|INVOKER)?)?\s+(VIEW .+)$/',`
	`1949`	`+ .self::DEFINER_RE.'(?:\s+SQL SECURITY (?:DEFINER\|INVOKER))?)?\s+(VIEW .+)$/',`
`1950`	`1950`	`'/!50001 \1 /'.PHP_EOL.$definerStr.'/!50001 \3 /',`
`1951`	`1951`	`$viewStmt,`
`1952`	`1952`	`1`