chore(pipes): extract nullable check to a function

Author: ggurkal

lib/pipes/parseBoolean.pipe.ts

@@ -1,11 +1,10 @@
 import { BadRequestException } from '../exceptions';
 import type { ParameterPipe, PipeOptions } from './ParameterPipe';
+import { validatePipeOptions } from './validatePipeOptions';
 
 export function ParseBooleanPipe(options?: PipeOptions): ParameterPipe<boolean> {
   return (value: any, name?: string) => {
-    if (!options?.nullable && value == null) {
-      throw new BadRequestException(name ? `${name} is a required parameter.` : 'Missing a required parameter.');
-    }
+    validatePipeOptions(value, name, options);
 
     if (value === true || value === 'true') {
       return true;
@@ -15,6 +14,6 @@ export function ParseBooleanPipe(options?: PipeOptions): ParameterPipe<boolean>
       return false;
     }
 
-    throw new BadRequestException('Validation failed (boolean string is expected)');
+    throw new BadRequestException(`Validation failed${name ? ` for ${name}` : ''} (boolean string is expected)`);
   };
 }

lib/pipes/parseNumber.pipe.ts

@@ -1,16 +1,16 @@
 import { BadRequestException } from '../exceptions';
 import type { ParameterPipe, PipeOptions } from './ParameterPipe';
+import { validatePipeOptions } from './validatePipeOptions';
 
 export function ParseNumberPipe(options?: PipeOptions): ParameterPipe<number> {
   return (value: any, name?: string) => {
-    if (!options?.nullable && value == null) {
-      throw new BadRequestException(name ? `${name} is a required parameter.` : 'Missing a required parameter');
-    }
+    validatePipeOptions(value, name, options);
 
     const isNumeric = ['string', 'number'].includes(typeof value) && !isNaN(parseFloat(value)) && isFinite(value);
     if (!isNumeric) {
-      throw new BadRequestException('Validation failed (numeric string is expected)');
+      throw new BadRequestException(`Validation failed${name ? ` for ${name}` : ''} (numeric string is expected)`);
     }
+
     return parseFloat(value);
   };
 }

lib/pipes/validatePipeOptions.ts

@@ -0,0 +1,8 @@
+import { BadRequestException } from '../exceptions';
+import type { PipeOptions } from './ParameterPipe';
+
+export function validatePipeOptions(value: any, name?: string, options?: PipeOptions) {
+  if (!options?.nullable && (value == null || value.toString().trim().length === 0)) {
+    throw new BadRequestException(name ? `${name} is a required parameter.` : 'Missing a required parameter.');
+  }
+}