[v12] refactor(many): type new themes properly #2229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
matyasf
commented
Nov 5, 2025
| const parsed: MainDocsData['themes'] = {} | ||
| parsed[canvas.key] = { | ||
| resource: canvas, | ||
| requirePath: '@instructure/canvas-theme' |
Collaborator
Author
There was a problem hiding this comment.
The requirePath is only used in the Themes docs pages to show how to import them. This is not needed, because now we import everything from ui-themes
matyasf
commented
Nov 5, 2025
| doc.id as keyof typeof functionalComponentThemes | ||
| ] | ||
| if (typeof generateTheme === 'function' && themeVariables) { | ||
| // @ts-ignore todo type |
Collaborator
Author
There was a problem hiding this comment.
Typing is still not perfect, but it will be much simpler to do when we can delete the old themes
balzss
changed the title
remove require path, because it was used to import from the deprecated 'canvas-theme', 'canvar-high-contrast-theme' packages remove functional theme support, it was used only for Avatar useStyle no longer needs generateComponentTheme since this is not used by new themes
matyasf
force-pushed
the
new_theme_typing
branch
from
d4add79 to
8b446d8
Compare
HerrTopi
approved these changes
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
useStyleno longer needsgenerateComponentThemesince this is not used by new themes