feat: Choose the domain of applied controls created from an audit (#2784)

* feat: Choose the domain of applied controls created from an audit

* Fix broken domain selection for applied control creation

* fix syntax

* Use scope_folder_id for subdomain filtering

---------

Co-authored-by: Nassim Tabchiche <[email protected]>

Author: monsieurswag

backend/core/models.py

@@ -4887,7 +4887,7 @@ class Meta:
     #     risk_matrix = self.risk_assessment.risk_matrix.parse_json()
     #     return [(k, v) for k, v in risk_matrix.fields[field].items()]
 
-    def get_folder_full_path(self, include_root: bool = False) -> list[Folder]:
+    def get_folder_full_path(self, *, include_root: bool = False) -> list[Folder]:
         return self.risk_assessment.get_folder_full_path(include_root=include_root)
 
     @property

backend/iam/models.py

@@ -139,7 +139,7 @@ def get_parent_folders(self) -> Generator[Self, None, None]:
         while (current_folder := current_folder.parent_folder) is not None:
             yield current_folder
 
-    def get_folder_full_path(self, include_root: bool = False) -> list[Self]:
+    def get_folder_full_path(self, *, include_root: bool = False) -> list[Self]:
         """
         Get the full path of the folder including its parents.
         If include_root is True, the root folder is included in the path.
@@ -328,7 +328,7 @@ class FolderMixin(models.Model):
         default=Folder.get_root_folder_id,
     )
 
-    def get_folder_full_path(self, include_root: bool = False) -> list[Folder]:
+    def get_folder_full_path(self, *, include_root: bool = False) -> list[Folder]:
         folders = ([self.folder] + [f for f in self.folder.get_parent_folders()])[::-1]
         if include_root:
             return folders

frontend/src/lib/components/Forms/ModelForm.svelte

@@ -93,6 +93,7 @@
 		taintedMessage?: string | boolean;
 		model: ModelInfo;
 		context?: string;
+		origin?: string | null;
 		caching?: boolean;
 		closeModal?: boolean;
 		parent?: any;
@@ -113,6 +114,7 @@
 		taintedMessage = m.taintedFormMessage(),
 		model,
 		context = 'default',
+		origin = null,
 		caching = false,
 		closeModal = false,
 		parent = {},
@@ -374,6 +376,7 @@
 				{cacheLocks}
 				{formDataCache}
 				{schema}
+				{origin}
 				{initialData}
 				{context}
 				{...rest}

frontend/src/lib/components/Forms/ModelForm/AppliedControlPolicyForm.svelte

@@ -25,6 +25,7 @@
 		cacheLocks?: Record<string, CacheLock>;
 		formDataCache?: Record<string, any>;
 		schema?: any;
+		origin?: string | null;
 		initialData?: Record<string, any>;
 		context?: string;
 		rest?: Record<string, any>;
@@ -37,6 +38,7 @@
 		cacheLocks = {},
 		formDataCache = $bindable({}),
 		schema = {},
+		origin = null,
 		initialData = {},
 		context = 'default'
 	}: Props = $props();
@@ -438,10 +440,12 @@
 <AutocompleteSelect
 	{form}
 	optionsEndpoint="folders?content_type=DO&content_type=GL"
+	optionsDetailedUrlParameters={origin === 'requirement-assessments'
+		? [['scope_folder_id', initialData.folder]]
+		: []}
 	field="folder"
 	pathField="path"
 	cacheLock={cacheLocks['folder']}
 	bind:cachedValue={formDataCache['folder']}
 	label={m.domain()}
-	hidden={initialData.folder}
 />

frontend/src/lib/components/Modals/CreateModal.svelte

@@ -26,6 +26,7 @@
 		invalidateAll?: boolean; // set to false to keep form data using muliple forms on a page
 		formAction?: string;
 		context?: string;
+		origin?: string | null;
 		additionalInitialData?: any;
 		suggestions?: { [key: string]: any };
 		taintedMessage?: string | boolean;
@@ -43,6 +44,7 @@
 		invalidateAll = true,
 		formAction = '?/create',
 		context = 'create',
+		origin = null,
 		additionalInitialData = {},
 		suggestions = {},
 		taintedMessage = false,
@@ -87,6 +89,7 @@
 			{model}
 			{closeModal}
 			{context}
+			{origin}
 			{duplicate}
 			{taintedMessage}
 			caching={true}

frontend/src/routes/(app)/(third-party)/requirement-assessments/[id=uuid]/edit/+page.svelte

@@ -85,6 +85,7 @@
 				model: data.measureModel,
 				debug: false,
 				invalidateAll: false,
+				origin: 'requirement-assessments',
 				suggestions: { reference_control: reference_controls }
 			}
 		};