Skip to content

Conversation

@JoaoFerreira-FrontEnd
Copy link
Contributor

Issue number: internal


What is the new behavior?

  • guarantee that light base is #ffffff;

Does this introduce a breaking change?

  • Yes
  • No

@JoaoFerreira-FrontEnd JoaoFerreira-FrontEnd added the package: core @ionic/core package label Nov 6, 2025
@vercel
Copy link

vercel bot commented Nov 6, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
ionic-framework Ready Ready Preview Comment Nov 6, 2025 3:11pm

@JoaoFerreira-FrontEnd JoaoFerreira-FrontEnd marked this pull request as ready for review November 6, 2025 14:47
@JoaoFerreira-FrontEnd JoaoFerreira-FrontEnd requested a review from a team as a code owner November 6, 2025 14:47
@thetaPC thetaPC changed the title fix(spinner): update light color to be White fix(spinner): update light base color Nov 6, 2025
@thetaPC thetaPC changed the title fix(spinner): update light base color fix(ionic): update light base color Nov 6, 2025
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the text for the light button also be changed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so. There is no need. This will be reviewed in the near future.

Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JoaoFerreira-FrontEnd JoaoFerreira-FrontEnd merged commit 745c134 into next Nov 6, 2025
51 checks passed
@JoaoFerreira-FrontEnd JoaoFerreira-FrontEnd deleted the ROU-12143 branch November 6, 2025 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core @ionic/core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants