Skip to content

Feat: Add shared danger file to ipfs repos #69

@SgtPooki

Description

@SgtPooki

Context: In awesome-ipfs, I added https://github.com/ipfs/awesome-ipfs/blob/master/dangerfile.js which can help to block and give more information in a comment on PRs. I talked with @lidel about this and we agreed that this would be a good addition to many of our repos.

Danger currently only has official runners for JS, ruby, swift, python, and kotlin, but there is the possibility to create a danger-runner in any language (Go, Rust, etc..): https://danger.systems/js/usage/danger-process.html
The ask for this issue is that we come up with a base file that would work for multiple repos to use as a default. Some default rules we could use are:

  1. Warning on large PRs (over X lines changed)
  2. Fail when src/ is modified without test/ modified
  3. Display lint/test failures
  4. Display code coverage changes (This should probably be done via codecov)

And there are other examples and plugins listed at https://danger.systems/js/


A few issues I could see with implementing this in github-mgmt:

  1. Accidentally overwriting a customized danger file
  2. Setting rules that are too strict for some repos

So I guess the main goal here is to make it easy for ipfs repos to get a danger file that works, and then be allowed to modify it for their needs as appropriate.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions