-
Notifications
You must be signed in to change notification settings - Fork 25
Description
Context: In awesome-ipfs, I added https://github.com/ipfs/awesome-ipfs/blob/master/dangerfile.js which can help to block and give more information in a comment on PRs. I talked with @lidel about this and we agreed that this would be a good addition to many of our repos.
Danger currently only has official runners for JS, ruby, swift, python, and kotlin, but there is the possibility to create a danger-runner in any language (Go, Rust, etc..): https://danger.systems/js/usage/danger-process.html
The ask for this issue is that we come up with a base file that would work for multiple repos to use as a default. Some default rules we could use are:
- Warning on large PRs (over X lines changed)
- Fail when src/ is modified without test/ modified
- Display lint/test failures
- Display code coverage changes (This should probably be done via codecov)
And there are other examples and plugins listed at https://danger.systems/js/
A few issues I could see with implementing this in github-mgmt:
- Accidentally overwriting a customized danger file
- Setting rules that are too strict for some repos
So I guess the main goal here is to make it easy for ipfs repos to get a danger file that works, and then be allowed to modify it for their needs as appropriate.