Skip to content

Commit 204c076

Browse files
valentinsulzerbrosaplanellakratman
authored
make SEI single layer only (pybamm-team#4470)
* make SEI single layer only * fix failing tests * remove some further instances of inner & outer SEI * shorten comment * fix failing tests * switch examples to IDAKLU solver for robustness * fix typo with SEI OCP * revert to U_SEI = 0.4 V, except O'Kane2022 where beta_inner = 0 * change U_SEI in example to avoid simulation to break (replicates old parameters) * update CHANGELOG (and sort older entries) * remove duplicated entry from CHANGELOG * Update src/pybamm/models/submodels/interface/sei/sei_growth.py * revert some parameter changes as suggested by Simon * reduce SEI diffusivity to 2 significant digits (used to be 16) * Fix changelog --------- Co-authored-by: Ferran Brosa Planella <[email protected]> Co-authored-by: Eric G. Kratz <[email protected]> Co-authored-by: kratman <[email protected]>
1 parent 103e94f commit 204c076

26 files changed

+226
-441
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
# [Unreleased](https://github.com/pybamm-team/PyBaMM/)
22

3+
## Breaking changes
4+
5+
- Double-layer SEI models have been removed (with the corresponding parameters). All models assume now a single SEI layer. ([#4470](https://github.com/pybamm-team/PyBaMM/pull/4470))
6+
37
# [v24.11.0](https://github.com/pybamm-team/PyBaMM/tree/v24.11.0) - 2024-11-20
48

59
## Features

docs/source/examples/notebooks/batch_study.ipynb

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -501,15 +501,15 @@
501501
" \"Mohtat2020_3\": pybamm.ParameterValues(\"Mohtat2020\"),\n",
502502
"}\n",
503503
"\n",
504-
"# different values for the parameter \"Inner SEI open-circuit potential [V]\"\n",
505-
"inner_sei_oc_v_values = [2.0e-4, 2.7e-4, 3.4e-4]\n",
504+
"# different values for the parameter \"SEI open-circuit potential [V]\"\n",
505+
"sei_oc_v_values = [2.0e-4, 2.7e-4, 3.4e-4]\n",
506506
"\n",
507-
"# updating the value of \"Inner SEI open-circuit potential [V]\" in all the dictionary items\n",
508-
"for _, v, inner_sei_oc_v in zip(\n",
509-
" parameter_values.keys(), parameter_values.values(), inner_sei_oc_v_values\n",
507+
"# updating the value of \"SEI open-circuit potential [V]\" in all the dictionary items\n",
508+
"for _, v, sei_oc_v in zip(\n",
509+
" parameter_values.keys(), parameter_values.values(), sei_oc_v_values\n",
510510
"):\n",
511511
" v.update(\n",
512-
" {\"Inner SEI open-circuit potential [V]\": inner_sei_oc_v},\n",
512+
" {\"SEI open-circuit potential [V]\": sei_oc_v},\n",
513513
" )\n",
514514
"\n",
515515
"# creating a Single Particle Model with \"electron-mitigation limited\" SEI\n",
@@ -527,8 +527,8 @@
527527
"batch_study.solve(initial_soc=1)\n",
528528
"\n",
529529
"labels = [\n",
530-
" f\"Inner SEI open-circuit potential [V]: {inner_sei_oc_v}\"\n",
531-
" for inner_sei_oc_v in inner_sei_oc_v_values\n",
530+
" f\"SEI open-circuit potential [V]: {inner_sei_oc_v}\"\n",
531+
" for inner_sei_oc_v in sei_oc_v_values\n",
532532
"]\n",
533533
"batch_study.plot(labels=labels)"
534534
]

docs/source/examples/notebooks/getting_started/tutorial-4-setting-parameter-values.ipynb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -656,7 +656,7 @@
656656
],
657657
"metadata": {
658658
"kernelspec": {
659-
"display_name": "env",
659+
"display_name": "venv",
660660
"language": "python",
661661
"name": "python3"
662662
},
@@ -670,7 +670,7 @@
670670
"name": "python",
671671
"nbconvert_exporter": "python",
672672
"pygments_lexer": "ipython3",
673-
"version": "3.10.12"
673+
"version": "3.11.6"
674674
},
675675
"toc": {
676676
"base_numbering": 1,

docs/source/examples/notebooks/models/half-cell.ipynb

Lines changed: 39 additions & 43 deletions
Large diffs are not rendered by default.

docs/source/examples/notebooks/models/loss_of_active_materials.ipynb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -632,7 +632,7 @@
632632
"# Changing secondary SEI solvent diffusivity to show different degradation between phases\n",
633633
"parameter_values.update(\n",
634634
" {\n",
635-
" \"Secondary: Outer SEI solvent diffusivity [m2.s-1]\": 2.5000000000000002e-24,\n",
635+
" \"Secondary: SEI solvent diffusivity [m2.s-1]\": 2.5e-24,\n",
636636
" }\n",
637637
")\n",
638638
"\n",

examples/scripts/calendar_ageing.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525

2626
sim = pb.Simulation(model, parameter_values=parameter_values)
2727

28-
solver = pb.CasadiSolver(mode="fast")
28+
solver = pb.IDAKLUSolver()
2929

3030
years = 30
3131
days = years * 365

examples/scripts/rate_capability.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,8 @@
1616
for i, C_rate in enumerate(C_rates):
1717
experiment = pybamm.Experiment(
1818
[f"Discharge at {C_rate:.4f}C until 3.2V"],
19-
period=f"{10 / C_rate:.4f} seconds",
2019
)
21-
sim = pybamm.Simulation(model, experiment=experiment, solver=pybamm.CasadiSolver())
20+
sim = pybamm.Simulation(model, experiment=experiment, solver=pybamm.IDAKLUSolver())
2221
sim.solve()
2322

2423
time = sim.solution["Time [s]"].entries

src/pybamm/input/parameters/lithium_ion/Ai2020.py

Lines changed: 7 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -534,26 +534,20 @@ def get_parameter_values():
534534
"chemistry": "lithium_ion",
535535
# sei
536536
"Ratio of lithium moles to SEI moles": 2.0,
537-
"Inner SEI reaction proportion": 0.5,
538-
"Inner SEI partial molar volume [m3.mol-1]": 9.585e-05,
539-
"Outer SEI partial molar volume [m3.mol-1]": 9.585e-05,
537+
"SEI partial molar volume [m3.mol-1]": 9.585e-05,
540538
"SEI reaction exchange current density [A.m-2]": 1.5e-07,
541539
"SEI resistivity [Ohm.m]": 200000.0,
542-
"Outer SEI solvent diffusivity [m2.s-1]": 2.5000000000000002e-22,
540+
"SEI solvent diffusivity [m2.s-1]": 2.5e-22,
543541
"Bulk solvent concentration [mol.m-3]": 2636.0,
544-
"Inner SEI open-circuit potential [V]": 0.1,
545-
"Outer SEI open-circuit potential [V]": 0.8,
546-
"Inner SEI electron conductivity [S.m-1]": 8.95e-14,
547-
"Inner SEI lithium interstitial diffusivity [m2.s-1]": 1e-20,
542+
"SEI open-circuit potential [V]": 0.4,
543+
"SEI electron conductivity [S.m-1]": 8.95e-14,
544+
"SEI lithium interstitial diffusivity [m2.s-1]": 1e-20,
548545
"Lithium interstitial reference concentration [mol.m-3]": 15.0,
549-
"Initial inner SEI thickness [m]": 2.5e-09,
550-
"Initial outer SEI thickness [m]": 2.5e-09,
551-
"Initial inner SEI on cracks thickness [m]": 2.5e-13, # avoid division by zero
552-
"Initial outer SEI on cracks thickness [m]": 2.5e-13, # avoid division by zero
546+
"Initial SEI thickness [m]": 5e-09,
547+
"Initial SEI on cracks thickness [m]": 5e-13, # avoid division by zero
553548
"EC initial concentration in electrolyte [mol.m-3]": 4541.0,
554549
"EC diffusivity [m2.s-1]": 2e-18,
555550
"SEI kinetic rate constant [m.s-1]": 1e-12,
556-
"SEI open-circuit potential [V]": 0.4,
557551
"SEI growth activation energy [J.mol-1]": 0.0,
558552
"Negative electrode reaction-driven LAM factor [m3.mol-1]": 0.0,
559553
"Positive electrode reaction-driven LAM factor [m3.mol-1]": 0.0,

src/pybamm/input/parameters/lithium_ion/Chen2020.py

Lines changed: 6 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -227,24 +227,19 @@ def get_parameter_values():
227227
"chemistry": "lithium_ion",
228228
# sei
229229
"Ratio of lithium moles to SEI moles": 2.0,
230-
"Inner SEI reaction proportion": 0.5,
231-
"Inner SEI partial molar volume [m3.mol-1]": 9.585e-05,
232-
"Outer SEI partial molar volume [m3.mol-1]": 9.585e-05,
230+
"SEI partial molar volume [m3.mol-1]": 9.585e-05,
233231
"SEI reaction exchange current density [A.m-2]": 1.5e-07,
234232
"SEI resistivity [Ohm.m]": 200000.0,
235-
"Outer SEI solvent diffusivity [m2.s-1]": 2.5000000000000002e-22,
233+
"SEI solvent diffusivity [m2.s-1]": 2.5e-22,
236234
"Bulk solvent concentration [mol.m-3]": 2636.0,
237-
"Inner SEI open-circuit potential [V]": 0.1,
238-
"Outer SEI open-circuit potential [V]": 0.8,
239-
"Inner SEI electron conductivity [S.m-1]": 8.95e-14,
240-
"Inner SEI lithium interstitial diffusivity [m2.s-1]": 1e-20,
235+
"SEI open-circuit potential [V]": 0.4,
236+
"SEI electron conductivity [S.m-1]": 8.95e-14,
237+
"SEI lithium interstitial diffusivity [m2.s-1]": 1e-20,
241238
"Lithium interstitial reference concentration [mol.m-3]": 15.0,
242-
"Initial inner SEI thickness [m]": 2.5e-09,
243-
"Initial outer SEI thickness [m]": 2.5e-09,
239+
"Initial SEI thickness [m]": 5e-09,
244240
"EC initial concentration in electrolyte [mol.m-3]": 4541.0,
245241
"EC diffusivity [m2.s-1]": 2e-18,
246242
"SEI kinetic rate constant [m.s-1]": 1e-12,
247-
"SEI open-circuit potential [V]": 0.4,
248243
"SEI growth activation energy [J.mol-1]": 0.0,
249244
"Negative electrode reaction-driven LAM factor [m3.mol-1]": 0.0,
250245
"Positive electrode reaction-driven LAM factor [m3.mol-1]": 0.0,

src/pybamm/input/parameters/lithium_ion/Chen2020_composite.py

Lines changed: 12 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -328,44 +328,34 @@ def get_parameter_values():
328328
"chemistry": "lithium_ion",
329329
# sei
330330
"Primary: Ratio of lithium moles to SEI moles": 2.0,
331-
"Primary: Inner SEI reaction proportion": 0.5,
332-
"Primary: Inner SEI partial molar volume [m3.mol-1]": 9.585e-05,
333-
"Primary: Outer SEI partial molar volume [m3.mol-1]": 9.585e-05,
331+
"Primary: SEI partial molar volume [m3.mol-1]": 9.585e-05,
334332
"Primary: SEI reaction exchange current density [A.m-2]": 1.5e-07,
335333
"Primary: SEI resistivity [Ohm.m]": 200000.0,
336-
"Primary: Outer SEI solvent diffusivity [m2.s-1]": 2.5000000000000002e-22,
334+
"Primary: SEI solvent diffusivity [m2.s-1]": 2.5e-22,
337335
"Primary: Bulk solvent concentration [mol.m-3]": 2636.0,
338-
"Primary: Inner SEI open-circuit potential [V]": 0.1,
339-
"Primary: Outer SEI open-circuit potential [V]": 0.8,
340-
"Primary: Inner SEI electron conductivity [S.m-1]": 8.95e-14,
341-
"Primary: Inner SEI lithium interstitial diffusivity [m2.s-1]": 1e-20,
336+
"Primary: SEI open-circuit potential [V]": 0.4,
337+
"Primary: SEI electron conductivity [S.m-1]": 8.95e-14,
338+
"Primary: SEI lithium interstitial diffusivity [m2.s-1]": 1e-20,
342339
"Primary: Lithium interstitial reference concentration [mol.m-3]": 15.0,
343-
"Primary: Initial inner SEI thickness [m]": 2.5e-09,
344-
"Primary: Initial outer SEI thickness [m]": 2.5e-09,
340+
"Primary: Initial SEI thickness [m]": 5e-09,
345341
"Primary: EC initial concentration in electrolyte [mol.m-3]": 4541.0,
346342
"Primary: EC diffusivity [m2.s-1]": 2e-18,
347343
"Primary: SEI kinetic rate constant [m.s-1]": 1e-12,
348-
"Primary: SEI open-circuit potential [V]": 0.4,
349344
"Primary: SEI growth activation energy [J.mol-1]": 0.0,
350345
"Secondary: Ratio of lithium moles to SEI moles": 2.0,
351-
"Secondary: Inner SEI reaction proportion": 0.5,
352-
"Secondary: Inner SEI partial molar volume [m3.mol-1]": 9.585e-05,
353-
"Secondary: Outer SEI partial molar volume [m3.mol-1]": 9.585e-05,
346+
"Secondary: SEI partial molar volume [m3.mol-1]": 9.585e-05,
354347
"Secondary: SEI reaction exchange current density [A.m-2]": 1.5e-07,
355348
"Secondary: SEI resistivity [Ohm.m]": 200000.0,
356-
"Secondary: Outer SEI solvent diffusivity [m2.s-1]": 2.5000000000000002e-22,
349+
"Secondary: SEI solvent diffusivity [m2.s-1]": 2.5e-22,
357350
"Secondary: Bulk solvent concentration [mol.m-3]": 2636.0,
358-
"Secondary: Inner SEI open-circuit potential [V]": 0.1,
359-
"Secondary: Outer SEI open-circuit potential [V]": 0.8,
360-
"Secondary: Inner SEI electron conductivity [S.m-1]": 8.95e-14,
361-
"Secondary: Inner SEI lithium interstitial diffusivity [m2.s-1]": 1e-20,
351+
"Secondary: SEI open-circuit potential [V]": 0.4,
352+
"Secondary: SEI electron conductivity [S.m-1]": 8.95e-14,
353+
"Secondary: SEI lithium interstitial diffusivity [m2.s-1]": 1e-20,
362354
"Secondary: Lithium interstitial reference concentration [mol.m-3]": 15.0,
363-
"Secondary: Initial inner SEI thickness [m]": 2.5e-09,
364-
"Secondary: Initial outer SEI thickness [m]": 2.5e-09,
355+
"Secondary: Initial SEI thickness [m]": 5e-09,
365356
"Secondary: EC initial concentration in electrolyte [mol.m-3]": 4541.0,
366357
"Secondary: EC diffusivity [m2.s-1]": 2e-18,
367358
"Secondary: SEI kinetic rate constant [m.s-1]": 1e-12,
368-
"Secondary: SEI open-circuit potential [V]": 0.4,
369359
"Secondary: SEI growth activation energy [J.mol-1]": 0.0,
370360
"Positive electrode reaction-driven LAM factor [m3.mol-1]": 0.0,
371361
# cell

0 commit comments

Comments
 (0)