Commit 204c076
make SEI single layer only (pybamm-team#4470)
* make SEI single layer only
* fix failing tests
* remove some further instances of inner & outer SEI
* shorten comment
* fix failing tests
* switch examples to IDAKLU solver for robustness
* fix typo with SEI OCP
* revert to U_SEI = 0.4 V, except O'Kane2022 where beta_inner = 0
* change U_SEI in example to avoid simulation to break (replicates old parameters)
* update CHANGELOG (and sort older entries)
* remove duplicated entry from CHANGELOG
* Update src/pybamm/models/submodels/interface/sei/sei_growth.py
* revert some parameter changes as suggested by Simon
* reduce SEI diffusivity to 2 significant digits (used to be 16)
* Fix changelog
---------
Co-authored-by: Ferran Brosa Planella <[email protected]>
Co-authored-by: Eric G. Kratz <[email protected]>
Co-authored-by: kratman <[email protected]>1 parent 103e94f commit 204c076
File tree
26 files changed
+226
-441
lines changed- docs/source/examples/notebooks
- getting_started
- models
- examples/scripts
- src/pybamm
- input/parameters/lithium_ion
- models/submodels
- interface/sei
- porosity
- parameters
- tests/unit/test_experiments
26 files changed
+226
-441
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
3 | 7 | | |
4 | 8 | | |
5 | 9 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
501 | 501 | | |
502 | 502 | | |
503 | 503 | | |
504 | | - | |
505 | | - | |
| 504 | + | |
| 505 | + | |
506 | 506 | | |
507 | | - | |
508 | | - | |
509 | | - | |
| 507 | + | |
| 508 | + | |
| 509 | + | |
510 | 510 | | |
511 | 511 | | |
512 | | - | |
| 512 | + | |
513 | 513 | | |
514 | 514 | | |
515 | 515 | | |
| |||
527 | 527 | | |
528 | 528 | | |
529 | 529 | | |
530 | | - | |
531 | | - | |
| 530 | + | |
| 531 | + | |
532 | 532 | | |
533 | 533 | | |
534 | 534 | | |
| |||
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
656 | 656 | | |
657 | 657 | | |
658 | 658 | | |
659 | | - | |
| 659 | + | |
660 | 660 | | |
661 | 661 | | |
662 | 662 | | |
| |||
670 | 670 | | |
671 | 671 | | |
672 | 672 | | |
673 | | - | |
| 673 | + | |
674 | 674 | | |
675 | 675 | | |
676 | 676 | | |
| |||
Large diffs are not rendered by default.
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
632 | 632 | | |
633 | 633 | | |
634 | 634 | | |
635 | | - | |
| 635 | + | |
636 | 636 | | |
637 | 637 | | |
638 | 638 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
28 | | - | |
| 28 | + | |
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
19 | | - | |
20 | 19 | | |
21 | | - | |
| 20 | + | |
22 | 21 | | |
23 | 22 | | |
24 | 23 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
534 | 534 | | |
535 | 535 | | |
536 | 536 | | |
537 | | - | |
538 | | - | |
539 | | - | |
| 537 | + | |
540 | 538 | | |
541 | 539 | | |
542 | | - | |
| 540 | + | |
543 | 541 | | |
544 | | - | |
545 | | - | |
546 | | - | |
547 | | - | |
| 542 | + | |
| 543 | + | |
| 544 | + | |
548 | 545 | | |
549 | | - | |
550 | | - | |
551 | | - | |
552 | | - | |
| 546 | + | |
| 547 | + | |
553 | 548 | | |
554 | 549 | | |
555 | 550 | | |
556 | | - | |
557 | 551 | | |
558 | 552 | | |
559 | 553 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
227 | 227 | | |
228 | 228 | | |
229 | 229 | | |
230 | | - | |
231 | | - | |
232 | | - | |
| 230 | + | |
233 | 231 | | |
234 | 232 | | |
235 | | - | |
| 233 | + | |
236 | 234 | | |
237 | | - | |
238 | | - | |
239 | | - | |
240 | | - | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
241 | 238 | | |
242 | | - | |
243 | | - | |
| 239 | + | |
244 | 240 | | |
245 | 241 | | |
246 | 242 | | |
247 | | - | |
248 | 243 | | |
249 | 244 | | |
250 | 245 | | |
| |||
Lines changed: 12 additions & 22 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
328 | 328 | | |
329 | 329 | | |
330 | 330 | | |
331 | | - | |
332 | | - | |
333 | | - | |
| 331 | + | |
334 | 332 | | |
335 | 333 | | |
336 | | - | |
| 334 | + | |
337 | 335 | | |
338 | | - | |
339 | | - | |
340 | | - | |
341 | | - | |
| 336 | + | |
| 337 | + | |
| 338 | + | |
342 | 339 | | |
343 | | - | |
344 | | - | |
| 340 | + | |
345 | 341 | | |
346 | 342 | | |
347 | 343 | | |
348 | | - | |
349 | 344 | | |
350 | 345 | | |
351 | | - | |
352 | | - | |
353 | | - | |
| 346 | + | |
354 | 347 | | |
355 | 348 | | |
356 | | - | |
| 349 | + | |
357 | 350 | | |
358 | | - | |
359 | | - | |
360 | | - | |
361 | | - | |
| 351 | + | |
| 352 | + | |
| 353 | + | |
362 | 354 | | |
363 | | - | |
364 | | - | |
| 355 | + | |
365 | 356 | | |
366 | 357 | | |
367 | 358 | | |
368 | | - | |
369 | 359 | | |
370 | 360 | | |
371 | 361 | | |
| |||
0 commit comments