changeg filewatcher to send didChangeWatchedFiles and properly register capabilities

Author: isaacphi

README.md

@@ -71,7 +71,7 @@ Add something like the following configuration to your Claude Desktop settings (
         "run",
         "github.com/isaacphi/mcp-language-server@latest",
         "--workspace",
-        "/Users/you/dev/yourpythoncodebase",
+        "/Users/you/dev/yourcodebase",
         "--lsp",
         "/opt/homebrew/bin/pyright-langserver",
         "--",
@@ -87,7 +87,7 @@ Add something like the following configuration to your Claude Desktop settings (
 
 Replace:
 
-- `/Users/you/dev/yourpythoncodebase` with the absolute path to your project
+- `/Users/you/dev/yourcodebase` with the absolute path to your project
 - `/opt/homebrew/bin/pyright-langserver` with the path to your language server (found using `which` command e.g. `which pyright-langserver`)
 - Any aruments after `--` are sent as arguments to your language server.
 - Any env variables are passed on to the language server. Some may be necessary for you language server. For example, `gopls` required `GOPATH` and `GOCACHE` in order for me to get it working properly.

internal/lsp/client.go

@@ -139,7 +139,8 @@ func (c *Client) InitializeLSPClient(ctx context.Context, workspaceDir string) (
 						DynamicRegistration: true,
 					},
 					DidChangeWatchedFiles: protocol.DidChangeWatchedFilesClientCapabilities{
-						DynamicRegistration: true,
+						DynamicRegistration:    true,
+						RelativePatternSupport: true,
 					},
 				},
 				TextDocument: protocol.TextDocumentClientCapabilities{
@@ -363,12 +364,9 @@ func (c *Client) CloseFile(ctx context.Context, filepath string) error {
 		},
 	}
 	log.Println("Closing", params.TextDocument.URI.Dir())
-	// TODO: properly close files. typescript-language-server currently
-	// doesn't work properly whith my file watcher implementation
-
-	// if err := c.Notify(ctx, "textDocument/didClose", params); err != nil {
-	// 	return err
-	// }
+	if err := c.Notify(ctx, "textDocument/didClose", params); err != nil {
+		return err
+	}
 
 	c.openFilesMu.Lock()
 	delete(c.openFiles, uri)

internal/lsp/initializeTypescriptLanguageServer.go

@@ -62,4 +62,3 @@ func findAllTypeScriptFiles(rootDir string) ([]string, error) {
 
 	return tsFiles, nil
 }
-

internal/lsp/server-request-handlers.go

@@ -15,6 +15,35 @@ func HandleWorkspaceConfiguration(params json.RawMessage) (interface{}, error) {
 }
 
 func HandleRegisterCapability(params json.RawMessage) (interface{}, error) {
+	var registerParams protocol.RegistrationParams
+	if err := json.Unmarshal(params, &registerParams); err != nil {
+		log.Printf("Error unmarshaling registration params: %v", err)
+		return nil, err
+	}
+
+	for _, reg := range registerParams.Registrations {
+		log.Printf("Registration received for method: %s, id: %s", reg.Method, reg.ID)
+
+		switch reg.Method {
+		case "workspace/didChangeWatchedFiles":
+			// Parse the registration options
+			optionsJSON, err := json.Marshal(reg.RegisterOptions)
+			if err != nil {
+				log.Printf("Error marshaling registration options: %v", err)
+				continue
+			}
+
+			var options protocol.DidChangeWatchedFilesRegistrationOptions
+			if err := json.Unmarshal(optionsJSON, &options); err != nil {
+				log.Printf("Error unmarshaling registration options: %v", err)
+				continue
+			}
+
+			// Store the file watchers registrations
+			notifyFileWatchRegistration(reg.ID, options.Watchers)
+		}
+	}
+
 	return nil, nil
 }
 
@@ -33,6 +62,24 @@ func HandleApplyEdit(params json.RawMessage) (interface{}, error) {
 	return protocol.ApplyWorkspaceEditResult{Applied: true}, nil
 }
 
+// FileWatchRegistrationHandler is a function that will be called when file watch registrations are received
+type FileWatchRegistrationHandler func(id string, watchers []protocol.FileSystemWatcher)
+
+// fileWatchHandler holds the current handler for file watch registrations
+var fileWatchHandler FileWatchRegistrationHandler
+
+// RegisterFileWatchHandler sets the handler for file watch registrations
+func RegisterFileWatchHandler(handler FileWatchRegistrationHandler) {
+	fileWatchHandler = handler
+}
+
+// notifyFileWatchRegistration notifies the handler about new file watch registrations
+func notifyFileWatchRegistration(id string, watchers []protocol.FileSystemWatcher) {
+	if fileWatchHandler != nil {
+		fileWatchHandler(id, watchers)
+	}
+}
+
 // Notifications
 
 func HandleServerMessage(params json.RawMessage) {

internal/protocol/pattern_interfaces.go

@@ -0,0 +1,58 @@
+package protocol
+
+import (
+	"fmt"
+	"strings"
+)
+
+// PatternInfo is an interface for types that represent glob patterns
+type PatternInfo interface {
+	GetPattern() string
+	GetBasePath() string
+	isPattern() // marker method
+}
+
+// StringPattern implements PatternInfo for string patterns
+type StringPattern struct {
+	Pattern string
+}
+
+func (p StringPattern) GetPattern() string  { return p.Pattern }
+func (p StringPattern) GetBasePath() string { return "" }
+func (p StringPattern) isPattern()          {}
+
+// RelativePatternInfo implements PatternInfo for RelativePattern
+type RelativePatternInfo struct {
+	RP       RelativePattern
+	BasePath string
+}
+
+func (p RelativePatternInfo) GetPattern() string  { return string(p.RP.Pattern) }
+func (p RelativePatternInfo) GetBasePath() string { return p.BasePath }
+func (p RelativePatternInfo) isPattern()          {}
+
+// AsPattern converts GlobPattern to a PatternInfo object
+func (g *GlobPattern) AsPattern() (PatternInfo, error) {
+	if g.Value == nil {
+		return nil, fmt.Errorf("nil pattern")
+	}
+
+	switch v := g.Value.(type) {
+	case string:
+		return StringPattern{Pattern: v}, nil
+	case RelativePattern:
+		// Handle BaseURI which could be string or DocumentUri
+		basePath := ""
+		switch baseURI := v.BaseURI.Value.(type) {
+		case string:
+			basePath = strings.TrimPrefix(baseURI, "file://")
+		case DocumentUri:
+			basePath = strings.TrimPrefix(string(baseURI), "file://")
+		default:
+			return nil, fmt.Errorf("unknown BaseURI type: %T", v.BaseURI.Value)
+		}
+		return RelativePatternInfo{RP: v, BasePath: basePath}, nil
+	default:
+		return nil, fmt.Errorf("unknown pattern type: %T", g.Value)
+	}
+}