Skip to content

Conversation

@astagi
Copy link
Member

@astagi astagi commented Oct 31, 2024

Fixes #

PR Checklist

  • My branch is up-to-date with the Upstream main branch.
  • The unit tests pass locally with my changes (if applicable).
  • I have added tests that prove my fix is effective or that my feature works (if applicable).
  • I have added necessary documentation (if appropriate).

Short description of what this resolves:

Changes proposed in this Pull Request:

@vercel
Copy link

vercel bot commented Oct 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
design-react-kit ✅ Ready (Inspect) Visit Preview Nov 7, 2024 4:46pm

@astagi astagi marked this pull request as draft October 31, 2024 17:51
@astagi astagi linked an issue Oct 31, 2024 that may be closed by this pull request
1 task
@astagi astagi requested a review from Fupete November 7, 2024 15:59
@astagi astagi marked this pull request as ready for review November 7, 2024 15:59
@Fupete
Copy link

Fupete commented Nov 7, 2024

A livello funzionalità mi sembra apposto ora.

@astagi astagi merged commit 9e20c53 into main Nov 7, 2024
5 checks passed
@codecov
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 44.44444% with 10 lines in your changes missing coverage. Please review.

Project coverage is 97.32%. Comparing base (525105c) to head (64e6ef8).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/Forward/Forward.tsx 33.33% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1114      +/-   ##
==========================================
- Coverage   97.35%   97.32%   -0.03%     
==========================================
  Files         357      357              
  Lines       25291    25297       +6     
  Branches     1695     1695              
==========================================
  Hits        24621    24621              
- Misses        668      674       +6     
  Partials        2        2              
Flag Coverage Δ
unittests 97.32% <44.44%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@astagi astagi deleted the fix/1089_a11y_forward branch December 2, 2024 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Componente Forward: correggere a11y

3 participants