Skip to content

Conversation

@astagi
Copy link
Member

@astagi astagi commented Aug 1, 2025

Fixes #1191

PR Checklist

  • My branch is up-to-date with the Upstream main branch.
  • The unit tests pass locally with my changes (if applicable).
  • I have added tests that prove my fix is effective or that my feature works (if applicable).
  • I have added necessary documentation (if appropriate).

Short description of what this resolves:

Changes proposed in this Pull Request:

@vercel
Copy link

vercel bot commented Aug 1, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
design-react-kit Ready Ready Preview Sep 17, 2025 7:52am

@codecov
Copy link

codecov bot commented Sep 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.61%. Comparing base (925fe11) to head (3264a72).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1199      +/-   ##
==========================================
- Coverage   96.95%   96.61%   -0.34%     
==========================================
  Files         392      392              
  Lines       28516    28273     -243     
  Branches     1920     1878      -42     
==========================================
- Hits        27647    27316     -331     
- Misses        863      951      +88     
  Partials        6        6              
Flag Coverage Δ
unittests 96.61% <100.00%> (-0.34%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@federico-ntr
Copy link
Contributor

From a quick look the CSS attributes regarding border radius are equal to BI ones, but still they look sharp as a knife. Have you already checked that issue out? Otherwise I'll try to save some time and fix it myself : )

@astagi
Copy link
Member Author

astagi commented Sep 17, 2025

From a quick look the CSS attributes regarding border radius are equal to BI ones, but still they look sharp as a knife. Have you already checked that issue out? Otherwise I'll try to save some time and fix it myself : )

@federico-ntr Sent you a message on Slack talk to you later!

@federico-ntr
Copy link
Contributor

From a quick look the CSS attributes regarding border radius are equal to BI ones, but still they look sharp as a knife. Have you already checked that issue out? Otherwise I'll try to save some time and fix it myself : )

After talking with @astagi I realized that cards examples in BI docs have the class rounded applied, so I realized that was not the default appearance.
The prop rounded is working correctly in the Card component, my bad for wasting the time of anyone who looked into it.

@astagi
Copy link
Member Author

astagi commented Sep 17, 2025

From a quick look the CSS attributes regarding border radius are equal to BI ones, but still they look sharp as a knife. Have you already checked that issue out? Otherwise I'll try to save some time and fix it myself : )

After talking with @astagi I realized that cards examples in BI docs have the class rounded applied, so I realized that was not the default appearance. The prop rounded is working correctly in the Card component, my bad for wasting the time of anyone who looked into it.

No problem @federico-ntr any doubt is welcome!

@astagi astagi merged commit bf62d1b into main Sep 17, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: nuove Card (promemoria)

3 participants