Update build and test infrastructure

Author: ivogabe

.gitmodules

@@ -1,3 +1,7 @@
 [submodule "typescript/dev"]
 	path = typescript/dev
 	url = https://github.com/Microsoft/TypeScript.git
+
+[submodule "typescript/2.3"]
+	path = typescript/2.3
+	url = https://github.com/Microsoft/TypeScript.git

gulpfile.js

@@ -13,24 +13,18 @@ var diff = require('gulp-diff');
 
 var tsVersions = {
 	dev: './typescript/dev',
-	release14: './typescript/1-4',
-	release15: './typescript/1-5',
-	release16: './typescript/1-6',
-	release17: './typescript/1-7'
+	release23: './typescript/2.3',
 };
 
 function findTSDefinition(location) {
 	return path.join(path.dirname(require.resolve(location)), 'typescript.d.ts');
 }
 
-var tsOptions = {
-	target: 'es5',
-	module: 'commonjs',
-	declaration: true,
-	preserveConstEnums: true,
-	typescript: require('./typescript/dev')
-};
-var tsProject = ts.createProject(tsOptions);
+function createProject() {
+	return ts.createProject('lib/tsconfig.json', {});
+}
+
+var tsProject = createProject();
 
 var paths = {
 	scripts: ['lib/**.ts'],
@@ -64,45 +58,28 @@ gulp.task('scripts', ['clean'], function() {
 });
 
 // Type checking against multiple versions of TypeScript
-// Checking against the current release of TypeScript on NPM can be done using `gulp scripts`.
-gulp.task('typecheck-1.4', function() {
-	return gulp.src(paths.scripts.concat([
-		'!definitions/typescript.d.ts',
-		findTSDefinition(tsVersions.release14)
-	])).pipe(ts(tsOptions));
-});
-gulp.task('typecheck-1.5', function() {
-	return gulp.src(paths.scripts.concat([
-		'!definitions/typescript.d.ts',
-		findTSDefinition(tsVersions.release15)
-	])).pipe(ts(tsOptions));
-});
-gulp.task('typecheck-1.6', function() {
-	return gulp.src(paths.scripts.concat([
-		'!definitions/typescript.d.ts',
-		findTSDefinition(tsVersions.release16)
-	])).pipe(ts(tsOptions));
-});
-gulp.task('typecheck-1.7', function() {
+gulp.task('typecheck-dev', function() {
 	return gulp.src(paths.scripts.concat([
 		'!definitions/typescript.d.ts',
-		findTSDefinition(tsVersions.release17)
-	])).pipe(ts(tsOptions));
+		findTSDefinition(tsVersions.dev)
+	])).pipe(createProject()());
 });
-gulp.task('typecheck-dev', function() {
+
+gulp.task('typecheck-2.3', function() {
 	return gulp.src(paths.scripts.concat([
 		'!definitions/typescript.d.ts',
-		findTSDefinition(tsVersions.dev)
-	])).pipe(ts(tsOptions));
+		findTSDefinition(tsVersions.release23)
+	])).pipe(createProject()());
 });
 
-gulp.task('typecheck', [/* 'typecheck-1.4', 'typecheck-1.5', 'typecheck-1.6', */ 'typecheck-dev']);
+gulp.task('typecheck', ['typecheck-dev', 'typecheck-2.3']);
 
 // Tests
 
 // We run every test on multiple typescript versions:
 var libs = [
-	['2.0', undefined],
+	['2.4', undefined],
+	['2.3', require(tsVersions.release23)],
 	['dev', require(tsVersions.dev)]
 ];
 

lib/main.ts

@@ -1,5 +1,4 @@
 import * as ts from 'typescript';
-import * as fs from 'fs';
 import * as path from 'path';
 import * as _project from './project';
 import * as utils from './utils';

lib/project.ts

@@ -150,8 +150,8 @@ class CompileStream extends stream.Duplex implements ICompileStream {
 
 	private project: ProjectInfo;
 
-	_write(file: any, encoding, cb: (err?) => void);
-	_write(file: VinylFile, encoding, cb = (err?) => {}) {
+	_write(file: any, encoding: string, cb: (err?: any) => void): void;
+	_write(file: VinylFile, encoding: string, cb = (err?: any) => {}) {
 		if (!file) return cb();
 
 		if (file.isNull()) {
@@ -172,7 +172,7 @@ class CompileStream extends stream.Duplex implements ICompileStream {
 
 	}
 
-	end(chunk?, encoding?, callback?) {
+	end(chunk?: any, encoding?: any, callback?: any) {
 		if (typeof chunk === 'function') {
 			this._write(null, null, chunk);
 		} else if (typeof encoding === 'function') {

lib/reporter.ts

@@ -105,7 +105,6 @@ export function longReporter(): Reporter {
 	}
 }
 export function fullReporter(fullFilename: boolean = false): Reporter {
-	const typescript: typeof ts = require('typescript');
 	return {
 		error: (error: TypeScriptError, typescript: typeof ts) => {
 			console.error('[' + gutil.colors.gray('gulp-typescript') + '] '

lib/tsconfig.json

@@ -3,6 +3,9 @@
 		"target": "ES5",
 		"module": "commonjs",
 		"noUnusedLocals": true,
-		"declaration": true
+		"noImplicitAny": true,
+		"noImplicitReturns": true,
+		"declaration": true,
+		"preserveConstEnums": true
 	}
 }

package.json

@@ -78,7 +78,7 @@
     "gulp-sourcemaps": "~1.6.0",
     "merge-stream": "~1.0.0",
     "rimraf": "~2.5.2",
-    "typescript": "2.3.3"
+    "typescript": "2.4.1"
   },
   "peerDependencies": {
     "typescript": "~2.0.3 || >=2.0.0-dev || >=2.1.0-dev || >=2.2.0-dev || >=2.3.0-dev || >=2.4.0-dev || >=2.5.0-dev"